From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D77C4167B for ; Wed, 6 Dec 2023 17:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD186B0083; Wed, 6 Dec 2023 12:09:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7E316B0085; Wed, 6 Dec 2023 12:09:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CBC6B0089; Wed, 6 Dec 2023 12:09:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B82516B0083 for ; Wed, 6 Dec 2023 12:09:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 81EC5C01CF for ; Wed, 6 Dec 2023 17:09:02 +0000 (UTC) X-FDA: 81537028524.13.850C700 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id 0159D100012 for ; Wed, 6 Dec 2023 17:08:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=L+CvLHi1; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701882540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=syJatMfK/wH2rJw1E1uKygfYLBS1W+elXK6C2NFu5ds=; b=UswKXPEif1xncOcufS6w/tiXtUGMIp7/9xerpBjPua6fIEc0xp6MZ8EWSTrtJxlKZavXms xwQ5WoP0o1mmi1ju/XKVGhK37INZBgKl9RUsMx7M0uxJn+tK4fujApx91gjM9x9pWO1B7m 8l5yxFXHd+Pq2o33HUQkLEW86wXykKA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=L+CvLHi1; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701882540; a=rsa-sha256; cv=none; b=5DTHk6yNn17mkdAk/IYmkJrPlJL0/spCHqAA1CUW1g5FOVo/BSlTHC7U69EVeJExpfDWoD toF12TUK9gN9dblQT4XTl8M29iLAKlOPEsJ54hv3DlcERzuwxbnSc9193SqxBSg0qN5Ump BwBU2nhXaVKBwYqOwNHbJ+FvJbQyung= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 24CE240E00A9; Wed, 6 Dec 2023 17:08:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qdonn0T6sgYY; Wed, 6 Dec 2023 17:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1701882535; bh=syJatMfK/wH2rJw1E1uKygfYLBS1W+elXK6C2NFu5ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L+CvLHi1a5PAX62soPMbGVI44U6yqhBLPfTKNkYp3/FonMG+LKYAqAMyqrYN7jdtT QFXOsWJdCbLgIJ8lehQbowXcnj8V4liULEGGxY6D4Inp1hc4UFfzlBLLYYfJzq2Cer HJTwGxPhojM0nzuIa+KUoVSJ9P5JUePBa2CkxtPeIeyZUdQQ2WzLjNr9vpKU3bdWAz TbEmie9zVaDlG26chSYXlva1dgXV8kUQ1R5NxayD2RIQvrUTgc4mc/OoFEvlX8ogox Z2OgaFgkce1qyc5jjp7GRipYRUnQALLerVuk+lZSPCu5J9ONvQHy8wgJ1+Z513GcPv 6xNiUCJfVJOiPjN53uKix3mLWUoUPMsyI4iEuoAoOXihc4wljCe417moCxA2FbQQJS JGVwl6ynujmrA/cokaxTliAh4AMklvxaiTK44lx106HduGwuMckNBBmxrL4R5cx9Sd 6bXuGRDHgK1Oj1xDnR6Hva0/xE94dyLvKHjI4Kxt3ovhh/8Dw89+o75ZASNDHWLCuf XtkxafdarAvul3b2GiuXDUczTS8RXFbwVAVbzXHDcx6MWQK+J8rdDOjwMV4AuQSGLf WSa7fw61hqHYydNHN3kR9shGLQ6KRFKMKErvjn/61SFoV5OdDE4535LkGFqCrirq33 D3lukmtcsGspP570eeinh8O0= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B238A40E00C6; Wed, 6 Dec 2023 17:08:13 +0000 (UTC) Date: Wed, 6 Dec 2023 18:08:07 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh , Jarkko Sakkinen Subject: Re: [PATCH v10 14/50] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: <20231206170807.GBZXCqd0z8uu2rlhpn@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-15-michael.roth@amd.com> <20231127095937.GLZWRoiaqGlJMX54Xb@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0159D100012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5g1eoyaybfyj1qxi16eobp8nak1tyikd X-HE-Tag: 1701882539-397103 X-HE-Meta: U2FsdGVkX18Q7oMXgOimckqgzj0SGUyhmANDIg4O5DizI0tWorTcOwcHTE6FiSLHWz6mgV8hpKuoWbU5yBtAgO0R4GPOXx3GEe73ZKm5fIjyIM5RpLqeMsBoIcIx6humL2TimGe+7XmI8J5jPcpRWyS2W8xxB/8x5Q+sUR2tCnM6eNmHLAK+9/+kSats2hduLBPLAQHaB53J58PFVVDQt3Hk8MVNCGRzifhOcFV6TQmn3leGjEvnUtDyfIgb02H1xDtPUKtDDhVoOx/I8SqnQJF412nvD3+GsS0c6TopvHJqTLp3T2r6vXjIa2kdNG1ga+dusRFQ6gcB/h9CIusqTfMkRg9vbBGSzqE9ij/XY6enoQ5t8Vg5+2tjGnRnK59PT5JRkBZ2DILSfzrM5Kf/f3qYT7YfbFi4spzHHWvJOlGuvZF+XRj1GzGUrQ9dmvq++8ZjA49bnU743keanDGj4IqsvctCUSD79xrdJixf1skYgPOyKVns5E1VbBLmwvDtXjfl+LVrRf8xYVsS+vNxsGfLTmSFe5uCx6ia4GQlikk+dKiyevPOYIle8XYIgpIbfaY9cWfl9I8foYe2okMyyELwcgLogIsdvlyLKbgQInZUnmPAEMVnR0q/2lOudl0oaomoxSEvBop4ZwLBafIPcjE+ajg1daQRBl5+ebw2J19E4p8oxuSWnH6/d15GmyqgVXXao/mJoUmQSoFjNuZtRFpTPX+kGhuXho7DjI3Rv1pYLd/nZ/POGOSh2AC4OmegXwBeT5K/AD4vgTSEOoY72vgWrYZ/AsUsdGmfCDV8Cg8IoXcghf919+Gg2RXzqjY7qL5uomP21T4ooFK/Raow6yzJC+ivPAII4RlvlocLNLr4t6o6LBgA983OSzWOD7wHsM6BKXqx7m5NX0bp9NZrtKZWZva+PTgvSkWnrZjJy1U2h5Gx7MHm2/GQggWnTqIkjq5Gcq/qGsy+rpr6Lkb 9dH4kE+u IamoQUMOZ6dGhQz2I1QFmxzeLOTwdNqdli9kTtodihwvVqG6Jxuwz2nIlR7XXMyCYfbCSGGoOkoJr30uKYTUHB5U83yeF9HTh/syfYEm6zu+txsEP9QQPiFQqzqswqemcUrgA14pLCI9cQAJnD6X3uvSx0HfUIOPzWqtv749zAfagqhvLz9Entco3/p4mRKHaSE1/4IejirQFF1c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 08:13:52PM -0600, Kalra, Ashish wrote: > It surely seems hard to follow up, so i am anyway going to clean it up by: > > Adding the "probe" parameter to sev_platform_init() where the parameter > being true indicates that we only want to do SNP initialization on probe, > the same parameter will get passed on to > __sev_platform_init_locked(). That's exactly what you should *not* do - the probe parameter controls whether if (psp_init_on_probe) __sev_platform_init_locked(error); and so on should get executed or not. If it is unclear, lemme know and I'll do a diff to show you what I mean. > > > + /* Prepare for first SNP guest launch after INIT */ > > > + wbinvd_on_all_cpus(); > > > > Why is that WBINVD needed? > > As the comment above mentions, WBINVD + DF_FLUSH is needed before the first > guest launch. Lemme see if I get this straight. The correct order is: WBINVD SNP_INIT_* WBINVD DF_FLUSH If so, do a comment which goes like this: /* * The order of commands to execute before the first guest * launch is the following: * * bla... */ > In the latest code base, _sev_snp_shutdown_locked() is called from > __sev_firmware_shutdown(). Then carve that function out only when needed - do not do changes preemptively. This is not helping during review. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette