From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB47C10DCE for ; Wed, 6 Dec 2023 20:28:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD8A6B0081; Wed, 6 Dec 2023 15:28:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AE0C6B0087; Wed, 6 Dec 2023 15:28:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676C36B0088; Wed, 6 Dec 2023 15:28:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 55CC96B0081 for ; Wed, 6 Dec 2023 15:28:55 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 18A7D1C06EA for ; Wed, 6 Dec 2023 20:28:55 +0000 (UTC) X-FDA: 81537532230.29.879EEE2 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf13.hostedemail.com (Postfix) with ESMTP id 4A8E52001A for ; Wed, 6 Dec 2023 20:28:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kjfJM9OD; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701894533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XTBTLAqDXor1l6sg34c9kbUSBjJSEI8UiBBYr9CwL2Q=; b=nigvI5cI9IqbkCE0JPoLdgHepng30/IdH11rw/+xsZ/N/NE+F2oXqzeY1UlDPzMUMTMOuM VerPLM0l/tZy6QUBWCLie4VXkG6cd5EYyf2/99kWA0qEQXtkTUdu49poPQiYIRjo3P7UtM LsCatNt7DXpssq1w4LVUiXGbv3oxE34= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kjfJM9OD; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701894533; a=rsa-sha256; cv=none; b=5U379e8CLQDmtbtzmdUnLljH5VrqV++OxPhr/FoaMh8JPmYLtEog3yb3AiXWBcY04AGHSR 5o5elEDUBXO2FzpCwBVqxmfl9zYrZtniiIws8ahCSs+AKtvqRV7wkEekueleqZLQ4PJhBg IMS2HKhVDFTSPx7NqD7IlkE9QweEB6Q= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5c699b44dddso120807a12.1 for ; Wed, 06 Dec 2023 12:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701894532; x=1702499332; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XTBTLAqDXor1l6sg34c9kbUSBjJSEI8UiBBYr9CwL2Q=; b=kjfJM9ODIgVYVeUZVFGA/mfSTOeOJl0D7cFCHK+iRm9zr+wep15NiUGjq9AD245Ncu Dest0U9ABgLakOjy8M5mLiXk8BXX1nYsef3gFaia95Q/3Hr6Ibmg0aV6eyOimMf+jUmS ZXME8GPBhdYe951g5i/UOVadw1//1jIuq7FAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701894532; x=1702499332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XTBTLAqDXor1l6sg34c9kbUSBjJSEI8UiBBYr9CwL2Q=; b=ONRyZe+vzmf4q0f6DkxWYUxtq3JJmWQ9efXMc+mtFDAmc4wjzxgt/9eAgd+4hs7EIv fJfZgmzTE1DcoeZB0QHUrafrcCosjQFhnUTdv1rg66TXxNluy19R/8PjRYG4QaSZd4M8 iW7/Si7kXmPFme0ToCWl4BYRbzIjm6F7MNtypw4u7Pg6trJCd7VO5re7P4KSjxYK/gcK rTx9JleGsimAmF41gCoGlJYKUDh/qHIlbahlXrHjAd4k7ZA91YfJP1neOWy3Z22Om1tq zotYsG8s0Vqznzjv7/DeCz3e2KlKE7le0Cc8dzCcgdElqkczIlv24W30dNqtOXAlLwDR 456w== X-Gm-Message-State: AOJu0Yxg0icUyR+QStx9hWoA1PsDZV/vImR5Rk++c/CuVcQIao6uMBfW iK7wlLAcYNpy+fnTEFD9n4RMIQ== X-Google-Smtp-Source: AGHT+IGCJW9aAT/9l5dWk1euSiHsIcWqvf5+MSkN2kUSEvXz1J47cG2MljPvGZxmFTZ5NhzqTZhnjg== X-Received: by 2002:a17:90a:d796:b0:286:d42d:e7e with SMTP id z22-20020a17090ad79600b00286d42d0e7emr1213709pju.3.1701894532050; Wed, 06 Dec 2023 12:28:52 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id fz20-20020a17090b025400b00280a2275e4bsm280195pjb.27.2023.12.06.12.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 12:28:51 -0800 (PST) Date: Wed, 6 Dec 2023 12:28:50 -0800 From: Kees Cook To: Palmer Dabbelt Cc: samitolvanen@google.com, Paul Walmsley , aou@eecs.berkeley.edu, akpm@linux-foundation.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] riscv: Increase mmap_rnd_bits_max on Sv48/57 Message-ID: <202312061228.B953DE8CA@keescook> References: <20230929211155.3910949-4-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: z8rqpfrfcchfxfw9jm5btdhw3ceeeob6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4A8E52001A X-HE-Tag: 1701894533-508935 X-HE-Meta: U2FsdGVkX1+nyDPFGrFSA83ilW3E539YjFG/r9KHDMigT1vX5mNgrzAYNb2zeRku9jlH2dvnDsOO6Pw1wbCOW5M7UY+s0tBa+n364ffUuNBRHOATqhAMaU4cTUnnT8N8zYZcDREzDLcaMjvB5vxBOWgYzKTqf1K8/tOesP/rPaXMTR2pGepSVQWsQlmQNfK2BWBrH7HJ/jXw/rhPF/gFpRiWGAiBSj2nLOLXDd9xKg+5WwawYUBol85mFf4v2LVV2kZEjmAVwWjn9WbLqqwBFwbwTP3VOWgijhH9yEzuJFEGjYXdhVDRjymC74IAyMnHIbUHQO4ZseU71xcZ9rgmLTPKBaV2CJCaKDjRqljt4sk4ByRsgJAt7u23vLrGw/Jd2bCNbWz/rZIt5miCMdZaiHiSvEHjP8oBykGO93fNkCsNteifm4ajln/iQqppnVnDU5xd/0Z31IGb7HI9sEXA493NMmUVN5z2vrCHuYw9rNbEzGVzZkUI4t4wZ4HiwWt6Kt9K21NcPegP1HQZs8M0V56rmU2iUloIleli1d26Atj/XwMfww+AgA13sMGaiEiFZWYXwT6heKVRfUcGwwEQCV2ryP6iA9BE79/CNQGSlsdTwZf035XT/jPB0+ytofJFvsFlUrlI3aVNs5dMtGTn9phi8LJNEYv+QwoYwc8/3QA/l86xgtnMF5dTov8V2ENzwjqTaruY+IzGU9QQP0jbW1OKEPFcpdPjWQiX6jouV56Eb1K9GBBXohjn8In5JeqTWtfVSbbXaSJ6r5tK6riugoBvgQKUul5JkuzR0785xT88MN1vR0+LqV2lbywFtA/h9Eq+4IFRPZKxq4kDplHZHI2vOPiyXyO7hEuY4EYATi8PqZ8Qq0FOp7WUkonHyaqXNGmALttHIZsBXk4xAiVMbLT2PYFPIHFpFATkPVG2X+vJcJj1Fr8jyWc93dkbJQgjpwmTR04aILPZs56p3R3 1OvC30T4 ZBgUMCNKwhil/7npisdCZHJ+55w1CWhn66YpRlELHK2JOIX1N6xoZR9pGJHppiC+W679SgoD5OQiRhvbOY3PE5ywVfQlbuYvTXQoSkc8bq9TRj0Q2E3Zv8bUlgdkSuCNUy+xyLGEKJjSvQMF/PdpRzAEVmDqo+Rlns1XA45MsRzMXf8/RTt2ifP6hWEvaswlvDuMDkiLxbyFmu/4fxkuJCGFR2bhIrE1PPxT+Ko0hpkIJEo+jwHBPTOn8zzM3qG005VRZreai0aJ3mGVbZA1BVu5tgR4p2NdtyWSjFl1Fwj1TikNRugC/d+6IX1pbZ1zduwRtmivxAdiBptzdztpbNlXtaqLnxouiV/3iA+HKzJUitHGKHmr5hvHeidC7QCv0aOMOVhhyMqt5yXqTCkl3izHHc6dXuU4CUcXcOoCyp6aT6mQYdfqtbVUcs+i4zjKyzqzP32AjRt5fFgaVYYIvqbXD4AGzXGd0Eu8UvExRPeddYQnHYvOIKhCPejxZUe+E32rc8Wt6fbfwS6UaVE4qgQn1XG74/6c8H/wB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000081, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 05:14:26AM -0800, Palmer Dabbelt wrote: > On Fri, 29 Sep 2023 14:11:56 PDT (-0700), samitolvanen@google.com wrote: > > Hi all, > > > > We noticed that 64-bit RISC-V kernels limit mmap_rnd_bits to 24 > > even if the hardware supports a larger virtual address space size > > [1]. These two patches allow mmap_rnd_bits_max to be changed during > > init, and bumps up the maximum randomness if we end up setting up > > 4/5-level paging at boot. > > Sorry for missing this, I'm just poking through old stuff in patchwork. As > far as I can tell this is still relevant, the discussions are just on the > mmap() bits (but we'd already screwed that one up and have since fixed it). > > So > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > in case someone else wants to take it, but I'm OK taking that MM patch with > Kees' review. Yes, thanks! Please do. I already +1ed it: https://lore.kernel.org/all/202309291454.436E19663@keescook -Kees -- Kees Cook