From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E372AC10F05 for ; Wed, 6 Dec 2023 15:59:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6463F6B007E; Wed, 6 Dec 2023 10:59:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F68A6B0080; Wed, 6 Dec 2023 10:59:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5156B0082; Wed, 6 Dec 2023 10:59:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3CE9A6B007E for ; Wed, 6 Dec 2023 10:59:20 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 04017A0165 for ; Wed, 6 Dec 2023 15:59:19 +0000 (UTC) X-FDA: 81536852880.16.35B7F5C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 38541C0022 for ; Wed, 6 Dec 2023 15:59:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0O5bufUD; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701878357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WYw3vagUF6XDu3VU/2nmvddUpyOWxVWix8zrdlIpfAo=; b=7vDYtm7ei0PGkdF/4oIgNkRiy5CTFgMMR7OZ51ASUEZEegyyn8YzifHLsC9U84T4vmviKT OyQaHJgJl02q83XMzHAqeEHEqypR0J/cuqtnTOKXefZFJXw2KkA57VaOHxeB31Rrcdqr1K vRYK0f8HG5SdktRuIm4k0P/x0EO9td0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0O5bufUD; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701878357; a=rsa-sha256; cv=none; b=aAzTa4VyKhZuY9qlI4AtRpSnkx7utLdHKSW+QOVSoOLaC2TydfalXRiY+wVKgfBWjMNJqd F9KbkP7IF68ZbACNKXvgEZa84qlQ7DEWiJ8ZCwlGxdrmjjOcHWp83WSLIzXkOwR887qVfv 8GQc/JOFGqV0IZle2YcNB0p77/j+pHc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3D0ECB8218F; Wed, 6 Dec 2023 15:59:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B370AC433CC; Wed, 6 Dec 2023 15:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701878354; bh=vpZXpKKJhkH6bdcDcPHqena5ZG4UsjJfgD/hPx3L2wQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0O5bufUDnm1ei+vk3IbzWI0+SGmHFkjtd6P/tbLUa0VD2zyoLUc9ML6LLfMDUXl5C yRdObtb5p8LZmfnfyRicLGcpZ8FCC68mIA1KatDT2DvCTEeb1KBjR+kCNwXLN/furT 8J2CnqhbUUGYxwraCtuy+GBB+DipyZMAyamjRRB0= Date: Wed, 6 Dec 2023 07:59:13 -0800 From: Andrew Morton To: Greg KH Cc: Pasha Tatashin , Sourav Panda , corbet@lwn.net, rafael@kernel.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information Message-Id: <20231206075913.fa2633991bf257f5ffe5f3f8@linux-foundation.org> In-Reply-To: <2023120645-survey-puppet-4ae0@gregkh> References: <20231205223118.3575485-1-souravpanda@google.com> <2023120648-droplet-slit-0e31@gregkh> <2023120645-survey-puppet-4ae0@gregkh> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 38541C0022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 994d9m7cwdbj3rzntwjbbmd6tycfkyd4 X-HE-Tag: 1701878356-520839 X-HE-Meta: U2FsdGVkX19b9CvYnPgyejmwWIL5ElKJ1GBISOz2j/z7iFut0j7hoVAtclht3mkMQPkzenpZgeDmO/RpA2RxsVN3JpgvtfM4qFwOinULZhJEwUgZT8AUAnWsW7mCpY2jrtyHUm0pHZcvVVdpoV5WjDXF7lvRyCrwMEOhfs26tNq3bTq6Kym39fjdOWB/YZ/8USo0DDWjb41NbtSwFELfYjt0Dd41zpaSgD8B5Vrz8njJja/i4Uf9+qd0ZzMqcAAfE1r9uVfVIhs+5AjnAmKAIZjOLZ8vtMZwlCun0e2ThZRcQ38yHIxHAQt09ygbTDjC75+Hf0utrAYKHNie9RNlw4K+POO0CS3Y+nXeJcQiu8YOAQHSJbrNKIEZyGpIFXuxntb51dT0vhjvrSLSDcW6Kb/YMeXKdO3QY27nbuX8YlZa6wF6k9HC861caBMhrTLuc5P9vAhPm3AoAMHsHZZ7IN26UPDlv8wteeMvk3HXD5ExH5TzOl8beFet5TtznLJKXT4bTQsS54hD7J+5I7VXIkcbvsRJ60L/2l7Rh8cNdRneClaiyMseEifJRY86uXYHN1z/VFz8se8GJ2jKiVLCOdNpKwL7kEcEw6KcfnHtP0NkFah8Ocp/k6f0Poa0RGfSE/Jv7l1u43veuQCHc7wb6Q+WhSP90mcE/ijgd4ojz7fxlfExncg930ATIiSgxJos+EudnbZAGjLhvUcTM98LGnuWRcpJS/cWUKFwj+iQ6xK17E0iuKeNPQ4zJZYZdMqLnSAlVrkgiJ5u3hRM525PVWbgtLU7WPIfOtiUJxQte4YtW+8zZPwbeLGxogYowRLRf/i4sJqmGagWJaIjrqZsRJyaSY4B9iRxi2GqGIheH23j8tHTPWXcslKGFQ16ppy+JjJm2B1dnvwCyuMoO+/p6JtgFHq2/JPtbMLCtLD8n7U2ZxGPUr8SH9hpy4L89o4JipdKjUhnxxi3TEQkitJ y2S8Z2cj WCs8c9y1oa9O6cWWkgO3dMGwuLLLryf7LajW/mCN5hCbwe8HqurSqFk65IqDawgc3Rnj4cw87FiT9szv5kHALoZuV5kOQxXooJWqxF6evv79842PGvouyK4iZYNO4Kiq0d4ThEhV5zOHHDi8jzWv9dDQm2PxkItQLoXLCSpFultik/ERLUEKh3njCYW86XJBhPP2Zp/Qu+FqJ4QTLLMmwxtnTHP93tBAfcQPMi3TcoZrG55efvYrKqFiqiYTtIBiZBe8Hl9NSEk6Razj6HkSUfR/B5pQZjIa/ZNVYo8aTiBwEkycVuZU0IO8L/KKbl8WpBmvK8+0iXU8UB6Y2uKoTr/du8UoP8cxnqMRZJXU34dP1Oqo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Dec 2023 12:12:10 +0900 Greg KH wrote: > On Tue, Dec 05, 2023 at 09:57:36PM -0500, Pasha Tatashin wrote: > > Hi Greg, > > > > Sourav removed the new field from sys/device../nodeN/meminfo as you > > requested; however, in nodeN/vmstat fields still get appended, as > > there is code that displays every item in zone_stat_item, > > node_stat_item without option to opt-out. I mentioned it to you at > > LPC. > > Sorry, I thought that was a proc file, not a sysfs file. Don't grow > that file please, it should not be that way and adding to it will just > cause others to also want to add to it and we end up with the whole proc > file mess... > > > In my IOMMU [1] series, there are also fields that are added to > > node_stat_item that as result are appended to nodeN/vmstat. > > I missed that, that too shouldn't be done please. > > Again, sysfs is "one value per file" for a reason, don't abuse the fact > that we missed this abuse of the rules for that file by adding more > things to it. I'm afraid that horse has bolted. hp2:/usr/src/25> wc /sys/devices/system/node/node0/vmstat 61 122 1309 /sys/devices/system/node/node0/vmstat We're never going to unpick this into 61 separate files so adding new files at this stage is pointless.