From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B16C07E97 for ; Tue, 5 Dec 2023 14:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D33766B009B; Tue, 5 Dec 2023 09:16:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3276B009C; Tue, 5 Dec 2023 09:16:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAAF46B009D; Tue, 5 Dec 2023 09:16:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A8AF66B009B for ; Tue, 5 Dec 2023 09:16:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79B6716016E for ; Tue, 5 Dec 2023 14:16:00 +0000 (UTC) X-FDA: 81532963680.20.3279500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf16.hostedemail.com (Postfix) with ESMTP id 2C730180012 for ; Tue, 5 Dec 2023 14:15:57 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gFDa+OLe; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701785758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/4rFwi8S3mnYo9BWDKfMU5EhJsojMzEkn382bzqckKM=; b=nVspGY3+4ASKj4RscOanlV0cLg3aKkl0MfKWsdJcHuSeRmJrLwwjnsxsxlITkzmp0q1rhq dKwI8VCJPtvoqZfJGe8/gIBEJWLogqlxR2kmzU4pfctZSbjnrg7ZXRrqOKH54tJCKUysG7 uFOy1y4GLs3lgLdqOmEVm2ksHOiWUs8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701785758; a=rsa-sha256; cv=none; b=pRX4SW9KaIBJAok1X9kU0+91exTACRl5qLZS4rFa0YWqIPTFtRI4hR5f43C6YsK1ZrKxZU NT/voAQfLj0g4eqkq2kxNBk4cCFIYXVuNe8r76l8BAWJLEZFL6XEWIM1E3+Qlx9OwMExKO S29bVYVtOkFW26tkcHYW6FIeAw9Lg8Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gFDa+OLe; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701785758; x=1733321758; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HUtN95CBxY73WyhOnT1Lez/ETMiAOg2Qz+hvrK4nEdc=; b=gFDa+OLeuPj/kN1orFWDAyfK++NJQtFfY8rgfpQxfhTmQvEvvaJ3y7U3 75Um9L1U19Xz/Tg6zRCK+i1gBLXhc9mogQCFR0ndTPudh06pzvqlIzohc pWbwhNzodXMHEIUwtDs96kL7BU6iDZ8Ti4kmo4EcWaPaK8ZY4g7VOm7Xh VsDjwD5FEFRL1elzmsr75e2zj3ApFPRj1/qWTKydVJTmeT9hunrhvl+As 4pVCOrew+kMiW2vHA9DHU3uf0AjYAsgIGkv06LZC9Eek1m3czpMM3vnb4 cKl/d92t8rvnUQMgXfqoBIseEqFouQBgBU1Gaj8aIT9xr4O8zXr7pIRZS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="378924952" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="378924952" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 06:15:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="799984120" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="799984120" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga008.jf.intel.com with ESMTP; 05 Dec 2023 06:15:19 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rAWCi-000994-33; Tue, 05 Dec 2023 14:15:16 +0000 Date: Tue, 5 Dec 2023 22:14:51 +0800 From: kernel test robot To: Sourabh Jain , linuxppc-dev@ozlabs.org Cc: oe-kbuild-all@lists.linux.dev, David Hildenbrand , Dave Hansen , Mimi Zohar , Eric DeVolder , Boris Ostrovsky , Valentin Schneider , Baoquan He , x86@kernel.org, Laurent Dufour , Dave Young , Vivek Goyal , Borislav Petkov , Thomas Gleixner , Hari Bathini , Oscar Salvador , Greg Kroah-Hartman , kexec@lists.infradead.org, Mahesh Salgaonkar , Sourabh Jain , Akhil Raj , Andrew Morton , Linux Memory Management List Subject: Re: [PATCH v13 5/6] powerpc: add crash CPU hotplug support Message-ID: <202312052234.Oinhx3bT-lkp@intel.com> References: <20231204053253.25305-6-sourabhjain@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204053253.25305-6-sourabhjain@linux.ibm.com> X-Rspamd-Queue-Id: 2C730180012 X-Rspam-User: X-Stat-Signature: 3ogetmtz5pueczqbt9o9z33zweyj6ien X-Rspamd-Server: rspam03 X-HE-Tag: 1701785757-512235 X-HE-Meta: U2FsdGVkX19ky7jDA4SiUYwuZKk3BV8jQKuMPOD4AW0pxtx/oMAqSQ30l8aE8+zVhu8ADpzbk6zlAfI1yl61XELr3AeVhygWRN0erq9/0BfeP9GiFy1x5nkjC0E8Ws7mE0S/A7VU4fXadB2tzzukWZF/LxrkeL/QmA8zQ/Z8fXuXAI01wxX+zkcZwLluDJjrRWf4tdKQp1Cv9QtvNrQaJA8F8YPIUXOfyLaA8LSc9RKsFC5NmSD8167coPNjw5MB040BTRJIQQo1gXCtZvwCOvkbnJAoSF44JQTP74obU6rzqtzQ36BDLVztsWuyNEcFsLr1ATAFZVlLqC5ck57Eu3FF27IqweyjT7FA6kTloRMBeKsc/1y0niJjFLdeAd2ERu8mto128Gxq2JULpP50LXnk2i3Z7hBBY/sGUTUZfrFRNGXR9TZZ5cFgri8Fzw/L0lHzNGf5JIb6kFnWZhqacR4GartVAJOC3tDlWD6ro/m19GsFmueCzUHHHex/7AjOKsIk5pO+kaCs0ZYqzmTpyOKYk1lqBhfDITx7ZzUx94U01FuQykTTa22Z2v0egOJkw2b7V+AN2e6CbhbgJcwvocz4Y3SX1efclZEisSqCOKaYAsZbNAFTCDCI4NuDMp1i4p5sNg+gZehGyvkGD4TmHQEW21/Oh62JALCz6VpbKFcKDz7EhI2TFGOO/kcEe+OQKLoKcZ4X6xgOGPcUJ0G2Nd1vYsuQBleaahQnmlVqqIROoLyo2/DoCI3z244lbxY+NkKOy/q2fsGkflVJhNsCtlrv63cvGKoejRPHVaB9PHXv9DYao5LxMJiChUlCjtHZHXAKQCeYe6Eduud7ZU3+QkQs23/sraXY8oFjZ3bzuQr5u/+NEw8eTR1dESIqKt9fEFn2w2phkTiEm916dZf1sQw9WRlqUO7oprR3Ic+/ekdiJemMV7+95fgxIYne/bf3O2kfzTM7szkZywo0yAj wfjOWOai Er7S1r0NHycH8qoOdZvt/blcVWUW8anYyMV3OIe7Z5L4xDbvF/Dpoua3X42RDPgb880jLsEH9R7UMjhq3rePR7OY6ZZtHJllG5u8chznWqW0c9O79iz98HoRsKJH3fL5I5yAO2nrwNVOpBuvRRBqNh8OvyPoyaJGFjZV9g827Itqhis1MV3hXJ5gkpp4Kv9ty4fQq9HY/MbFDe7f8aoldzC4lC8Yc913esIX2+7jFDuubgtuvOkS/fcTxcaF2sZ5jZNXjORNYcilbZGpm5j3cQaHX89Edw10rPu0EzDsKoJxtsT7j/pJXtO2pQomBsK6hVUfZHfYuhqe8Pgjgnh172msYapr7CbdFo/EfqQQ7U4B+tFD1cb4ybjn3n5lSIg7tc/pKN9ZKlytoc/MNhiXaeWpWq5J9Ckw9fzrlWIxfWF9U0DJCORUd618CdoySpTvlAS12soo/6uI2wHa1wus1n3k4dA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Sourabh, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes tip/x86/core akpm-mm/mm-everything linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sourabh-Jain/crash-make-CPU-and-Memory-hotplug-support-reporting-flexible/20231204-143305 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next patch link: https://lore.kernel.org/r/20231204053253.25305-6-sourabhjain%40linux.ibm.com patch subject: [PATCH v13 5/6] powerpc: add crash CPU hotplug support config: powerpc64-randconfig-001-20231205 (https://download.01.org/0day-ci/archive/20231205/202312052234.Oinhx3bT-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312052234.Oinhx3bT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312052234.Oinhx3bT-lkp@intel.com/ All errors (new ones prefixed by >>): arch/powerpc/kexec/file_load_64.c: In function 'kexec_extra_fdt_size_ppc64': >> arch/powerpc/kexec/file_load_64.c:953:52: error: 'threads_per_core' undeclared (first use in this function) 953 | possible_cpu_nodes = num_possible_cpus() / threads_per_core; | ^~~~~~~~~~~~~~~~ arch/powerpc/kexec/file_load_64.c:953:52: note: each undeclared identifier is reported only once for each function it appears in vim +/threads_per_core +953 arch/powerpc/kexec/file_load_64.c 915 916 // Budget some space for the password blob. There's already extra space 917 // for the key name 918 if (plpks_is_available()) 919 extra_size += (unsigned int)plpks_get_passwordlen(); 920 921 if (image->type != KEXEC_TYPE_CRASH) 922 return extra_size; 923 924 /* 925 * For kdump kernel, account for linux,usable-memory and 926 * linux,drconf-usable-memory properties. Get an approximate on the 927 * number of usable memory entries and use for FDT size estimation. 928 */ 929 if (drmem_lmb_size()) { 930 usm_entries = ((memory_hotplug_max() / drmem_lmb_size()) + 931 (2 * (resource_size(&crashk_res) / drmem_lmb_size()))); 932 extra_size += (unsigned int)(usm_entries * sizeof(u64)); 933 } 934 935 /* 936 * Get the number of CPU nodes in the current DT. This allows to 937 * reserve places for CPU nodes added since the boot time. 938 */ 939 cpu_nodes = 0; 940 for_each_node_by_type(dn, "cpu") { 941 cpu_nodes++; 942 } 943 944 if (cpu_nodes > boot_cpu_node_count) 945 extra_size += (cpu_nodes - boot_cpu_node_count) * cpu_node_size(); 946 947 #ifdef CONFIG_CRASH_HOTPLUG 948 /* 949 * Make sure enough space is reserved to accommodate possible CPU nodes 950 * in the crash FDT. This allows packing possible CPU nodes which are 951 * not yet present in the system without regenerating the entire FDT. 952 */ > 953 possible_cpu_nodes = num_possible_cpus() / threads_per_core; 954 if (image->type == KEXEC_TYPE_CRASH && possible_cpu_nodes > cpu_nodes) 955 extra_size += (possible_cpu_nodes - cpu_nodes) * cpu_node_size(); 956 #endif 957 958 return extra_size; 959 } 960 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki