Re: [PATCH v13 5/6] powerpc: add crash CPU hotplug support

Re: [PATCH v13 5/6] powerpc: add crash CPU hotplug support

[kernel test robot]

Hi Sourabh,

kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/x86/core akpm-mm/mm-everything linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sourabh-Jain/crash-make-CPU-and-Memory-hotplug-support-reporting-flexible/20231204-143305
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20231204053253.25305-6-sourabhjain%40linux.ibm.com
patch subject: [PATCH v13 5/6] powerpc: add crash CPU hotplug support
config: powerpc64-randconfig-001-20231205 (https://download.01.org/0day-ci/archive/20231205/202312052234.Oinhx3bT-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312052234.Oinhx3bT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312052234.Oinhx3bT-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/powerpc/kexec/file_load_64.c: In function 'kexec_extra_fdt_size_ppc64':
>> arch/powerpc/kexec/file_load_64.c:953:52: error: 'threads_per_core' undeclared (first use in this function)
     953 |         possible_cpu_nodes = num_possible_cpus() / threads_per_core;
         |                                                    ^~~~~~~~~~~~~~~~
   arch/powerpc/kexec/file_load_64.c:953:52: note: each undeclared identifier is reported only once for each function it appears in


vim +/threads_per_core +953 arch/powerpc/kexec/file_load_64.c

   915	
   916		// Budget some space for the password blob. There's already extra space
   917		// for the key name
   918		if (plpks_is_available())
   919			extra_size += (unsigned int)plpks_get_passwordlen();
   920	
   921		if (image->type != KEXEC_TYPE_CRASH)
   922			return extra_size;
   923	
   924		/*
   925		 * For kdump kernel, account for linux,usable-memory and
   926		 * linux,drconf-usable-memory properties. Get an approximate on the
   927		 * number of usable memory entries and use for FDT size estimation.
   928		 */
   929		if (drmem_lmb_size()) {
   930			usm_entries = ((memory_hotplug_max() / drmem_lmb_size()) +
   931				       (2 * (resource_size(&crashk_res) / drmem_lmb_size())));
   932			extra_size += (unsigned int)(usm_entries * sizeof(u64));
   933		}
   934	
   935		/*
   936		 * Get the number of CPU nodes in the current DT. This allows to
   937		 * reserve places for CPU nodes added since the boot time.
   938		 */
   939		cpu_nodes = 0;
   940		for_each_node_by_type(dn, "cpu") {
   941			cpu_nodes++;
   942		}
   943	
   944		if (cpu_nodes > boot_cpu_node_count)
   945			extra_size += (cpu_nodes - boot_cpu_node_count) * cpu_node_size();
   946	
   947	#ifdef CONFIG_CRASH_HOTPLUG
   948		/*
   949		 * Make sure enough space is reserved to accommodate possible CPU nodes
   950		 * in the crash FDT. This allows packing possible CPU nodes which are
   951		 * not yet present in the system without regenerating the entire FDT.
   952		 */
 > 953		possible_cpu_nodes = num_possible_cpus() / threads_per_core;
   954		if (image->type == KEXEC_TYPE_CRASH && possible_cpu_nodes > cpu_nodes)
   955			extra_size += (possible_cpu_nodes - cpu_nodes) * cpu_node_size();
   956	#endif
   957	
   958		return extra_size;
   959	}
   960	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki