From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82838C4167B for ; Tue, 5 Dec 2023 14:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2CE46B0074; Tue, 5 Dec 2023 09:58:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDCE16B008C; Tue, 5 Dec 2023 09:58:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCB636B0092; Tue, 5 Dec 2023 09:58:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D055A6B0074 for ; Tue, 5 Dec 2023 09:58:42 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 98C56A0979 for ; Tue, 5 Dec 2023 14:58:42 +0000 (UTC) X-FDA: 81533071284.15.00BE574 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 60558180025 for ; Tue, 5 Dec 2023 14:58:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701788320; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9BO3eFq3VWLsXedHVW5kCgVff2FH2YHGDeIG9clXD3I=; b=TY+uRQ/cocpW10gMngqt22+TgTN/ryohQdZZG1sa6Lp14kSWxqqrWqacwActHssmY3PvSX 3Uvfx0UMbBWE+w1Fi6jvW9P5U+xJlYIC7v/CMzqU7A5mmRMj2HevUdXPZeL9MUeaYskhXn 07V4xkMrx3x4E7c8BFNvFEH3ARtaHJk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701788320; a=rsa-sha256; cv=none; b=tEHEFsf98C4m6GIjbIwVmz9jgah2xJs0sgY1zFKChZHa0x7m4i9Jsq4xHu9buTjTukGeoe SheFBAghdGc3k4HKm2cOLZW/5R0X1KS3uQ4MeofvOIpaVsFLQCVkhS+mRqcQHcTu7C8ahQ RVtaakE0Ehp6h4gLWd5subLfzS8oJxE= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7AE9022067; Tue, 5 Dec 2023 14:58:38 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A0D0138FF; Tue, 5 Dec 2023 14:58:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id /ytAC506b2UEEgAAn2gu4w (envelope-from ); Tue, 05 Dec 2023 14:58:37 +0000 Date: Tue, 5 Dec 2023 15:58:34 +0100 From: Petr Vorel To: Cyril Hrubis Cc: Stefan Roesch , linux-mm@kvack.org, kernel-team@fb.com, oliver.sang@intel.com, ltp@lists.linux.it, david@redhat.com Subject: Re: [LTP] [PATCH v3 2/2] add ksm test for smart-scan feature Message-ID: <20231205145834.GA96988@pevik> Reply-To: Petr Vorel References: <20231204184817.3570465-1-shr@devkernel.io> <20231204184817.3570465-3-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: myotrsgekcwz3g1a41k5dsu1g9j6ps53 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 60558180025 X-HE-Tag: 1701788320-206859 X-HE-Meta: U2FsdGVkX1/3lSfLfWISQPFAYfySs984FF5WEo7yIGvbYgEJ54O9kLS3huIQhOlcSlPkrCd06tOSZFlsGqHDUe/6iTuZO8HnBywug4Vbi/gMypfh8HvuDROP1exaxkjRg3h5I2mUjCKiIV63kMDTDoQg1uZmaAB1sFCnyfib6qjO6OeRxm/9VFIJYd1VWEKgXGboZW0RoaPHLTGyCFRw/J96VnrKCLBKcgiBchzValkqP8oPr1qGgswdIFM7bqLaIxiExEDsi6t5gl138USnCb4ZNHydUL7vRRRXngUkkzzeub1cPi6/kirRX6Ia4O6erQ83YcLqBq/mwGzzJFsHm5pPg/5YwVEfeQV/VrxIiSFIKrXQXP6Y86w9OK/BTIyfXUzq/HjCkksedazjcwQws8yO6aVo31qJEDHstb9mfv4r3mdYq6PPDOjXgKO7tHTFGbbB/IA3/G53gpBcurgh9Ptor9bcsCbtFJM1GwJiv6Ticfa6MbWaURm7Gu0iAKmw5qcfNPM08K1pgtrUkj9x4p0FQ6IoakqBV5sYDDOTu/HbPNLZaOiNGS8ZmuBohBW7L+JgvZ56YlXFA/26Seq0FPRfl4GdI3ZblBlohwsj6vym4hDRe/sKZzgkcAPsv1qU81z7X4X0CnhasVNDXpLfU3Z3+ukITxKhGNl3xVdceFtybiEfwkE0cfpw0FK5M/7iP2cuS/NWckpCQpsSTv9H9KBr9B+BERo3AanX5FNwiHBvtiMXRq6jtHOCf3ncxqcYMBny8rrDB8qXTHfmrj2kpSsSzGizkQs8LXtCZp/DSFRRkZj9MXRqI00tEq68AzPSe2jYxalWqIf0ekJ1Hzg49ntVETSpis/VW9oDdGfjG5l3ubgv3It+ou0vsrSaBJM/7Kh3Q8egnX3HNFfJgoNo3PoX75XcOCzo3tCz6MSUq2HXsm9LADBnmXaUIoaakDOU48YND8VScEugRuwToTl 4WVeB8dc mA2CWD41W2Iqe4LNBhSbB99L8tIUwJs2kyYf4qEmIjE1bCQRpFAph4WxWTrkpwc+dfNB0T0iaxnbHN4TSkave9hfYiN/q0phTdyypTZZcsk3rXL3rcg9fCtqFge4/2TNLFuucOTzfcI6qsUlKyBfy7isXpbmu0jhcBjYyrOX87ZBfMbiPeHea2O9DOMD0KFJA9/o7fnoV9p0BCds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.218999, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all, ... > > + > > + while (waitpid(-1, &status, 0) > 0) > > + if (WEXITSTATUS(status) != 0) > > + tst_res(TFAIL, "child exit status is %d", > > + WEXITSTATUS(status)); > Does the test fork a child? I do not see any place in the code that > would do so, did I miss something? Ah, I also pointed out this is useless, but forget to point out that .forks_child = 1 should be also removed. Kind regards, Petr