From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Stefan Roesch <shr@devkernel.io>,
linux-mm@kvack.org, kernel-team@fb.com, oliver.sang@intel.com,
ltp@lists.linux.it, david@redhat.com
Subject: Re: [LTP] [PATCH v3 2/2] add ksm test for smart-scan feature
Date: Tue, 5 Dec 2023 15:58:34 +0100 [thread overview]
Message-ID: <20231205145834.GA96988@pevik> (raw)
In-Reply-To: <ZW8DVo6UfSofc9WP@yuki>
Hi all,
...
> > +
> > + while (waitpid(-1, &status, 0) > 0)
> > + if (WEXITSTATUS(status) != 0)
> > + tst_res(TFAIL, "child exit status is %d",
> > + WEXITSTATUS(status));
> Does the test fork a child? I do not see any place in the code that
> would do so, did I miss something?
Ah, I also pointed out this is useless, but forget to point out that
.forks_child = 1 should be also removed.
Kind regards,
Petr
next prev parent reply other threads:[~2023-12-05 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:48 [PATCH v3 0/2] KSM: support " Stefan Roesch
2023-12-04 18:48 ` [PATCH v3 1/2] mem: disable KSM smart scan for ksm tests Stefan Roesch
2023-12-05 11:32 ` Petr Vorel
2023-12-04 18:48 ` [PATCH v3 2/2] add ksm test for smart-scan feature Stefan Roesch
2023-12-05 11:02 ` [LTP] " Cyril Hrubis
2023-12-05 14:58 ` Petr Vorel [this message]
2023-12-05 13:16 ` Petr Vorel
2023-12-05 18:01 ` Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205145834.GA96988@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=david@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=ltp@lists.linux.it \
--cc=oliver.sang@intel.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox