From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9ADCC4167B for ; Mon, 4 Dec 2023 23:59:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5AF6B0083; Mon, 4 Dec 2023 18:59:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A5196B0088; Mon, 4 Dec 2023 18:59:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26CFE6B008A; Mon, 4 Dec 2023 18:59:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 150496B0083 for ; Mon, 4 Dec 2023 18:59:01 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DED991C07DB for ; Mon, 4 Dec 2023 23:59:00 +0000 (UTC) X-FDA: 81530804040.11.98FC1B1 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf29.hostedemail.com (Postfix) with ESMTP id 3A24F120018 for ; Mon, 4 Dec 2023 23:58:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=b3I+vpay; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of 3wmduZQgKCH0tiblffmchpphmf.dpnmjovy-nnlwbdl.psh@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3wmduZQgKCH0tiblffmchpphmf.dpnmjovy-nnlwbdl.psh@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701734339; a=rsa-sha256; cv=none; b=O2VBIcGDeGIr9GXHFw7pfMoMdaf+fEhHJzCWlYOKNgkYhELRXEw9nhGOhmgYHA1J989Y8K R+adLdnsFGg6IGNEJxTURdwpPkIcgnq9Gg5B2YEtB8KSIehMpbhXMpzTcqJWYRjoklTkdW ZPAlyCQhrPUUpTlX0bEn4/YIoT5m1DU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=b3I+vpay; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of 3wmduZQgKCH0tiblffmchpphmf.dpnmjovy-nnlwbdl.psh@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3wmduZQgKCH0tiblffmchpphmf.dpnmjovy-nnlwbdl.psh@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701734339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bc3wWZdTIWXynHMDoBBnLgT0pYzNdNHfaXI4uKulM+I=; b=sKvZVPbKZKyasIggD6ABY1649JhBrfKjHae2GxvnH45ghoz8xjV+zse3uPDw0oceyXpBXN 3yiXsH77uB7IkWedQM/36fkwJNwXXRCVc3Q5BVrmjxuF/pWzHail9PRtMBuFaqRLMpS4zS X4oI/cynjNWhAacWZcV6l7fIV3O0xCk= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-db54a19c7d6so3751691276.3 for ; Mon, 04 Dec 2023 15:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701734338; x=1702339138; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bc3wWZdTIWXynHMDoBBnLgT0pYzNdNHfaXI4uKulM+I=; b=b3I+vpayGf7LnU6IKYoQPGCfrBfsRfD2GOnDvp0mqMAQZdg9hrRmWuC2LvvG8BfBhO osHGxsXhWbSA/P4ZVePFkUJyJUl+t9If/xIKz6oz85remjCfnLitZntgmvzUjruuQunN V2RDZVwBH9Ghu2mSh1zq90qDjyHDKgQOrHuCTrgS+AKMK/BOJ5HNBdx1Qp6ZAfqX5dzS c76PNJqm2wgNEaKpkKG+d9YHPmis8hL/CsxVy/lxpiWfVhBgq02Ympgobc67GTneOLL+ wiJIBzrJgfgkKUbBRpm+QuInqz4d0r4Xl3fyd5dCMTFPn71lFe1bNr0D2D9haHMo0q5F 0vBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701734338; x=1702339138; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bc3wWZdTIWXynHMDoBBnLgT0pYzNdNHfaXI4uKulM+I=; b=pAGP8QfEYys8+7kbxEcKzXtLQbj9oReRNsl7sUjWdcZsPawh+Zy3jCno3SLJpzO1yr IQikrHdMOV15uEH3jB1Cae0fLsTsNCTRE7TmKbCgxCkiCvPUTio5Ufj1x3UfklqkUuf5 s4fmtRlwiOaY25nY1O+WfIxOhFwBvxpaeKprdrdQ7gXSrh8cX4blMj0NOnelxRkwLcZD CVQr8nnUPFl6Q1UHMQoSvGSu0Gvm1eyAwc4JuBhOnYSHP8eRwN8+tjeI9FDBO61pineA PMe+KNATIi/3+ELjLPGjhEFVVez7BSlEnVGFqWtN1cONNV9U9GcprofKDfDKTfkyFD79 gAhA== X-Gm-Message-State: AOJu0Yyr5HWTXPX/Dg1qc31llEmBxNwGm33wIK4UQsJ8CCn/wO+vY0+y Pfa9QVYRvh1uiJhVTygnCcXJANCHADmwDw== X-Google-Smtp-Source: AGHT+IFDrcTevAMTdK5aY6ZCZm5tMFx5J7z5a1aKvWzleHwEj72AE5vypmyjwIltbbArECOAHx0hRe9bNnWWtw== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a25:cf51:0:b0:db7:dce9:76d6 with SMTP id f78-20020a25cf51000000b00db7dce976d6mr189881ybg.2.1701734338283; Mon, 04 Dec 2023 15:58:58 -0800 (PST) Date: Mon, 4 Dec 2023 23:58:56 +0000 In-Reply-To: Mime-Version: 1.0 References: <20231129032154.3710765-1-yosryahmed@google.com> <20231129032154.3710765-6-yosryahmed@google.com> <20231202083129.3pmds2cddy765szr@google.com> Message-ID: <20231204235856.k4izppfsrpg2rng7@google.com> Subject: Re: [mm-unstable v4 5/5] mm: memcg: restore subtree stats flushing From: Shakeel Butt To: Yosry Ahmed Cc: Wei Xu , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , "Michal =?utf-8?Q?Koutn=C3=BD?=" , Waiman Long , kernel-team@cloudflare.com, Greg Thelen , Domenico Cerasuolo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3A24F120018 X-Stat-Signature: o693qf5bqiyweicpzdf7xqfojze7f598 X-HE-Tag: 1701734339-409751 X-HE-Meta: U2FsdGVkX19LPzY0WSEdCqrt55SK3SU09/ZtDR3JpS9YGP0U/dZMcvEX0mnjPYNrcpPEifndrCCW1P9qK5Aoz1HmbNvaXwh+pD1TNjSRXwRrNh57+ULh7fSTFnnGIaoWt/FV+cNveZ0v50vJinCofh+muXxTfSJQAOMU5VpxQEDjN35rSQNiShW05XOZLHvvBpM9KvzTxfpSCAwRAkJ0T5xCsPqAvxWMAFmAWzc9WFp5jan0PpLt8i3irGG9Wn1x832Ude3sVcoX3833GnHSaZ9qV71bk/yVw8fyDV1lAbpGaGNFN8wNfs+A0hBjKNCq0xqsym0myegsG8VbwScbyWm1ZRCIK2xqWJJMICQni0cGLic1sSLKd2soxTdo5LkbtRVXtGoRlq6SuTjrOaPp2b73/A2M6vfY6iVwRhuc2trlQYVWDTuF+VLkx8ek8GV8DvraNNbcf3BbfEesiP8oXUZ4OEOeQ7u7ldqOXx36p/e/aCKL2YRo1UXL1oJQLk2pP+U/5HE4VVzE3i9vEl7H71bt/7Hqbd7qa3rI81zfojp2jPYh4TKfa1g+SVuQ+RfUHjFfE66ggnt795WSmrziaQAr43Mpd132Q1lMKZ/7Cr55YtbcWen835X/Rrv3zTGi5FpyWSNhTEaqDBz1i8VxtQWzJp2Fxh+0nErntS6fK9TWlhCLyoxNCGl8iM5U5bZ7/6QOK2lxVRn8VdfKqn4RLaoEP5Co2PJGJKr4O0z+BYcyxZVf5Zs5/E1qLt9QMwVaoe7NBy30evyDr2BMOZeznEVZITeP+2Hq1NlUqM9ssFSKzE+xYypbBJs4p/0PtpZN7aw1qS69q+R8Qfvw/LBhOXcsN5frWR3aiu+XfJAgNDnDf63Elfy6iNufvuh6NZA7R7AfJB3FlolHQTKLOi5Qk9EeWO+bhtuYaDb1oYIAwm2m91Qm5YEG8NnTUmkoaLHWXL+8ADCIQ0nE02bo/CC pr8tIezM N/aJuGDfQuY7HQqQegr6oBLAQ45PuOTlZlXSgT5/1Zd7PwiaN4bNBBH++mQHRg5s2vzIDYTFaG+Eid+3tCeWWp/fF+qAtWYhSfrNrF01Gn8CMDJsgEs1+y0f+gqlRdSamsgd3vXpXq2rPVnDRE6VwWUecJlSMhrWa51IcTaDoltYo+x3CPHnAG6fZ2Tl2amutgvqS70Ff/CPkS5jWoz4VYrSV/+yU9fJrapBXWstb7Vo8qTgDDIGyFeKWXpN+aBmPd8EI2ZLFOVf9MH+wFJ3F4huNS8xZm+zCYmimT1MPh0uMJRrMTkX/DDPMxgQvIh6DYAjzDiXS4mu4giesbVeuy8VD98Li8gJoTDWYIjtu71RYGDcaV7eZWYu+e0xmlaJy5KNXiynr9jpJIjI98bE/FJI4ONcgdGqr37hhZdvHTouH0JBC9BVGkl0hVV02kt45xTtzC/dYH5+DmbyRupnAHtwkLBf/exMVb2a1W4ZRHYWiUZnPc0mIruvQNGVgJU9RAth7ccfOcQgd+r3UaThDw7t07QX5i/WNsfazUCmG03jEgYLc7+gfxc9TWyH73axVhO+8RGptg2EiSJFegbEOv+dKNiQbOW5L/+KzYqQChkspnfwvV0XG6gRYBACNHTlPIYxyJR/KFsl5YkNsfUTk4wtXOEvEYPTRBIA0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009379, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 04, 2023 at 03:49:01PM -0800, Yosry Ahmed wrote: [...] > > From 19af26e01f93cbf0806d75a234b78e48c1ce9d80 Mon Sep 17 00:00:00 2001 > From: Yosry Ahmed > Date: Mon, 4 Dec 2023 23:43:29 +0000 > Subject: [PATCH] mm: memcg: remove stats flushing mutex > > The mutex was intended to make the waiters sleep instead of spin, and > such that we can check the update thresholds again after acquiring the > mutex. However, the mutex has a risk of priority inversion, especially > since the underlying rstat lock can de dropped while the mutex is held. > > Synthetic testing with high concurrency of flushers shows no > regressions without the mutex, so remove it. > > Suggested-by: Shakeel Butt > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt