From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0D0C4167B for ; Tue, 5 Dec 2023 00:01:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 186856B008A; Mon, 4 Dec 2023 19:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1369A6B008C; Mon, 4 Dec 2023 19:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F40326B0092; Mon, 4 Dec 2023 19:01:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E39016B008A for ; Mon, 4 Dec 2023 19:01:23 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC0A540407 for ; Tue, 5 Dec 2023 00:01:23 +0000 (UTC) X-FDA: 81530810046.16.E6D2435 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 532DF40039 for ; Tue, 5 Dec 2023 00:01:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dtmdbRsP; spf=pass (imf27.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701734481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OlbvQ38xyZhR1pva7q+q80Q02GqbyPEePCP4ft47vxs=; b=AuIOdJNdPuVYiV8ODRYDtJSjgWg3ON94clHCDagJymsGWuchiK0LqCTtPq1R47QuBQKCSn 8o7cmZz6GkhPAdvV/Blp9DMPR5loU52t5R28oJ27HcAis5wnU9I/hrFDzyP6qCGvOhZOsX fZq2IKc44JQJhu07id2DaLN2x0dEDfY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701734481; a=rsa-sha256; cv=none; b=SysKRURgjx/TFK0ojVCGvqbe9ACzXcxlbur4OsgFEg0Rrz+/AffwpdpdcqrwVuNBLPZSyw QcPoKyOSNbcIKteXp8wpSwAkaASVem0IIrziH04mh3FQhHuO8qnLcAx/xFmp9txcGZE1qw uGcgPmiizSlTPBDsOa9cZ5LLpdbiKLg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dtmdbRsP; spf=pass (imf27.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701734480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OlbvQ38xyZhR1pva7q+q80Q02GqbyPEePCP4ft47vxs=; b=dtmdbRsPMNfPc5xAmnNSx1WTcYYNzvTUCSBizUGL/5szfcX5wjv2eJDjGoh96ceXm5rXHG 26+3iwTwZjIV/jjj4f8Ra/A3nb0nMqPas2L8j+HsR4iRKgHZsTQJ9k8LVoSlkcrQk6Swcq 1WIZcg+nG5n3QOCHtvlIb/9oV+uIsBw= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-uFRQ4DMJP_mG7CGCfzdH5w-1; Mon, 04 Dec 2023 19:01:19 -0500 X-MC-Unique: uFRQ4DMJP_mG7CGCfzdH5w-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7b37a634935so341371139f.1 for ; Mon, 04 Dec 2023 16:01:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701734478; x=1702339278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OlbvQ38xyZhR1pva7q+q80Q02GqbyPEePCP4ft47vxs=; b=HsNen762EYbogwRLl729fsl5BCHc7+gf9eIBelqipYm3yFM52WsXYeGvIonbfYRJ3d PTxA0dcIh4E5WLayQM36jeHPYvnnSseoLxtYVDIo3H1cyzhdX2P8i1+4VicT5UA0oqg5 ilkISVF1aTnVMbJEv3/uOzqiJNcXGe9GZrpuMh/o48cng/nuJGSB0z3d+PRo2+XCDOdA SELAucVpy+JPb+45gK7Z+7TxgPc9Vos1VOk9rHozLEXwv8cZPixtOCmjeal+qd2BHOUX CWqRGpovVkiyNej6opYdZ+YmyJ9ng8lHzdFdtPhTI6uH9Os+osTs/zpUYY5Tk6G6ivD5 sSdA== X-Gm-Message-State: AOJu0YyHOoNAr/LCnZ9xdUIl66cqAzb9fp4jG7Kcj4R1cgDK4mIIq4sL E1plnEUEUEsAp2EhFthhUw/IB6XUPl5t62QsZ/tcujo5u9mV4FroB7b3868o0hQpeI/9lwKdR7Y jts5CO2UJWDo= X-Received: by 2002:a6b:c541:0:b0:7b4:5ac5:9f15 with SMTP id v62-20020a6bc541000000b007b45ac59f15mr395518iof.11.1701734478705; Mon, 04 Dec 2023 16:01:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQnBPyeFdxlh2Qtw8/h7pN3+b1wM0h4O+feXPktnwOGXI46QpvUpfZTg/d5w35S03RXV2UDA== X-Received: by 2002:a6b:c541:0:b0:7b4:5ac5:9f15 with SMTP id v62-20020a6bc541000000b007b45ac59f15mr395512iof.11.1701734478445; Mon, 04 Dec 2023 16:01:18 -0800 (PST) Received: from redhat.com ([38.15.60.12]) by smtp.gmail.com with ESMTPSA id 22-20020a5d9c56000000b007b35043225fsm3092323iof.32.2023.12.04.16.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 16:01:16 -0800 (PST) Date: Mon, 4 Dec 2023 17:00:52 -0700 From: Alex Williamson To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio: account iommu allocations Message-ID: <20231204170052.5967e9cd.alex.williamson@redhat.com> In-Reply-To: <20231130200900.2320829-1-pasha.tatashin@soleen.com> References: <20231130200900.2320829-1-pasha.tatashin@soleen.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 532DF40039 X-Rspam-User: X-Stat-Signature: twqt89eubusc1rh88u8fjui3r4r44wpt X-Rspamd-Server: rspam03 X-HE-Tag: 1701734481-597232 X-HE-Meta: U2FsdGVkX18Uu/S18kDibIyIjaeRlG/5SAf3SZuDWSItVxEs6Yl/m+h07e8535+6z4TvKyTa5ErqedO5yreg7/rElGvvfGRiY2OoJ6Qg0/DJjq7IpUt2Q9UU4xRetbFzhHaq41faDyv7vECzz7zWE27Zt9Nz29dOs/dJBsfqcEzHloUBhAJ5LuqzSCo+GfIPl4wi5A2R/6cm5/hlZMhjGCAcQyX659Qj5G2+IXg+POZaBiMUToCJE0f6U6NR6nEoJ2NVypwuYEuWP0yWpItDOreBWLCMDwnwVE3QNwCddeqvcr+YhqDA3dRkpnGfBkXIYXaqnJy1M0E2W1o40PfMrtYWEvbjHZuRSs9G1qQLXFeGrpHoqvXfkjph0I3k4r/1dIijFXfSKxVCaa3OV2kDJXWdQK7ar2FJYtDHHDbzVkg3xBYLVXBhPChyZACzoWLUeh79m52emb76zFIj4Bn6TsnjpSDKl/fDM4MMMV1Y4g5RC/DeMBJyW1xrElWrQgbz3i1yCUNZEbx/TAowwH9OnuMMgkQLh9Ds4WcvBy/DQmbhJNZmhJ/icvEG8z4jCrpU4hkZ1vvGo6Naw9ZCb3MqLWjDeDRNV7pNcrg1nCZmrp39ddes8YwDcPM/45Iv4SNvrleX42zTRAFsFB3yc9ovRtwANDj66m0rLchxyAaCG37UK849Z78fujXA8xCuwU0TdWg7OhQKCAoX0P+Q6O1zIn6L0MPcSmn59GlioTKOnT1uESEobGbdBYg1qlf+fTQAK4WrJQanRhhxgTanlrMNQGhS4zdfdGFMbGIm/DwMYoctcYlFgn2+QcfWp0DrhgnSAKye3mIBOX/osUi49XffaTNRcmQN3ewsLzbuBFerjEm87YTrdmDMtn02aNnsVs/HXwancviP1+jtQcIe414Utb0C346S9IIFZ4eVbabYncgsXKkwGr55xsTQSWFAVGhxwugObwaki0LruYWSI/R P6r3oZAW kVWOmwIAXSEclev1QEm9fSPAGCrlVv/sPzYjz6NuzD3PwiLMBE0QdlvCPXnPKPAvVQBDilRoJP7VfwqmQRoEGgecUupF3MGOwOafAAsMtUqWPzoVswazcg9G2tVUYlqIm/8t0CiJPTSpcaSd25af2Oj5d0BgEcKTFY8yAD59SsF/UMxsVv3+llMo60eFu0ad4N82UK3VIXOTHx9KKeKbXZarnAQJ4ALPD0lBdzcaw17WbSZJa5KFnia9ZesK7/OlYuoptch9J+bcMIljDAgZ4SZ99K0feOMCY4kJDRkMh/QN3GMXJwPyhEGltrHxJbRhmOIFwpWelHDkuNgNT/BhEIH0vEuqsBhgnGPcTaRSEey9zH//vzqKp3V3rI2brx1KLfVzs+3Xql5hCm5RnxyOAAgkCkFzDCbeE37AFtr4afpc+mnGP/4jgpozM1Vq9iTvy3qNKOFNUcl49iIOcT4YjS3u4cH8I1m8C1AE/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 30 Nov 2023 20:09:00 +0000 Pasha Tatashin wrote: > iommu allocations should be accounted in order to allow admins to > monitor and limit the amount of iommu memory. > > Signed-off-by: Pasha Tatashin > --- > drivers/vfio/vfio_iommu_type1.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > This patch is spinned of from the series: > https://lore.kernel.org/all/20231128204938.1453583-1-pasha.tatashin@soleen.com > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index eacd6ec04de5..b2854d7939ce 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -1436,7 +1436,7 @@ static int vfio_iommu_map(struct vfio_iommu *iommu, dma_addr_t iova, > list_for_each_entry(d, &iommu->domain_list, next) { > ret = iommu_map(d->domain, iova, (phys_addr_t)pfn << PAGE_SHIFT, > npage << PAGE_SHIFT, prot | IOMMU_CACHE, > - GFP_KERNEL); > + GFP_KERNEL_ACCOUNT); > if (ret) > goto unwind; > > @@ -1750,7 +1750,8 @@ static int vfio_iommu_replay(struct vfio_iommu *iommu, > } > > ret = iommu_map(domain->domain, iova, phys, size, > - dma->prot | IOMMU_CACHE, GFP_KERNEL); > + dma->prot | IOMMU_CACHE, > + GFP_KERNEL_ACCOUNT); > if (ret) { > if (!dma->iommu_mapped) { > vfio_unpin_pages_remote(dma, iova, > @@ -1845,7 +1846,8 @@ static void vfio_test_domain_fgsp(struct vfio_domain *domain, struct list_head * > continue; > > ret = iommu_map(domain->domain, start, page_to_phys(pages), PAGE_SIZE * 2, > - IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE, GFP_KERNEL); > + IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE, > + GFP_KERNEL_ACCOUNT); > if (!ret) { > size_t unmapped = iommu_unmap(domain->domain, start, PAGE_SIZE); > Applied to vfio next branch for v6.8. Thanks, Alex