From: Jason Gunthorpe <jgg@nvidia.com>
To: Borislav Petkov <bp@alien8.de>
Cc: ankita@nvidia.com, alex.williamson@redhat.com,
naoya.horiguchi@nec.com, akpm@linux-foundation.org,
tony.luck@intel.com, linmiaohe@huawei.com, rafael@kernel.org,
lenb@kernel.org, james.morse@arm.com, shiju.jose@huawei.com,
bhelgaas@google.com, pabeni@redhat.com, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
apopple@nvidia.com, anuaggarwal@nvidia.com, jhubbard@nvidia.com,
danw@nvidia.com, mochs@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn
Date: Mon, 4 Dec 2023 10:36:50 -0400 [thread overview]
Message-ID: <20231204143650.GB1493156@nvidia.com> (raw)
In-Reply-To: <20231202232319.GAZWu8Z6gsLp1kI5Dw@fat_crate.local>
On Sun, Dec 03, 2023 at 12:23:19AM +0100, Borislav Petkov wrote:
> On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@nvidia.com wrote:
> > - pfn = PHYS_PFN(physical_addr);
> > - if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
> > - pr_warn_ratelimited(FW_WARN GHES_PFX
> > - "Invalid address in generic error data: %#llx\n",
> > - physical_addr);
> > - return false;
> > - }
>
> You don't just remove a pfn valid test just because your weird device
> can't stomach it - you extend it, like
It wasn't removed. patch 1 moved it to memory_failure() where it makes
a lot more sense.
Jason
next prev parent reply other threads:[~2023-12-04 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 0:35 [PATCH v2 0/4] mm: Implement ECC handling for pfn with no struct page ankita
2023-11-23 0:35 ` [PATCH v2 1/4] mm: handle poisoning of pfn without struct pages ankita
2023-11-23 0:35 ` [PATCH v2 2/4] mm: Add poison error check in fixup_user_fault() for mapped pfn ankita
2023-12-01 17:04 ` Sean Christopherson
2023-11-23 0:35 ` [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn ankita
2023-12-02 23:23 ` Borislav Petkov
2023-12-04 14:36 ` Jason Gunthorpe [this message]
2023-12-04 15:36 ` Borislav Petkov
2023-12-04 15:54 ` Ankit Agrawal
2023-12-04 15:55 ` Jason Gunthorpe
2023-11-23 0:35 ` [PATCH v2 4/4] vfio/nvgpu: register device memory for poison handling ankita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204143650.GB1493156@nvidia.com \
--to=jgg@nvidia.com \
--cc=acurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=anuaggarwal@nvidia.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=cjia@nvidia.com \
--cc=danw@nvidia.com \
--cc=james.morse@arm.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lenb@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mochs@nvidia.com \
--cc=naoya.horiguchi@nec.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=targupta@nvidia.com \
--cc=tony.luck@intel.com \
--cc=vsethi@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox