From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC40C4167B for ; Mon, 4 Dec 2023 10:45:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184A26B0293; Mon, 4 Dec 2023 05:45:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 133FB6B0294; Mon, 4 Dec 2023 05:45:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04AFA6B0299; Mon, 4 Dec 2023 05:45:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED0C86B0293 for ; Mon, 4 Dec 2023 05:45:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C90DC8019E for ; Mon, 4 Dec 2023 10:45:52 +0000 (UTC) X-FDA: 81528805344.25.50CB26F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 902594001D for ; Mon, 4 Dec 2023 10:45:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701686750; a=rsa-sha256; cv=none; b=CiKwKLX64hYjCj4NL8F/wl7oBbMjB9q29aclKo1U5GvYQo94qS4MV/rjJo2f6hdg6c7y3/ UhaSmaKN7h8dCFeQIBHT6N+163RxH+/28n1F4Aza8d7MmzLsSU3kj/Wud7bUepsnhCfU/O Uv0zyxo1LwgWCc5VF7208f/lHFIqetE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701686750; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pbiLa3chYkgi7DIsqF0xSLgKHIK2yZVsRLWTHql9aCM=; b=asbAtrEhO+K1+BPdW6xblT2urxaCE3spRvB2l1nZO1MWYekjWrP7REwRj9S55HeXmReLwt SAhQb7vHnxGt6velXHFAzVqHTDAWkUqff79L9Ahbkw71yzLRItIPervPljSQE3pdxFxlcW DzSIeZrLbdpRgfg1M/zg0C9k26W3xU8= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D3F961F8AA; Mon, 4 Dec 2023 10:45:48 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id A735C139E2; Mon, 4 Dec 2023 10:45:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 3MphJ9ytbWV+RgAAn2gu4w (envelope-from ); Mon, 04 Dec 2023 10:45:48 +0000 Date: Mon, 4 Dec 2023 11:45:47 +0100 From: Petr Vorel To: Stefan Roesch Cc: kernel-team@fb.com, david@redhat.com, oliver.sang@intel.com, linux-mm@kvack.org, ltp@lists.linux.it, liwang@redhat.com Subject: Re: [PATCH v2 1/2] mem: disable KSM smart scan for ksm tests Message-ID: <20231204104547.GB22019@pevik> Reply-To: Petr Vorel References: <20231201210930.2651725-1-shr@devkernel.io> <20231201210930.2651725-2-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201210930.2651725-2-shr@devkernel.io> X-Spamd-Bar: +++++++ X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 902594001D X-Stat-Signature: ba6nxc54net9kht1ck7ipidpbp4h49np X-HE-Tag: 1701686750-800398 X-HE-Meta: U2FsdGVkX19hPf8AsSqvYWDQ6UboypE+AW7oQoPJS4nbdvTEPtmR80asW5R/Zw07j5piP9qlRepaG7vxzJeY4isCiqlI0BE7WxU4zV8dHb5ryEzQxwfPLCLAAf3y+6p9nDxrjlmB+5QpJ+pN04Y75dBl7hGKHUCIQjlhymuLV3N0XITRHPiZo4MDftE1DEcgAvLippb+PR3vfELLp8vh3Ak1SPGVz4aktj+3cpqsMNE/VmJfswdL++X+nK2Nf7W44pLOgw/IwjOKiRk0J2gIXZuHIQoQSgSLB6UezcWrANBpm/fyGEoTYKeodD+JUu2NthrQDNzCVAi7qVS2PeafezV+V4TZQ9qIjCgViM2AAOrX7DbpLZPYmWYCUYnz4xKe20jnRsoPN5Mn/q+IuTU+1gbQ/8VGCai9CXgWOpJZIKlYumcfsF1eSuv/yXuoexpDHg7/drqAXf4jmqw8i73tuH0RV3yNdZ3daT1vF9MPiJnAH3TqwHhNGrFzTYb1kU6P3DhsJle679wA24K+jCDIRFQvwQ1d1xAhc/L2btQhhMFUCCuaLfPQoROkif7x0Jo5CwAEiFQ0NquwP3E2MmcKsQIKzUUO5z+WgwcSW/b7ZddhyPuOj0mr+0uduT58WRvm+Fz7tLJU6+or3LEKdtIWOFudzV1ZPHvjID3k05gGGWWKtsLUp47lpWjOqEzOkK4dNGEktlhIaYQUICUSaxIt3eW9YgcFhyuz+o7u2nxrMmrHw3eIRedORBmDa1ckLhnkPwUh2rvGKWSTbiiUDVylm9Lmy9IL4O35qBPJXGEE/8SuUJFZJjYZ5BV6/NvG3eVo28jrZeJOug/eacI3ZTxeG3kau/kTIJJhhlPALLY//YpI8cz782kyphrBxpvKEfetrOqzwmCvMgHFDlDYsHF0hs5Fk8Wb8nZeGU4wlkBxunju3KaC5m9wZb5wGfzaBvYytxDKp34tZp6zSB8GeNi pdtpPodv hnyP7+Vn4QwxmcH2ZJNOoSTUVolj6cDkDvv2a4zQLjid7jpJuQorNj02yaZ1BYMMCtPyo9ZnYYk4XuOxeNwypjEwlWgbXZN2Pzm2NZ44r9iSNtPbJU/TtN92/r3X4j9Tfxs1fXMBEALs11e9umnPY5PnHroEiZ55piz9GVLaFAof+9R5wHPaN/xvp5p+vIQaLm8PwYCin6S5K4jZBhDhqiMY8eValBvCELSKxFVQ+qPJWIoPOYjEgTkRj866JzmzL9cpg+dW+P+cOz1wn8pidb0c9t5qBNPZCoAJHHE0Go+5IX7BNTRItoHVCGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000371, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Stefan, > This disables the "smart scan" KSM feature to make sure that the volatile > count remains at 0. > Signed-off-by: Stefan Roesch > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com > --- > testcases/kernel/mem/ksm/ksm01.c | 2 ++ > testcases/kernel/mem/ksm/ksm02.c | 2 ++ > testcases/kernel/mem/ksm/ksm03.c | 2 ++ > testcases/kernel/mem/ksm/ksm04.c | 2 ++ Li suggested in v1, that also ksm0[56].c should disable smart_scan (ksm05.c is questionable, but since you prepared ksm07 it can IMHO be disable in both ksm0[56].c). https://lore.kernel.org/ltp/CAEemH2fqamX720diM1N+iN9a8HM30_5sHg8V0EMHgHdrh3iZPw@mail.gmail.com/ With that, you can add: Reviewed-by: Petr Vorel Kind regards, Petr