From: Petr Vorel <pvorel@suse.cz>
To: Stefan Roesch <shr@devkernel.io>
Cc: kernel-team@fb.com, david@redhat.com, oliver.sang@intel.com,
linux-mm@kvack.org, ltp@lists.linux.it, liwang@redhat.com
Subject: Re: [PATCH v2 1/2] mem: disable KSM smart scan for ksm tests
Date: Mon, 4 Dec 2023 11:45:47 +0100 [thread overview]
Message-ID: <20231204104547.GB22019@pevik> (raw)
In-Reply-To: <20231201210930.2651725-2-shr@devkernel.io>
Hi Stefan,
> This disables the "smart scan" KSM feature to make sure that the volatile
> count remains at 0.
> Signed-off-by: Stefan Roesch <shr@devkernel.io>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com
> ---
> testcases/kernel/mem/ksm/ksm01.c | 2 ++
> testcases/kernel/mem/ksm/ksm02.c | 2 ++
> testcases/kernel/mem/ksm/ksm03.c | 2 ++
> testcases/kernel/mem/ksm/ksm04.c | 2 ++
Li suggested in v1, that also ksm0[56].c should disable smart_scan (ksm05.c is
questionable, but since you prepared ksm07 it can IMHO be disable in both ksm0[56].c).
https://lore.kernel.org/ltp/CAEemH2fqamX720diM1N+iN9a8HM30_5sHg8V0EMHgHdrh3iZPw@mail.gmail.com/
With that, you can add:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2023-12-04 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 21:09 [PATCH v2 0/2] KSM: support smart-scan feature Stefan Roesch
2023-12-01 21:09 ` [PATCH v2 1/2] mem: disable KSM smart scan for ksm tests Stefan Roesch
2023-12-04 10:45 ` Petr Vorel [this message]
2023-12-04 18:38 ` Stefan Roesch
2023-12-04 18:38 ` Stefan Roesch
2023-12-01 21:09 ` [PATCH v2 2/2] add ksm test for smart-scan feature Stefan Roesch
2023-12-04 9:21 ` Petr Vorel
2023-12-04 18:41 ` Stefan Roesch
2023-12-04 10:39 ` Petr Vorel
2023-12-04 18:42 ` Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204104547.GB22019@pevik \
--to=pvorel@suse.cz \
--cc=david@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=oliver.sang@intel.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox