From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A4DCC4167B for ; Sun, 3 Dec 2023 11:58:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDAB06B01FB; Sun, 3 Dec 2023 06:58:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8A446B0202; Sun, 3 Dec 2023 06:58:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2ECA6B0209; Sun, 3 Dec 2023 06:58:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF7746B01FB for ; Sun, 3 Dec 2023 06:58:35 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 83675A0142 for ; Sun, 3 Dec 2023 11:58:35 +0000 (UTC) X-FDA: 81525359790.04.3018C2B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 7C6B7C000B for ; Sun, 3 Dec 2023 11:58:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SUojLJ0D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701604714; a=rsa-sha256; cv=none; b=y05DcQmfg9UBuRdH61YXCyerQquvsMWRYRi76hkOCYenS/Fp0uBQbgD7A7DXm1v8t133Lf RcXSPYXPUNwSKNNGwA3jDg2/FX32WFvu6Oe/b4dyTiUNDWp95OfatiFOKXaKdovCKaXfje cRjs+ujmgv4Uq+ulWrbKU9ZEOLB1G6A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SUojLJ0D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701604713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SrPXBpvHY4KdrtjINePfD8UPOr4sgdZKZ9V18j5Q8mM=; b=ohouVq8aS1qLieR2BadsKX1p4u3Fab6zHv8b0ReGr0IVgl5LWb2MNmtKu9pjxNX7LC5Wd7 CeDktqrKDqcOobn96EC1XR1ZbJDXDgfFmTHBSJVcPvfnYwpdijXWyPY4X3pDdx4WxOZM9o usrLiAT/JVSRLtwJfPAUXJnEdA9QIcE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAAD3CE0025; Sun, 3 Dec 2023 11:58:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7623C433CA; Sun, 3 Dec 2023 11:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701604707; bh=pziQ1U7QdvFt6jazsNDQct2z9qMxwW1lVib4eO04oAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SUojLJ0D+hYzFpx4UrmEnt9hX3wdMqFvaPaScNdRJdBUkFxOK1TgiKTlQA2imiz1s Skxn+cTAEJn+ljsDkSEMFy6RotyZEf1HHA+eExaEgkxR6pz74CYXB9ujxCIn52F6bb EnmjraVq10aj62PL9SvsO/gowrBB7a1dSx5kbhdE6egTVL+10D8duPz3mFV3GtQtLI dvdAxoXf2IXlKZXq4LV+TN9wB1Hrw4UD9xL6+ONRE7YxrMg11jPbRzh4x9d5lpsAUy LV7TN9ebLHkYgrT6QIOORyT7xIYLG+w40wV+i5W9Lw+BSooqjNZRKsM2MJdJPMsZl6 7jI5bQTF5NFtQ== Date: Sun, 3 Dec 2023 13:58:15 +0200 From: Mike Rapoport To: Serge Semin Cc: Andrew Morton , Thomas Bogendoerfer , Jiaxun Yang , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/mm_init.c: Extend init unavailable range doc info Message-ID: <20231203115815.GM636165@kernel.org> References: <20231202111855.18392-1-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231202111855.18392-1-fancer.lancer@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7C6B7C000B X-Stat-Signature: mmxcuh5aqodjqxpofx97ub1dcdus8ygg X-HE-Tag: 1701604713-140594 X-HE-Meta: U2FsdGVkX189dDRNNI5hYAr4dyx5GmUXikRkQq0f2fjNwD0MlaP3k48J8/3xHUSbivNwRP3kZqkdpmcCK4lCA77wwG6AoYRtzZWxwrIxi1XQJS+L8Y5S6TDjYlAvj1PW761rANb+FFk+sTNO7pUTGuDhkqtGeocuLsbRiJZkLjliZ067MwEoCPRqOnJTNZ1aTQtUI+jEwEdGNk7NL8Z5LouHqZiqGXMzXEy7AMjgVZ1lzAe9bVOfCQJMZWECvys3i+tHapJm52EE5gN4uvlKDtpKSz/+erDuXTvnaQ7mQZMcv55WXPt0n9FKlu2SQHjhZ64EPxGFu6UlEC4knnfaF6kE9dELSx3v3poOag9IbdxvW6iQhWgVG9n0t+w5LXza6UmFjsdx4zRCQe3i5soQpxphmFLS8I03U6WTySVdWMyij9Bb4zg3EXvdstr35zLBDg2MR/v/T9Cd6zSJBgvsaWi1hqDlv+GMO5cD2i9vFkkLDxbdx/dXT9ibjoAAiouIgL3/XmpHHRjAN8yWc6SPQdlZznlfW5qyLJLCdMeE7m3/X3RQvoTsmjpqc+CVRIQckEXuFr1fMVPYikzOoWzVJpc+fW++sKtO3fhH73fhDvG5pMYbhtsW77IK67Mq3sTFIgxsqSpmWjP6WsNqFYWNBqd8mOKVoN0H14JEEAtiUStu0oMXvGn8WIgmQIUDtqIibzguBpz582sV4mDbDQSFjdNNrNKXZfT0zuhlz9qCmx7G0v8PWSI9wsqTVtyrEchnlBhTrDTXkXWZH9/EfKEfSalXcCJ8E6j7M2yOvObCO6UvTIeCsNxmW3TBEN2gWMyJjcsQIPjvEsKW9h/LCEa57fT8WdgP2txaRrOq7hVGo8iUFTr/4gqvHTlb845R2MYnD0CQ9sgyCtTG07z6SWC9lFfNR+lp2jkYMOrD4tU7FnoTSeseKU+xnPaflfU9RDGz1Rg5rAZEXmLRjxB8Zz4 2/PbLcdb CSf5FBfSfTk2CgJ7H3YCHo4++UdS9zvUHOCo2l/lyzxg/9opqKJ8LbLJ4edm/L48OySr+X6go/Wuf4p6pY8I+R54VHa7YUNEYK1BTOACqOEIxMRSb/VLpflrBKYwFSOKv0mOI+RKaRH8ZVMpGPPvWxuVo0xzcmd/+s+TRovaycVB8kRxlNXdgjY2icvmg1CFJgMfZSMWPlhRN07t0JojWE+EkzNK45Sj1aNXprwASNr5bU4bUcaKiokbZQJOoOZA7eCgvSihxSasvui4rLewLp81iF6q8L2YZyA6TLPYoqhUIALegIqy+q9407pUl/kTicaOAoE4ZAqFZxV2i7MUoqS70aXdzjA+G7yeSmg5/AY+2Dr/VGgSHMLU+ffvL293491g9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 02, 2023 at 02:18:52PM +0300, Serge Semin wrote: > Besides of the already described reasons the pages backended memory holes > might present due to having non-memory regions covered by the contiguous > flatmem mapping. Add such note to the init_unavailable_range() method kdoc > in order to point out to one more reason of having the function executed > for such regions. > > Signed-off-by: Serge Semin Reviewed-by: Mike Rapoport (IBM) > > --- > > Link: https://lore.kernel.org/linux-mips/20231122182419.30633-6-fancer.lancer@gmail.com/ > Changelog v2: > - The holes in the memory are actually justified by having the flatmem > mapping model. Change the patch and the log accordingly. (@Mike) > --- > mm/mm_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 077bfe393b5e..824bf53e8253 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -796,6 +796,7 @@ overlap_memmap_init(unsigned long zone, unsigned long *pfn) > * - physical memory bank size is not necessarily the exact multiple of the > * arbitrary section size > * - early reserved memory may not be listed in memblock.memory > + * - non-memory regions covered by the contigious flatmem mapping > * - memory layouts defined with memmap= kernel parameter may not align > * nicely with memmap sections > * > -- > 2.42.1 > -- Sincerely yours, Mike.