From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C274C4167B for ; Sat, 2 Dec 2023 23:24:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FB786B0309; Sat, 2 Dec 2023 18:24:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AAEA6B031B; Sat, 2 Dec 2023 18:24:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4728F6B03CD; Sat, 2 Dec 2023 18:24:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3516E6B0309 for ; Sat, 2 Dec 2023 18:24:11 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1273CA017E for ; Sat, 2 Dec 2023 23:24:11 +0000 (UTC) X-FDA: 81523458702.23.DB26876 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf29.hostedemail.com (Postfix) with ESMTP id 09BB0120018 for ; Sat, 2 Dec 2023 23:24:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=iMB1Y3tk; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701559449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MUOeGeZ5B/ijKebEMHCI1M4SgxyUmLcB9iMR+JlMLs=; b=Fy0JAkjMZIppXGs9bJB8ZtiR89L+n9IP2s3u49cfalTSi4JzPqzSX1gxY0eaDqEzHD4YEa CgY+MIdp8rZDb4nxf/ZPmkSKpKqOLn2SKn7evIP/6WOu+6xpvMqoToGbIb+Wns6amRujb1 tmIUwy5aTphzeJ95wRQHiGjlP7wsOnE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=iMB1Y3tk; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701559449; a=rsa-sha256; cv=none; b=pTi89Uj92paDXiFdB9qmUxgSEBPmterS77tD7VTT5ZIeWgKiCiZf3zTJEDlW9a2jXEXZof cmUHyF0+bZALp1xVbFTzQGISdIMUIlwCLdzw0mecay3iKgby35YSolBN47ZnyRTnGkEMoD FXju80vhVyTSDgOl+f0fb5WIkLvo83c= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 049B240E025E; Sat, 2 Dec 2023 23:24:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Niido9d84076; Sat, 2 Dec 2023 23:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1701559440; bh=9MUOeGeZ5B/ijKebEMHCI1M4SgxyUmLcB9iMR+JlMLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iMB1Y3tkckvcPzSIMFzmO3QkTWIi54wspB5lmz1p3wTg6sxvgAQFS/nx36pDTM0Sq NgyyYA2BJjSs7mKalgZjLnssy9RIcogY/ezUBLtJSnSwvaN+XnU5Q5hoPq6ey5XoNV 6i90Aks8zWvQzMrvKCE5JQCJaUAOU4vauU5u20R0RY+FOSPtmhNz7S07ruwEpCyljE Zb4HbsOKfUmciNg9PdeQk3uLL+uq60AT+D/jnZyFPFOlGc4/9lxSUnjq7/nrc6ngtY 0knlTxmZsBU3V9L64c5k459EgRJwLOUS5s1LkhThC/cC5hR+QwuT0CTvf6tC2xwiou yepw3gnX7/Y6zWZ0dZqtIdVdM/aKXqa0GEY1vGHu4DKt5YznVMOr4f/+IqoEJMgxvP FqKfr1f5QsXC4gL42/Xiy15FtLlx/TfRSPZ08FFR8FHMIOGAG9ZQE9lEweuHN39f8x DkjCdnOJpfKb0NLaNGgStt710K9S2259FgCEMmkaaHH88Y+snZGFi6BcpkfHXAuwuM G+Gr0/GajAaNadrPeOZf03ISMk2hx9VOPR7KTqjZPfUWklUcKDe6raWSXDSZXRxgAS 4hdDMInA/pVlpCBNIPHhSt1v1VTU4AAmV1i7LX110RdsrPcVsxU+SSFaTt6AF/cTVk CfeM1jrzHeYaLK5JmqqRPwG0= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 05E0D40E024E; Sat, 2 Dec 2023 23:23:26 +0000 (UTC) Date: Sun, 3 Dec 2023 00:23:19 +0100 From: Borislav Petkov To: ankita@nvidia.com Cc: jgg@nvidia.com, alex.williamson@redhat.com, naoya.horiguchi@nec.com, akpm@linux-foundation.org, tony.luck@intel.com, linmiaohe@huawei.com, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, shiju.jose@huawei.com, bhelgaas@google.com, pabeni@redhat.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, anuaggarwal@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, mochs@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn Message-ID: <20231202232319.GAZWu8Z6gsLp1kI5Dw@fat_crate.local> References: <20231123003513.24292-1-ankita@nvidia.com> <20231123003513.24292-4-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231123003513.24292-4-ankita@nvidia.com> X-Rspamd-Queue-Id: 09BB0120018 X-Rspam-User: X-Stat-Signature: cx3mx35wja1ha3mi9peaizee71huf814 X-Rspamd-Server: rspam01 X-HE-Tag: 1701559448-603516 X-HE-Meta: U2FsdGVkX1+UMhlgoZU39e6UxhdKc3zUS7efELyExKNOWvFVlkIe1xqcxL5R23KibPpNZIiA+NhM5w3og8jMyIFYF7NmF97NjHwDGjBZEq1qhGracm8kVcafnrWOhYLYxRFmoHCDsaPxKiXVqguXUC3Hd1bxzduPHaQjwylQ7brkd80vLz4sRTybsLKvTOMWpLAPCD30A2kPzq3+qkkNfeDsTgSRBU2IWEbNLC4htrP/wRSANKVQKUlJoekSIrMpI55f47q3/5D5R09qC/7oq66G4MhopjzMWPuV+4N/fHMNDoyT4oWhZztWA2szue9ZkZY2QgmKJPaDUEgSFRpWecz+6pawVmnqCEwkXXXTbpfR7KKhehSV+8vWmAtyCo3ZYUdnRF44n8CPv2loE68ApDbKfJjr70MgjVrgZ+M3PrXqggHDIgqf4duGii6m5WwLvkauf7ecYHwZpgV7IeqtmHQBkWPhBOg6A1gvJLYfRY638xTEmLf45Tuqs282pJU0fhJqQvMtItEC4NtUWw+q4yO7xaSfxSZxiQ3SkqFgpWkalmuoyjs3y150JCJf0NAwW0UokhfdHMDOVNK/URqWBZZ3bMpkARbET7Tqgc1Emzvax/nTXJqSXx/ufOI37oC8d68UP29MJI2r73JS6X/UTMtbc/ns02d7Y6fK8DL7WWgwcE+nFNGl99v5A3NplULM2mIwAhfAYW8PHsCOw/1BJIoaRt/zaKRW/pTo+qxWfUub3t433VI0FLIls6JapjlyqcTHh6zSbHKwGEzzUp2g2QcVQDkXLEigA40dOfuShLnLUr2OexTzxRtC+QUOhROhKCOYt7zVi9zjaeNHjFsL4cRaQVUNRk2vXr5Wve76QKvUS0KZKKLUfD7k3wG14dVSCarsOpOye7NevVLNCtq5AuMW1Sd9DNmRVF6ry+dJfAEhZpQXM1IClhBqha6x3zs1njgfcoGR3Gs7t2vWb/R qL5dI27B PTzt+FftR7as1Luds6vi3Qv8/R5qZ1tPAwMbNSFHS3gkmAV7b7i7PqFhTTd5Z/FvmBtilL+CjTloFw3QODH7Rb/vot4pJcgGiQJ/DwL5Bk1oNqBs0PFShhF53XoZ5RrsfbYLfUpdSkpQfi23vUMS1sblu5da/PA1JkeaAdloYY+IsaKyryrRkBrMbLDR1IQOSJhI+e6MeTvdw//9sC68I6HYX5HUjWCb2iIvc X-Bogosity: Ham, tests=bogofilter, spamicity=0.005790, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@nvidia.com wrote: > - pfn = PHYS_PFN(physical_addr); > - if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) { > - pr_warn_ratelimited(FW_WARN GHES_PFX > - "Invalid address in generic error data: %#llx\n", > - physical_addr); > - return false; > - } You don't just remove a pfn valid test just because your weird device can't stomach it - you extend it, like 3ad6fd77a2d6 ("x86/sgx: Add check for SGX pages to ghes_do_memory_failure()") did, for example. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette