From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2407AC10F04 for ; Sat, 2 Dec 2023 21:30:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D26D6B03E6; Sat, 2 Dec 2023 16:30:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 182ED6B03E8; Sat, 2 Dec 2023 16:30:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 072A96B040B; Sat, 2 Dec 2023 16:30:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECC536B03E6 for ; Sat, 2 Dec 2023 16:30:12 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A8BEF16015E for ; Sat, 2 Dec 2023 21:30:12 +0000 (UTC) X-FDA: 81523171464.02.4BB7E6D Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf27.hostedemail.com (Postfix) with ESMTP id E1C9640024 for ; Sat, 2 Dec 2023 21:30:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jcGTZN3C; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701552610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T5J15MlXHLI92cGapwCUHhHVqByLKgeQqZvgS95PAzA=; b=Iam/R2As2Of/ZVtOHJ9prYPudZ3i6V1S7UlgHaAqffU3YcAC8aS+OZeh3RGzz7CPfcczC7 C0Xdq7LCAoX1pvHNKBuWvkLiKDLTToSzZdPVphjHJr4wq9wIfXPlOPDZNOQMFZIMQc4ApV evHAc4lILODAvarbJ/ioPgmSiNfIPkE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jcGTZN3C; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701552610; a=rsa-sha256; cv=none; b=XuPrCRBt+jbeFxePYc5vHW9pDX97jeanOBEDYihqRZhiZK0DhzOY7p/IkewQ06pZ/yVIHJ XgteAsFwp4WLdgInOKFWtNUAiDWwX8ziuw6M8SeNV8lJsV/W68NxWSyqC4QLsF/41UMhtj De11c/XziuESMlm9zh0UXHUSY4S1UbU= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6cc02e77a9cso3257527b3a.0 for ; Sat, 02 Dec 2023 13:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701552608; x=1702157408; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T5J15MlXHLI92cGapwCUHhHVqByLKgeQqZvgS95PAzA=; b=jcGTZN3CnnZE4Y/RHFxDe52cpVA1WzyueKCcqWUaFvdOdN0fChL/XIYfe0CZK20EUG fPnyleHzX/dMBKCJg2EcCOxP6/egn6lUYmqWcVh0VcO/bGTQ/YL2pjJzyBiUtYDmIKG2 5meaKFqdnuK4txmaJrBtPIaIRFJPYaPriLui8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701552608; x=1702157408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T5J15MlXHLI92cGapwCUHhHVqByLKgeQqZvgS95PAzA=; b=EKqWoN+UYzGr8rMFIyhi3YWYuTU1nTud7qpAzMv7YGQGhtuNNEeiQx7ne5kIoO0eJ0 utry0MWTCiVPQHQeIZN/RbGw51CH1bTHkPA57vPRyZjErkoBYjEaNaoWMnEdAeJ9skwt XqYxnsX4JYhRxh84Wz/k1hR49m8pKnh15d6THsG7hYTNOlT3dE/7KZi2An8LDxGPWC7k s4rQ8mg4SpoOwsnwSFmUexzygQt6Db/uXStT9OSTtXSzWBGhMqsoPAUTBMG5hvztuRJ1 FFMf47DYzOmeAKbc4vIdTIuQA3rxcYC3LBZkjtnxBeNPeKrReqHXv8BIq2mvbrn/84Po +zMw== X-Gm-Message-State: AOJu0Yxx8jBE7RDdBL2wo1dwiWpxOq9BOYh8rNURqVsOGx99QOu4FHq1 VkAlzrjjxCr7nStq6g28SRqB7Q== X-Google-Smtp-Source: AGHT+IHvVBon3TJyINAYLAf07X3SlMJEK4rycMYTmue0klxJqQCgHaBNdJUe4p9vusQ32Ct3N0bKjg== X-Received: by 2002:a05:6a00:2d24:b0:6ce:3c1e:743f with SMTP id fa36-20020a056a002d2400b006ce3c1e743fmr849277pfb.41.1701552608590; Sat, 02 Dec 2023 13:30:08 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id o24-20020a056a001b5800b006ce3a0b4bfasm984474pfv.24.2023.12.02.13.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 13:30:07 -0800 (PST) Date: Sat, 2 Dec 2023 13:30:07 -0800 From: Kees Cook To: Vlastimil Babka Cc: "Song, Xiongwei" , "sxwjean@me.com" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "cl@linux.com" , "linux-mm@kvack.org" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "roman.gushchin@linux.dev" , "corbet@lwn.net" , "arnd@arndb.de" , "akpm@linux-foundation.org" , "gregkh@linuxfoundation.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" Message-ID: <202312021329.86D56FA@keescook> References: <20231201031505.286117-1-sxwjean@me.com> <20231201031505.286117-3-sxwjean@me.com> <202312010945.7C5DB1FBB@keescook> <67b155dd-3731-489e-c3bd-333cb7e90801@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67b155dd-3731-489e-c3bd-333cb7e90801@suse.cz> X-Rspamd-Queue-Id: E1C9640024 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: o9eb8fhxe33c9xmcwkoqaif76cn3q4sr X-HE-Tag: 1701552609-885381 X-HE-Meta: U2FsdGVkX19Zc8nfcHFWlMBLChSeJR0xVGUMJEPipixnDWmAR/lTel1FOyCDdnwiNztsE+5O7540ijYveE4CpZJocuDZRkxDLBc024cbYurJfwPhKljfunCn8yIfRbNphzlWQXEnBmKKAB8rU1iT4pJld2PxkwADSoU72zvRScK6gOQq9w0qvXz8rmHpdtXEVMPAQzmAAWLim88C7kOPZYjS3ZnXt6e8BVAS606i8fMB3zh2AjkmPajgphmCCwgWR721JkVdBaI+DgujJV0Nte8JvkaimCIx5JhkuAqdkH4ozdszlNQvxTlUfkz3Sn9yV381sL/MCYwIPFfhMPmCcxksn2W3IjuoKcSB2skqNP/1GneHX+3rFwWid73FVJP0iWk3ZIdRLx8sT60dlZ7Y4/1aMR4aSfsQdTdFH4ygd9giW3r7I3ZkP169B+FbtQBmpw1jbdl8m+aVh9iNrMKJQW3jAexugkTsTd57pUOOjQEyfRtcDwomyy9PG1vk29AQNhy2Lk3MiE3TVIpHHBZPMBhxOYbsntw9k9QTkdb8p69IHbvtjWkh+nUA+Rixk+YGu5NhJwO6L2fv+zo+Ui1rk1BQauS9WgjbQ6XHgmJcR7RTZLKhbfsOnuBM6m37haSt+5/ko1GRpE5hV2uB9DB41z4uXUOobCKVLQBijGr2ue641ja1yyFucK+kGL87i8qWS4og0dqTmufD7xCISxAkHZOeIKW3frbXy/ECKMp+MLLY1r2Dj7RcGx7mu9cqZSvRDo3VaYsv7fwUWwQEYIzVwY2aKgbdyZBI+VXC4f0RSf0CsUR2xnachT2rHXiHNL1hkm6ap0od0gI6SCoMTUCwBM4toROkNxaBsLwByBS1FvtvTOWlaH7N4Yls/iDqMMPQp2PFd8+mRwQG2TEJLDJ0NSBvMWmKsNsQta7KjITpdXEoKSHs3krrgkg49dk0qz2GTUtr3ZFCY3VU8Fsaru5 uCN2giOg sGZ8t6ahd6zo9sIyaym4tdhusXlY3huVBG8dYJhfIQP6UNXexR7eQ5hjp5quRL4l32NSLABCYWJBsmXW20t2bUtIuFRkuQbrQfVbo32KLrEMmZPiexjG6t0VkAIkdOWbKNfjB+Sj4+LJfX7CCE7A4dodmEZ8MDfI6RcmVvDWCuJovZUNiMD+KAuLD8jKpjjEpAewOxPz3mWtCcbL1Ciq1tSsZIScQX+TSmoR7DtBiKWLMzmQ789HqxZjLaNVaYHSJW56FBfGhnFOtVmqTekO10uX0qt9nqrBvN+Kf5kdUlZPK3z4oiQmE2CU+JcWsh31WhEK11U5cHA18z5BmfhRweKXXU+ZsDDD32ZYgwr4UEAdXgr8Vk8KSfdhHLgzDvQGhA3v9baMF0IePUQNefdV4udwtHrlA9Ndm/UEeaFwsh3LdQCPoh7L4In4BN3P9bLJvSmYY9D9KmxxYdQiTQdnBJRJJQaDjIhSc7FSXJJ82QQdBI2HlH+Psyh3lfCouSsndL2cWCDWQfFDU2Rz0kbMb8+eHTJJ32BYwb5XJ8jxpv8nUEl6sYkktot9ZtbWxgjPgXpxZNbpC2zxNa0zhC4qqLoIibZYC/YgezvbIBExYJiIZUzXgbH+Rpie62Y+hk4j2sfW0xPu0NmmPTxsHTZCEXDujJB3gU4CJUlw4dttgOjOzVCjtmJxNMe4glB7kWBEHIf6hqiwbnl8mdWDzeVRZK72LBrQaN3rBzA6HIyoEBwevTSgVpoTi0VjuC3qoBcxfoiHINAA1P6FfNfJ9Vtl83XPU1jlMUY7mcbpwgLxw3yzCHCy53yi9u4Mx2r0Yu58HMcEfoQHZ0ZbYPZxtxv4tUOmc1aP3YiKyWpA0A94yZw+b6oUP77Y0Tx19vJj/anrCO6QYJreJKXW5FcSzzOs8XzpIoAb0b95fkTNFlfKwzkDJKxCiLcZGK34W1UQ2NiNOCOQICxHXZ7HSfkZKR4Ux/mWwMXxJ pE2Et9WR aeBcakie1DEvi+nZWIZHgIg0AnMufbzrzwxwy2W5VSQZH239IjV2obDFUzAgdVtG8c4q2iH10qb7O1Vn0/DJAVbsI/y2uCwMOG77j39zUvAWwk3VOVZbg8vuh8Fk5lNENSHxGrTHP2IrV9GZmOJwNJWpF3hBHHkpbK825IbkkXnXckYWCs3rwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 02, 2023 at 07:12:25PM +0100, Vlastimil Babka wrote: > On 12/2/23 05:23, Song, Xiongwei wrote: > > > > > >> -----Original Message----- > >> From: Kees Cook > >> Sent: Saturday, December 2, 2023 1:48 AM > >> To: sxwjean@me.com > >> Cc: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org; > >> penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com; > >> roman.gushchin@linux.dev; corbet@lwn.net; arnd@arndb.de; akpm@linux- > >> foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; linux- > >> kernel@vger.kernel.org; Song, Xiongwei > >> Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" > >> > >> CAUTION: This email comes from a non Wind River email account! > >> Do not click links or open attachments unless you recognize the sender and know the > >> content is safe. > >> > >> On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@me.com wrote: > >> > From: Xiongwei Song > >> > > >> > Since the SLAB allocator has been removed, so we need to clean up the > >> > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for > >> > long-term rather than "slub/SLUB". Hence, we should use "slab_$param" > >> > as the primary prefix, which is pointed out by Vlastimil Babka. For more > >> > information please see [1]. > >> > > >> > This patch is changing the following slab parameters > >> > - slub_max_order > >> > - slub_min_order > >> > - slub_min_objects > >> > - slub_debug > >> > to > >> > - slab_max_order > >> > - slab_min_order > >> > - slab_min_objects > >> > - slab_debug > >> > as the primary slab parameters in > >> > Documentation/admin-guide/kernel-parameters.txt and source, and rename all > >> > setup functions of them too. Meanwhile, "slub_$params" can also be passed > >> > by command line, which is to keep backward compatibility. Also mark all > >> > "slub_$params" as legacy. > >> > >> *If* we do this, I think the old names need to be recognized, perhaps > > Yes, they are already recognized by the patch. Ah, sorry, I missed that. I didn't see it when I skimmed earlier. > >> with a boot pr_warn() about their deprecation/renaming for several > >> releases (likely across LTSes). I think it's not a good idea to > >> wholesale rename these with no warning. That's going to cause a lot of > >> surprises and broken userspace... > > > > Oh, yes, that's a good idea. Will update. > > I'd wait for a while with the warnings, no need to rush. Better to start ASAP, yeah? -- Kees Cook