From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56327C4167B for ; Sat, 2 Dec 2023 04:36:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BABFE6B04F0; Fri, 1 Dec 2023 23:36:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5C296B04F2; Fri, 1 Dec 2023 23:36:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23C86B04F3; Fri, 1 Dec 2023 23:36:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 919BE6B04F0 for ; Fri, 1 Dec 2023 23:36:45 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6939416042D for ; Sat, 2 Dec 2023 04:36:45 +0000 (UTC) X-FDA: 81520617570.15.2D664E8 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by imf13.hostedemail.com (Postfix) with ESMTP id A1D9C20007 for ; Sat, 2 Dec 2023 04:36:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GrZV2Yx5; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701491803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vZ4Kw46vkklP2CAYWmxbIyTZJc5BlwN6HHJY/q+3x5I=; b=Si5NwNfikUxpvoqSlOcQwffr4/pqrJ08WJ6bL//Nn91zJMGa4ZvyqCkQAq2irwjgxQwhbu Afg8mrQypOvcOs6iM3swiMeYk1huPbip7I0l1HmonaJhE/S2jOUZ0c737Y18R6DqqSjEfP nhWrWSllClQTmv3OWuy/uBCxB/gkYB0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701491803; a=rsa-sha256; cv=none; b=ET4LQbYcTBmFU3TLgUdE1JPvmlR+6UChIGRgMWECcK+kLqLw+wOVi5Xq2g/jZXMyVR0RIA dRBQhMtj1jIF/k41ZKx4En3uM1fxDU0JlmtjX1J8jtwtEs3w8LZtP6vS0+eQlB8LAnrZrS hJGMlPmibNHRPfJCdgGiWbtDOwtE7og= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GrZV2Yx5; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3b89b8d43edso948347b6e.3 for ; Fri, 01 Dec 2023 20:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701491802; x=1702096602; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vZ4Kw46vkklP2CAYWmxbIyTZJc5BlwN6HHJY/q+3x5I=; b=GrZV2Yx5k4zQATA1Pp++Bbh69tYh/1Wp8vtg2S0N/3ekQ9pHtBKLc/xsbPVF6QT8QE sHgnLbFD3FiLOBcFvlJdRw8K7B0gCXA0qjn1D8B1kgPl23B+ikUIzFBlwZwLNh/cstMY MDcLb7DK09We0Pdj4djXajh9qdV1KtWlvmP3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701491802; x=1702096602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vZ4Kw46vkklP2CAYWmxbIyTZJc5BlwN6HHJY/q+3x5I=; b=d6E6Zz0G5OS2B7OYHUQrCfEPY7xiRNUj5O5dWx/sjK+wdAjSWJejPP7E9BGpgtxVGA QCZCO80+9g1zBJXpPPiipUuGjv0p+PzxDLL4lrrFlmc9BvCFHNyY0rknVyadk1bgOyYL yMj5qbqx2092jQOpAUIEhj9fqvuWS+hkyYq9nV2arWORZDufQ3Jvgp0sV5oY3FXhVQjc oBLV2OeiCU5lK1cRT953/WP4S47pgkYWpfNUkIndOZxcW9Gs+z25909JdXOigDfvJOZU CtnqooDq6BRtox0RWVRc0tiuy8N5BWRTQFSjrAvqNaBfMt4iA+dO7p9t/9jt5/VJ75GG /aeg== X-Gm-Message-State: AOJu0Ywak7wQvOM4F68q8SfFQuidy5rIL0Um69fE5AIW0Q8T0aIyQsuk 9/uM4031Na/md34SqG3C0Eg3GQ== X-Google-Smtp-Source: AGHT+IFCCVdpYq3gY0n1LFwO2KkT3y4eW0VTzuXM/EPQPFJCnQKrkBYcN5RCLRYniqaPjXLIKP4RbQ== X-Received: by 2002:a05:6808:1456:b0:3ae:2024:837b with SMTP id x22-20020a056808145600b003ae2024837bmr1011415oiv.34.1701491802632; Fri, 01 Dec 2023 20:36:42 -0800 (PST) Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id z23-20020aa785d7000000b006cde16f065asm3877594pfn.99.2023.12.01.20.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 20:36:42 -0800 (PST) Date: Sat, 2 Dec 2023 13:36:37 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Sergey Senozhatsky , Matthew Wilcox , Mike Rapoport , Yosry Ahmed , linux-mm@kvack.org Subject: Re: [RFC PATCH v3 00/21] mm/zsmalloc: Split zsdesc from struct page Message-ID: <20231202043637.GC404241@google.com> References: <20231130101242.2590384-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A1D9C20007 X-Rspam-User: X-Stat-Signature: f4mwqaa1nabx76edyupasazpxryw4phi X-Rspamd-Server: rspam03 X-HE-Tag: 1701491803-398441 X-HE-Meta: U2FsdGVkX1/GJpuHrnWP5ASE74yw7New786p7DfVOgEp3ReH4mYWizsWRvavErQxpsw+y34HbyLuzfPG1KMhwz9L8alXtijy1gfPHoAj276XFMNmRym5LBBudmUhMF8WaEjPFQA3TJTFy6DC/xfRIwLfFV28Vu6+PWBE8LUsixIlAQ/EqeYPDmx0KKiOTUNlwe2fJFkw/sZeEXxCw67NLmref7/CCIYFxyZc+8QBx36G2LouCbeJYePDLjrNNbkPnjjmTjIx6KKOnbCFqEF20wlgdzQoA97dzoB+6ONKtTaQLfjJBHzmdRCLklZWOLa0Lw0kfUedilJTlCq8h+N2WMwFMlrFw/k+DRZMFfPVtxmGwF/1lPPP4UsL3xARVYOkotax3iEbXLyyw2HEsdiOZttQeH1249YQ5VRs1PWhwvHpf0u2TF8jCPg7tsfG3UtvBZZUqM29xsnSQT9TSqiyOz+XesFa2yfWP2nxcM0xvXoS4KswbiprVsTwwQmSGSCuJVPQ+NkH3f31Kk8SY9Hlibf+eLzPxX1uceLlnAewNovC7JhxTiAj0/zJpBs4L3bv1XID8tmzhf7iRLPjZzq19k5ntIdJaMTSHzqzMKCULDGmn53nnurMmnDht5meDBM76VeDnIwxiAvjC29wfn6PXZyslqWBoLgThewYFVHctU+IsZK/QH41w1xF5Ohf7AIDl5rzbwtvaj/rHOBrxfooskJlFG78oiQtodRdmTOMKJicLNjqSBVL8MbByBM1vYmyQ4p2IDjPgSbTsCmg2xv8A+iQuAp1lMMEW4DUlBKWRdbg59yjFgFtWUQJT5KMPyjIWWdT/TrWpcutdvu5Yj+2anQNDqNgMMRO4ZRjd0BN7YWjvb/YlmEqsDYqLZ8Do9kI+ZeGFe5tTADJzlNSEqa1MDQ+SsGIZxuBJiJppeiZ10Xzid0dAqfsZewtXuJO6FyUHB/pVcDpu0elQYdp2Sy L3+82yY8 L+bTRq5UBftvzGpUv9zgKEFpohWJoyNC45VnnmtZAicHmaWKKYcaC2vg8H0l9JQ7hfLXKK3zdmK7kSqzf/yf/Qe2LXfswn8q3JrGmXr2gmwmuNycOuqee8HkBDdieU0MeXHlrKTcGuDo7kzI1+ZJ3Y+umDHZW9lqajLWbGm5ULlehph62ntUbJER1dnS0GUMBgMje69qQduUppnuCWHVoSGrjLX1idYF2TfiG/eSnxiv4yqq9ArMBTk+pMGNUtX7SPgNd+fEx/KjBLTkO7Cu5V17tKmEo+v4gQ/QCehCLmTskd4RoowlznbYFrMFcsig30eFBWGL5qO0CxZQXeVEx9s0gc2dbivaW+JlyPDaxaxgUwNR5CvA2HcKM3BiuTCX8ljCaKELiM0JtAWrYXvRN2qW0JPn2Lgafxb8z9YCEATVi74RKefg8QXO5yywgEQ4bV6EHj/JoDy34u2r8r3fjKepU4e6Z/DL7ZNQrgol2Ai95xnCrltJ/N+bs83oQitwLHJgI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (23/12/01 11:28), Minchan Kim wrote: > On Thu, Nov 30, 2023 at 07:12:21PM +0900, Hyeonggon Yoo wrote: > > RFC v2: https://lore.kernel.org/linux-mm/20230713042037.980211-1-42.hyeyoo@gmail.com/ > > > > v2 -> v3: > > - rebased to the latest mm-unstable > > - adjusted comments from Sergey Senozhatsky (Moving zsdesc definition, > > kerneldoc fix) and Yosry Ahmed (adding memcg_data field to zsdesc) > > > > > > V3 update is a bit late, but I still believe this is worth doing. > > It would be nice to get comments/reviews/acks from maintainers/people. > > > > Cover Letter: > > > > The purpose of this series is to define own memory descriptor for zsmalloc, > > instead of re-using various fields of struct page. This is a part of the > > effort to reduce the size of struct page to unsigned long and enable > > dynamic allocation of memory descriptors. > > > > While [1] outlines this ultimate objective, the current use of struct page > > is highly dependent on its definition, making it challenging to separately > > allocate memory descriptors. > > > > Therefore, this series introduces new descriptor for zsmalloc, called > > zsdesc. It overlays struct page for now, but will eventually be allocated > > independently in the future. And apart from dynamic allocation of descriptors, > > this is a nice cleanup. > > And the new descriptor doesn't bloat anything for zsmalloc meta size. Right? > Please specify it into the description. Right, that popped up [1] previously but I'm not sure if we had a definitive answer. https://lore.kernel.org/lkml/20230720071826.GE955071@google.com/