From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52056C4167B for ; Fri, 1 Dec 2023 20:15:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6C276B03EC; Fri, 1 Dec 2023 15:15:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF3406B03EE; Fri, 1 Dec 2023 15:15:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B927A6B03EF; Fri, 1 Dec 2023 15:15:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A42DE6B03EC for ; Fri, 1 Dec 2023 15:15:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 630E04032F for ; Fri, 1 Dec 2023 20:15:20 +0000 (UTC) X-FDA: 81519354000.30.7C846C6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 34DE7180028 for ; Fri, 1 Dec 2023 20:15:17 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of "SRS0=XJYy=HM=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=XJYy=HM=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701461718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTwMIv0YN01KwdFimGWzQtXz1FSaPBLeI4JwLDW8vzk=; b=s4My8S1otX/oj3ENdMGU0pB3jTIkgzAAjg6VXU6w9xp33+IB7C80n6vM7FpB65E66ERnV0 93LszRgK+86RHXt7T8EFriYZC0qtsE7Ej2/ymthLzDkni6LsBRyPI2kg6WNOeNiyq2p/Iw 3uDAxkf1Njc8f1FVd94Z7k52EXNwFSc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of "SRS0=XJYy=HM=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=XJYy=HM=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701461718; a=rsa-sha256; cv=none; b=FCAB2ZlyueMNFzIyH3l7EhJfwvjUEQHFbeMI8pUzCFi9FJP6A4N5G4WfwBcZAC2jEj2UWm C/UkDRNzs1Qm5PlhhfvPfbziMIBaK/7S9vIKI1470eDsGy0DYMYwlF4SNb1Vc3KdIX+av1 tC3Xo2DArJ5+2SmfSsbDB1tD8MltNok= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AFD0ACE1A9B; Fri, 1 Dec 2023 20:15:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53012C433C9; Fri, 1 Dec 2023 20:15:12 +0000 (UTC) Date: Fri, 1 Dec 2023 15:15:35 -0500 From: Steven Rostedt To: David Hildenbrand Cc: LKML , linux-mm@kvack.org, Vlastimil Babka , Andrew Morton Subject: Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely() Message-ID: <20231201151535.06c7aaaf@gandalf.local.home> In-Reply-To: <2d691c11-fa97-4f56-a4c4-c7f466c81d3a@redhat.com> References: <20231201145936.5ddfdb50@gandalf.local.home> <2d691c11-fa97-4f56-a4c4-c7f466c81d3a@redhat.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 34DE7180028 X-Stat-Signature: ewpf3u8wxtu134b6qczbba565oj8gywr X-HE-Tag: 1701461717-343445 X-HE-Meta: U2FsdGVkX19ykCv0QiHlYZKC9ndodC/BGCvB/jEasY/G9xMu0E9TE9SS0nfvp5pisfwTkphvoeSzlcIkaaSPlTrN13k8zUmWALu7edfVKipNb9gozD3V2A1Vj7R7ovjBpK5u9C3apvJ/GX0k2wKQaWBg52FxwcMsnTay+/uj3WLltFDiNRblUfQOO6iEUhgxNagZJbiKZUoS+WUFziXAc/YmKDR9+sFphxFP2oc4I4LQsayBML8cF+ekB9BwHrFjTY6YY607g2lgZihxMCD4N7nb9WYpqFg5TF8qDKIBHq/Ui4qmu1sJtjpGNJEOpi5xkBn4WeJb5p5+26SecLCv/9IBgYGmtJtqUIOWUd/GsVtPFK6TGbta7+YvX8kSDA1BZTqo69X5PYglZCa3m/PzYrtw8l5nv59+pNYH1REsCpY6aDBLbLQvwTXWWF+cFhOn5ROTIA/b1CDoc1BFKX8QtQcvFtyIl1qAVWkfdbwehMtapHlXFvG1tBcKkvWjpFdDJtUguG+R9TCh/Wn6TiE+0p9XJaFuC/xTlPkfqtqxchRJIwwIRGqrzDm7Ymv3D54NeFDzdNgTi5FIzxN70pgTgR5Wl0zibwaiDkIstS71/Y0oSAO+PRPZixxejZqn2M5/dHKm2EmynIuhuVfpqeNJYySBYIo9KqA4rT76Ok5QhRtb1pfIn2YqciHPBO8zCzWrTxiivZuHr2snButcDH6zR5Iw4xIQAjE3rtA/XXNuenutof6wPsVLqY8b80ekiZ71PUcilw86KELgrhU8DptO2GZXiX6oV2n5Y7ZuAOkfdaDC99VUGs81Ca4x1eiAEDFNG9krvIpRxPtVX4RaSpbFKZT3Vs2Sy8l1c48Ibvu3A9tq1rC8dsAKGCa7mRBok96VyvEmv99j+heafmifj/z11CeZxg9ZAzqfzNWN9ljtIGzl9+NF4gZyPIlIrQ6lA7Og1NLTFqwX670zqdDWRm5 PaLJ9jBi jax4aTq9+6jpSvJTICu3ozGDSep9PoYmw+nrU/Sao76dDcOPXybCoZgu+2ca5WpZVOn96uSB6SopU8wmLrkWmIplEDy0lsF0MqlQuZXyU5cBSUGhIL5J6/GcF1dc8f1gywLCS17hpHRxjC2akayoXSeZghBfk5qTaB6hUwqERdeA5sWF1OlLKuej1iTro7mR+Y9EJMVwdhyDvUciFMFWNb68SvYm3hqobmPGY7HGziH4+f62DYrpiBbutWib3fIrRfINdYA89ulmaobQ0cBuiT4aPoSLX2Wwah1riqhWxqSx4eCqZjKjoAg8oscxTdfysblhbv2UelN1lPfw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 1 Dec 2023 21:06:22 +0100 David Hildenbrand wrote: > But > > > Cc: stable@vger.kernel.org > > stable, really? Why? > > > Fixes:fb3d824d1a46c ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap()") > > and does it even fix a real bug? As a performance person, who measures likely and unlikely results (the ftrace ring buffer was sped up by over 50% with strategically placed likely/unlikely annotation). I find this to be a real bug, and something I would want backported to the kernels we maintain in ChromeOS (which uses upstream stable kernels). -- Steve