From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A16C4167B for ; Fri, 1 Dec 2023 17:50:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2F96B04C5; Fri, 1 Dec 2023 12:50:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5B986B04C6; Fri, 1 Dec 2023 12:50:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD5586B04C7; Fri, 1 Dec 2023 12:50:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 98C046B04C5 for ; Fri, 1 Dec 2023 12:50:12 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 76D74A02BE for ; Fri, 1 Dec 2023 17:50:12 +0000 (UTC) X-FDA: 81518988264.11.B818D38 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 9F165140004 for ; Fri, 1 Dec 2023 17:50:10 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V8dFBgRA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701453010; a=rsa-sha256; cv=none; b=m+n4g7RekzIeGyOgX9tPk08xtsvbzPquWP/JS82GuqWYeIrqhoFK9hetczxEH1KZUCp8VF Ousw2KTWCStnuB50hM9F9BjtqCPLeVHD8Qk5du9vOFj0qv70nerwnC3ITdojjs0IAupACU 2jWdNYGqiarvGp1suNae2Tu3hzsFlIk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V8dFBgRA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701453010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=61mRZHUPoSC+/V5UJ4QedAj4EUtFQC65cWS1GaV62vk=; b=LSBON6uDqHreTrmXP/xkB9L+owwq1NSFFoMY71UN8vIHcrXjINJV38TbQbwqA0TqPjPoSk AosyeP8ONw9kwgXQlGzt+VxTkG7l5IDMBHHV9iMxubON6qDTkCcgXAnx72AaRM26aSGqrx bFq7/r1aRwXrWD6ZJd7cwYXYCx0PSM8= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6cddc148285so2383877b3a.2 for ; Fri, 01 Dec 2023 09:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701453009; x=1702057809; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=61mRZHUPoSC+/V5UJ4QedAj4EUtFQC65cWS1GaV62vk=; b=V8dFBgRAdb4LQCPhhxJg9LsCv4tPzGGKI/OymTTVYtgfjkz3HeiLU4POpfKDucR8LT UG3ZjX0FXsq53qGQBtNTf7ifmGmZIff9+c6iWSSfhUk7mFeYaaSmH+DI/k7oTO8AI80t O45rPrROTuM5XWPrc70leGBMOSrhOOvDbd48A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701453009; x=1702057809; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=61mRZHUPoSC+/V5UJ4QedAj4EUtFQC65cWS1GaV62vk=; b=ferEJg4F78DOoKGCju1pchGLjIMgMLxjNn+MxHvXVvjWQ7oPvrgfX9zOvVRDemfKQs zU8xa+aF0ER2t7Z0Vz0/0QQZgAarlax8BWPqaizk1df74A3Ql5Fmx8mWpG6WU2s2mS4p woqewFzKkiWJlgTOCtVa+e6DBYL8B/0FMlDZaGJjjtKCM75h1nk1OZJxqtzuI8yWsc66 XCAQ8ywTF3VWW0yrNzBclTL3hUkAXryv55ST3v5wpAMVNejRWjmh57N9Z/WVROpzdvoY 4xZ/r4SmkGkldbs+cdbiNR/sCQ/Q+T+b96aSEVwDAKm5Jrd6fiWnqc1IyUkDbzXEF0le EZcg== X-Gm-Message-State: AOJu0YxcpBhs63X5OUQXF6EkHr66vu/ETK0SzsHAN5fpOLwg/LvYci22 STsBRrgCbxWD5Sz6fyYtLaw72w== X-Google-Smtp-Source: AGHT+IFyZfMEe3PmabCp9F5OxkYHT5tTq3uuvSeo+6Da+zmgcN0FNPX5uOuo9lQMGQ2bvVuB0z4EkA== X-Received: by 2002:a17:902:c944:b0:1cf:a2e7:f843 with SMTP id i4-20020a170902c94400b001cfa2e7f843mr34281143pla.23.1701453009544; Fri, 01 Dec 2023 09:50:09 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id h1-20020a170902f54100b001b3bf8001a9sm3615644plf.48.2023.12.01.09.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:50:08 -0800 (PST) Date: Fri, 1 Dec 2023 09:50:08 -0800 From: Kees Cook To: sxwjean@me.com Cc: vbabka@suse.cz, 42.hyeyoo@gmail.com, cl@linux.com, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, corbet@lwn.net, arnd@arndb.de, akpm@linux-foundation.org, gregkh@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH 3/3] mm/slub: correct the default value of slub_min_objects in doc Message-ID: <202312010948.63ACCAAE@keescook> References: <20231201031505.286117-1-sxwjean@me.com> <20231201031505.286117-4-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201031505.286117-4-sxwjean@me.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9F165140004 X-Stat-Signature: 7ar87i8ueujgd1gbdauhz5f51kw8spbt X-HE-Tag: 1701453010-397412 X-HE-Meta: U2FsdGVkX18C246TTBEXATpNjWuUrQXNhMD322895OgmQDio+FMOUxvTnyy4K7HQ9/Pp24TTJcr94x/ss/xsqZN+XGdVcsZ60U8WBo3NW5Xy3nfADn402V+8YSgEETKnjVI0Lm/bmo6XNCD43c8fJmzGRWnF+UkZBTODjECPJXXE0/USsX6iIDWhjHI2ybRB4U7GTiUv6OluN4pz5l6UyAVp7uqxdC5wnPJwpqOS2aQwFHIqOMgHp3iPSh7HCB+NBdJqZ6eRgp7cT5shKfyLcGruBCSZV/Jz659LZsc+KYJSaQG9VyMjoXjC4amXpqaZfJVK7Ywj7wT99w6K/Yj1ArM2uPsdiCAXRuR26S1iO3v3CxrSnbLuffJMD1wI8iqFW5v+QM9fSUOsuaKmJMrbVHvLgHy7BTCU6o8N9aJyv0hnStI3JwY+hSFPKKqBNiQrO5x5LD0flK/K5aT/ub6UpiotXhuTJMXK7MxAax4tKqA9OdcsjKN6oDHd8Au8fRHykRY+d4NNzrH69VpkF0AE1B4jpOljiezM/BZukKghEj3WS7HEUqVt9xRgK68ZwENBJXK//14uIhTj1IUWlQXlVqWYbwzJCZXr3WYeOPgLTgv9mtXkNywGlTDtiSIEPUNJYsUKhstjIIs7IrKEpGlgUhUkm7EcqSbXrRRzf2CRck5R/ZRjGRRjIhwJyRafJluZX2gilzhkqTR3VHTBh3lQLD6g0arct7w0yEuKn+ScafS8pX88zwyRRkf20lzDuXX7y3ubIjuafLF9emHKKhB57UoUvkd8eATZc41IhXmw1L60pXVGFtg9ad3TXLpQHPRh2wbqKhZ0qbChVewFrM6l/cN5avXmDAL849i3/KcIp0zoY6lXBrkjUTeJG/7CSQrhzQV2QlDXMJAdEZtvAxoxFVwA0AzWYIBE6L7q+ewYRIAeOhTa+Qsf/LMArNEh/lDlgx0R61nPcdR/+I5/tC8 8ezPdtv6 1E8OI2IFFCum6KMCUyShERHTpGlRibROBt1rNG0hajUayUockRXGNj6+EW/YjR5viN12QXlpI3obUhYzurn65VT/CK1YG/cbDnRZhfdjMvmitKK80cc2ULRLgZxMJ/21d+Z3Oumv4ieba5gKEHFIMohma5kh1jBtOIMDDmEuSF3XPECLZAK8Kmxh2lEEsbPRjunVoO12nFFYWyeiovdwq20QYPG4S9MCjQhCI1ZzVP+utdg5HC8zD5qJzasD1WR4nQo5Naq1WfMRhf7ZhNvonNZLd8wwwhWamHTCfahKvnrqWkjVhI57ubcsSelNVrRu4uVYPa97L3Jo7Xp34jHlA6GyZOOnN4PCq9pNwHi2WiFRGzPg7+s/yDduu8UHN5T0iFRokjvntMyLblGZJPyaI8iUWOMIFhK9/CE+dIxuibFsXhdav3RYsFM/ftFkvzJAUmnGTU0dN63jv+fM9+9BRFfNLjQmRkTvpx/fA8vLrFpVmYTNkFuuBz6tue/tXXJZF54J20weJ+l8Wyge+HXpvB41AjFM7buot1ik+ikiSzcQB6Bs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 01, 2023 at 11:15:05AM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > There is no a value assigned to slub_min_objects by default, it awlays ^^^^^^ > is 0 that is intailized by compiler if no assigned value by command line. ^^^^^^^^^^ > min_objects is calculated based on proccessor numbers in ^^^^^^^^^^ > calculate_order(). For more details, see commit 9b2cd506e5f2 ("slub: > Calculate min_objects based on number of processors.") nit: multiple spelling mistakes here. Please double-check commit logs with a spell checker. :) > > Signed-off-by: Xiongwei Song > --- > Documentation/mm/slub.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst > index be75971532f5..1f4399581449 100644 > --- a/Documentation/mm/slub.rst > +++ b/Documentation/mm/slub.rst > @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is > governed by the order of the allocation for each slab. The allocations > can be influenced by kernel parameters: > > -.. slub_min_objects=x (default 4) > +.. slub_min_objects=x (default 0) > .. slub_min_order=x (default 0) > .. slub_max_order=x (default 3 (PAGE_ALLOC_COSTLY_ORDER)) But otherwise, yes, this change matches what the code does. -Kees -- Kees Cook