From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F73C4167B for ; Fri, 1 Dec 2023 17:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83DD96B016E; Fri, 1 Dec 2023 12:47:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ED886B04C4; Fri, 1 Dec 2023 12:47:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DCA16B04C5; Fri, 1 Dec 2023 12:47:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F2516B016E for ; Fri, 1 Dec 2023 12:47:47 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 354491C038C for ; Fri, 1 Dec 2023 17:47:47 +0000 (UTC) X-FDA: 81518982174.25.F6082AE Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 456A7180008 for ; Fri, 1 Dec 2023 17:47:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=R515ShfH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701452865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gCNVYgwpLFteuDrNzIDZLAqe84pArYWACQkufwvTL5U=; b=tsq7HUZkYGmRKdQzH/tk+fNoAAtClusJF6o6h/xI93Wu1R/TKPdLoFd8uH5YYZk+MZhe5R wsHFvmAOLfuNr2vniauXQm1yolekSV8NExF4NXHJJaLcBfWEr5DyJtEPBtMzxJO5kkqo40 Fujvo1LcLek02ZyYrH8jW8YmZbBzHw0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=R515ShfH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701452865; a=rsa-sha256; cv=none; b=l89Rb6xlifJiI1pgLVwQ5l7ZGsnnZj54TfLnz6Hm0xWEzN/5G49gtTb68H1Kbl0adBsjZK JDoVIfUO2BHbKe3osfN0E/jwHP3b1c7UAF7g19JF9k0yoSJ5UPegUsRVfzNXxKWOiyzToP uT8G48ukXsPx+F3pSAQWpM6ACvAhzqM= Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5bd5809f63aso597505a12.3 for ; Fri, 01 Dec 2023 09:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701452864; x=1702057664; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gCNVYgwpLFteuDrNzIDZLAqe84pArYWACQkufwvTL5U=; b=R515ShfHuJ8c4oEMHofv3MuFMcsE122UYhCTBDvWr0/3ycQTk68OslX/LVXjB3yDjv TtCFPGAnIX5Teh15QR+7Xa/ZbL/vGDPPjSo7rt0+9pagS8ZdXRvWBwIRFWLCkXZqNZ7U uBcNL3n8mtwDXIH6llZFGQJQxH+0aAt+QjYcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701452864; x=1702057664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gCNVYgwpLFteuDrNzIDZLAqe84pArYWACQkufwvTL5U=; b=RCc73V1JN6U8xrPXwe9hjxe/h8D3qY2wl4gNpZoD3YheM/jCqbheH7Fkbknox+cX0W anXl44d4zAsfyYhNEcvvPP3FvlGEKOTqZqDPCFQdr1WejouP9fryBQ2lCKVFN34MLkk7 XCO509Z3HJPESI2pmb6qB5LHanSFgYm6UaS3QJ0RVhsTGiwzeVHORNZCWvOZJREL5Bww glrk/hro2l/NJ6k61wpHaJZWUQnIJ6gwjRBEtJNr0TYlXcFpz4Wx9PFR6NwJAx0Gzid1 r8xM+pqcH0/P6Rtga6ZFryMm8LdIzSyaeKcrd2997C1zDOlNKo97DzNMsiBPJg1sttfn 1Hww== X-Gm-Message-State: AOJu0Yx5Pgt4a6wKlqJQEM5MAfkQ80xLBRG/O4PmOvfxsCTUA797quyl ly3CAYqFlPQIbyYuQ5uuXoGa6Q== X-Google-Smtp-Source: AGHT+IHsxxKzBrAkmN72uyMXEJDAqDR+ulUeRgl6PfoYNKg3RuRmpeIq7Urzdpn3+Vl7k98IzwGuOw== X-Received: by 2002:a17:90a:1a5d:b0:281:da1:4b96 with SMTP id 29-20020a17090a1a5d00b002810da14b96mr22934593pjl.22.1701452864074; Fri, 01 Dec 2023 09:47:44 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 21-20020a17090a01d500b002802a080d1dsm1661658pjd.16.2023.12.01.09.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:47:43 -0800 (PST) Date: Fri, 1 Dec 2023 09:47:42 -0800 From: Kees Cook To: sxwjean@me.com Cc: vbabka@suse.cz, 42.hyeyoo@gmail.com, cl@linux.com, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, corbet@lwn.net, arnd@arndb.de, akpm@linux-foundation.org, gregkh@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" Message-ID: <202312010945.7C5DB1FBB@keescook> References: <20231201031505.286117-1-sxwjean@me.com> <20231201031505.286117-3-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201031505.286117-3-sxwjean@me.com> X-Rspamd-Queue-Id: 456A7180008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s8ed3b5w9b658ejy9k9fxgersfmuaai6 X-HE-Tag: 1701452865-228083 X-HE-Meta: U2FsdGVkX1+DincFDYHTRxRW6OA4cf8ewAjYvXffXVABQdXa3hi50b9uu1S6ydhIizRGyxZttVEAEkIA6HiMHKF2vwte1XIymvf8QcfbWf1kGg1YlCyalJ0kgY7+N4hE0GCiQf81vW5FQypTIQ1K7a1qZ09f0fvLAzBxypxKfnmdLmIwcgMZ8n8KcEWSUJTEFupc35ELDKtdTVcMMFPihgrRK33wVZWglUPlITsD3P9+ef+z9hcEYInH//94zA1O7LXOCfy0TrsqTcbogtrUEWuJNb3ACBevLsMekV0x/yEsCOtdVWfKKomIBBUcgwpKYX+5DFy/OsH3zX/Suq+1H6WlAQMSS9zd3qKOmqD9FMp8/u6AvZVyGOC8mhDa328m2BnchFQUqvJfTcaqOrUbddNgu77qinOtvdG9jbSkkRyCvWW8q8p3UGwYwPCtPqUc9duFjZ7nzfxXE33WHY3DEKWl9sfrLgMneUvBVGdmXF8LJc+gZh5zWBu3KalbYPqirydBQ9nksr1LBatkn2hjD3JzwvQEiTkmwWw6uUzd/dfL/GDe6Btc1Z3MHZWCo1I27FarLpvTtfZ7+zCzb9k3LrSyfMogK5WPuVLXLCCWIaNEtP9Vl7PTSTWsX50oSmCVlrb3+Kw7LF6nk7khNIP0w2Ixvh5U7PPLRSNqLrJUC/QwDVuI7FQjI8uxvaPTcGYAqq1p5AMnHlMxnnerWZoNlpciNpApTWFix8QAO5zTaJYXB3keqDsPNKX1TuQk4OhCtxiUYc2xnmLNqC+CSqxnZzViEgLzomEDoecMf0U1cLToOB1bNzETgiwrJAT4O1WjiMIbIuiJBI6dp7V+Ki3Ofvu+VGiOR4xyMaw67upAWt8tI/nl5jVDliJQa+kLoo3TQlXk6WEuvO3ZL3tWFEfr3m7xS05iCYCYkF+iTI9CDLwrQ4csL+EF0Gl13SBXMwYm1zTj6f2TQB3qKymKPxg BXXP2xby STdIVlNYUyO/cshd78oopqmgOCSoYgBUVPI5AaMo5T/0rcppHmRtESSmgAIClVn4kMcbdUgDMB5+UGnzEvl9wuSZvExHcl9+MYNIa4W7SI6YM9FXfIHoURSTK3M5tQrj0dLzWEIDbQpSI1wAfzl/sadtgeijhktLE894k4DpEbsddKQOybEGx63Uv1hGoMYji69WO0o97j4tnIfhYiFaAGrxJnT+tXlPK6Fs9I73Zdy2Iy+Apfr4X7juL/USb8XYtTyPCyyhhSiabSY0dBGX8lJWe9ii0tyDoNkBuXQUIslUZ3JOsfLSbelbl1SXB2dN4MXKdixdBvR02Yxx9KH3P7yET6UFtqrY9ODidMxiDQikYOMKRIHF7EXnT5Nk0th9DJpbk2Eq1Pg8aXz/cMBcHiqSrveNhjFNyTqrYt0Ti97DIKL5Jpr7dYqkyOo45X3XZjbMwDHLkMzOwM96TLttmEl0hon1gvqAFqrR36ts8VsBsWdhWsfIYIgoiGuHnZGLbv2UVbtBWZk8LTKI4hNFLu4Jb4wjNBxyzibF/VuJG49znqTUHjdkMrFoTsTh83i3fDPrFhxMq8P4jfNhr765YDUdMSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > Since the SLAB allocator has been removed, so we need to clean up the > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for > long-term rather than "slub/SLUB". Hence, we should use "slab_$param" > as the primary prefix, which is pointed out by Vlastimil Babka. For more > information please see [1]. > > This patch is changing the following slab parameters > - slub_max_order > - slub_min_order > - slub_min_objects > - slub_debug > to > - slab_max_order > - slab_min_order > - slab_min_objects > - slab_debug > as the primary slab parameters in > Documentation/admin-guide/kernel-parameters.txt and source, and rename all > setup functions of them too. Meanwhile, "slub_$params" can also be passed > by command line, which is to keep backward compatibility. Also mark all > "slub_$params" as legacy. *If* we do this, I think the old names need to be recognized, perhaps with a boot pr_warn() about their deprecation/renaming for several releases (likely across LTSes). I think it's not a good idea to wholesale rename these with no warning. That's going to cause a lot of surprises and broken userspace... -- Kees Cook