From: Kees Cook <keescook@chromium.org>
To: sxwjean@me.com
Cc: vbabka@suse.cz, 42.hyeyoo@gmail.com, cl@linux.com,
linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, corbet@lwn.net,
arnd@arndb.de, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xiongwei Song <xiongwei.song@windriver.com>
Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param"
Date: Fri, 1 Dec 2023 09:47:42 -0800 [thread overview]
Message-ID: <202312010945.7C5DB1FBB@keescook> (raw)
In-Reply-To: <20231201031505.286117-3-sxwjean@me.com>
On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@me.com wrote:
> From: Xiongwei Song <xiongwei.song@windriver.com>
>
> Since the SLAB allocator has been removed, so we need to clean up the
> sl[au]b_$params. However, the "slab/SLAB" terms should be keep for
> long-term rather than "slub/SLUB". Hence, we should use "slab_$param"
> as the primary prefix, which is pointed out by Vlastimil Babka. For more
> information please see [1].
>
> This patch is changing the following slab parameters
> - slub_max_order
> - slub_min_order
> - slub_min_objects
> - slub_debug
> to
> - slab_max_order
> - slab_min_order
> - slab_min_objects
> - slab_debug
> as the primary slab parameters in
> Documentation/admin-guide/kernel-parameters.txt and source, and rename all
> setup functions of them too. Meanwhile, "slub_$params" can also be passed
> by command line, which is to keep backward compatibility. Also mark all
> "slub_$params" as legacy.
*If* we do this, I think the old names need to be recognized, perhaps
with a boot pr_warn() about their deprecation/renaming for several
releases (likely across LTSes). I think it's not a good idea to
wholesale rename these with no warning. That's going to cause a lot of
surprises and broken userspace...
--
Kees Cook
next prev parent reply other threads:[~2023-12-01 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 3:15 [PATCH 0/3] supplyment of slab allocator removal sxwjean
2023-12-01 3:15 ` [PATCH 1/3] Documentation: kernel-parameters: remove noaliencache sxwjean
2023-12-01 17:45 ` Kees Cook
2023-12-01 3:15 ` [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" sxwjean
2023-12-01 17:47 ` Kees Cook [this message]
2023-12-02 4:23 ` Song, Xiongwei
2023-12-02 18:12 ` Vlastimil Babka
2023-12-02 21:30 ` Kees Cook
2023-12-06 14:59 ` Vlastimil Babka
2023-12-01 3:15 ` [PATCH 3/3] mm/slub: correct the default value of slub_min_objects in doc sxwjean
2023-12-01 17:50 ` Kees Cook
2023-12-02 4:22 ` Song, Xiongwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312010945.7C5DB1FBB@keescook \
--to=keescook@chromium.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sxwjean@me.com \
--cc=vbabka@suse.cz \
--cc=xiongwei.song@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox