From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4574C4167B for ; Thu, 30 Nov 2023 19:49:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 460C26B047E; Thu, 30 Nov 2023 14:49:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 411576B047F; Thu, 30 Nov 2023 14:49:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B2626B0480; Thu, 30 Nov 2023 14:49:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1ADA26B047E for ; Thu, 30 Nov 2023 14:49:18 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E6EAF160240 for ; Thu, 30 Nov 2023 19:49:17 +0000 (UTC) X-FDA: 81515659554.30.D60C43A Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 9FE1C14001A for ; Thu, 30 Nov 2023 19:49:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=snWeGjGK; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701373756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MBPZtr1NEPnHIJYCcwUX8aLQYfzJui4bNFBqHRT6Zjk=; b=TQGp/Saz7IzLKb6eIBlhInpdHtKzpgHqAoQaYweEmklh7C2ZWYtugTY8d4s+RtRJm0L+8h NWBVdx3kyFP0VBOjkNPvejWwNDxlVu5dGChpS7eNkMR3aGPxNUdHVOQRBwxSfAc0fV4+eS sAcNyOoSs1i6ijaUDMz1IrPsNZ/vR8I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701373756; a=rsa-sha256; cv=none; b=GfeJLBlBQcGzqjla1nXNJNEsLJSGQtrQol505/5azLalJ+evZTYWMxD+Yr5S8jS9o7I5aE 5+AgaSIs+LE88vSiijJATz7JsYgEvOPAyVsgSkj0+eR5MzL1Tz5rZem6AMfIddg6xfyDQ9 KcSqhzDy4QPHZqQ5xMptkqFRK1hGCjc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=snWeGjGK; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7c50e2c40b3so438209241.3 for ; Thu, 30 Nov 2023 11:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1701373754; x=1701978554; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MBPZtr1NEPnHIJYCcwUX8aLQYfzJui4bNFBqHRT6Zjk=; b=snWeGjGKDdFsH2CDKnzEDZ/mn6RUOmfxv4VzgDWIOx088ZkW/2GR26KuaCGu0BJ1YR 2qmnbuWo9yrt6WLlH/yZr68Dt07adouJBeIhaAXbZBUA3aKWDWdyRHqYz0amsN+yKupz JzTkikxkero6GCJ1PKQnN9O3PRztenN4IFsXNL1gNNvGgbvKT+QwW+iBwFKhA2QVa+Zq Cyk1k4bu3VJUK/FTdU3h4s4yG9Kqq81iQ0mw39BJB9i3MvMUUYkhbtL+fgMJW/bwr9u6 KjP7kIv/tTSgVBB0Ftkf9MPO01wxrC8TYICFnwOKwp9jUIdSZYvTiyq/8tVsKh4SufUg HuoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701373754; x=1701978554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MBPZtr1NEPnHIJYCcwUX8aLQYfzJui4bNFBqHRT6Zjk=; b=AF+b4exWTbCSk0J7c+xO/EM5puh68edgVvfPy1LDyLKAI+yKxZaabpwvtrZCGHodsJ HFU3jXXP9Kqt9XBDCVQeaU0w8iU5+KDWg2Bi4+uVsh5KLvT0AwFAR3Fp2L5BAqPDXNEr x7DugU6ewFAukTAO6xEhCaCsTqdq8XpBDlBgewXpvyyNxqV9DGpKvqaYX4Jb6W3coH1o 6cIEAY8zFv8F3JuEeokHx6Ad7GOiDmv/i+PAcHiWY5pRBszGuES3JOIFbSjDhXjXQ+M1 uDCQMuyJ0XPqCIghQWcB9TkA1ft+h3xyOplXOWS9gmlPjjGrwcz3C7pLHDKmNZ5JR0B0 6S7Q== X-Gm-Message-State: AOJu0YwsFzeMl0vK1xWL0MF/kvlPcxu6AgAEghD+1mdhRHrkkirVfuLN eVjKwdr3KEDw959N9bQRAbM26A== X-Google-Smtp-Source: AGHT+IFRrBf/434jvWkBCn1mtymuLO7b9BdcyFp+fYScokRpyqxmVUVa9zUpxgkzX5uz+AKWhiW9XQ== X-Received: by 2002:a67:f10e:0:b0:464:56ed:bfc4 with SMTP id n14-20020a67f10e000000b0046456edbfc4mr3649700vsk.31.1701373754497; Thu, 30 Nov 2023 11:49:14 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id k8-20020a0cf588000000b0067a57125f21sm783757qvm.52.2023.11.30.11.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:49:13 -0800 (PST) Date: Thu, 30 Nov 2023 14:49:12 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Dan Schatzberg , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Huang Ying , Kefeng Wang , Peter Xu , "Vishal Moola (Oracle)" , Yue Zhao , Hugh Dickins Subject: Re: [PATCH 0/1] Add swappiness argument to memory.reclaim Message-ID: <20231130194912.GB543908@cmpxchg.org> References: <20231130153658.527556-1-schatzberg.dan@gmail.com> <20231130184424.7sbez2ukaylerhy6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130184424.7sbez2ukaylerhy6@google.com> X-Rspamd-Queue-Id: 9FE1C14001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1fefgrixrd9dxskbxy6dw4gu84k17fgc X-HE-Tag: 1701373755-432412 X-HE-Meta: U2FsdGVkX1/7NAasKpH1XJFv/qaoEd2AkKuQGC8tYe7DKng8I9qn1WsMZ78OpBTx9sSAlAVDvcBYgKq5TaAAZU3tbXzKawstrJt+3Z2MSTHCFYE7bMT0NSthSymn26I6bieqWho1c3jdn58dpzQZCd8BzbNx2YJJddFLWFLErRDSgrOzV6vSP9I8OwG2wNfGyXlnsw8orUS5KHwOwtUfv1J1tHbFQSSKSjXnop06HJ4MD0N0mr6WHLfyRfkKnD8XXeMYvhSlT7OlTk5gzqoR8dB9Ik19DbmSnEAnqmHAogW8di9XdSvSQnSib5U0Bhz/zUx164ArO47x1ceSO5ZaGxs8ZA1Ii4Vjt0YLQi81Rg0npN8EbUqfadqq0onvChlAYijNDMSYPDIoqSX3sf3z42e356VYqB8J+63Chhdui9++unGVCuCCvrdJfSj7150WKMGIwUEwPwmqMkBk0phJrXbKzi9i7e7UwP6gcpoQb3VgRlLRImjdSAuiOOKEJZF6H0eJBAm4ohghdXNI6XZ0pqDLMft27N+egptBUHZfYuCsXKQyXuXYvgRWhB0syN9IcvlARZolDckY/RckawqWoKYf6gAbgvlsFczt43biutNdiCqk3fGU3+/x5O6n1CjX5cmYvmQe+wGO8c2HCgIs37IwQ0HCAUYwUc1iQPeTIeny4nY9utmXS0Qx5AHSAjPEShxB37hE6LPL3P5nVJx9iqE1vAfmCljwkL8ZoYrAsnGjpqqTptadnwVWR+DS0wlgPR75ksmlI7MdwOw3+2l2QI2LNlM2XFDYodjNGdOtruHuBco9v2NRQgzHB5/zu/+3vzrMDHwQINQEqRCyQ01GxBs7p04v9CRxuKgtDUa6rQRtsBd/3VXeC1DTiM0ZgJGIv/W1hOUfB05y7Zfs/CgT/pD24HSXhY0EEVbtpzqnq32bhZD1AlN/ysL0OyB3hgfZMjKyeUP6FNtU/yeWfSw 5PCtHeBE pC/D3Qo/yWNt34JDpEEaALz6cZtLjz4bAHJhOpUaUWdqbLZa6HteG5ujRxSl9TQ7806r9w372jWf6Q1MMugjP/TF9GlKM9U/OVFHtMXWiHDHR7ca5EQyaPvIjvewHbwCi92r8xpeUCcgf7IBG9jDsSjnNxc79P3IrFPve15lqc9TM0jyTRP4onNNnyPXe+u2czniUjlDpAOx2husACzILK8DKedFw6QADUpEL6GaiWnooCXcPF5hV2nEKDV4REhA7ba+YcJjZ1wPbGNKJARStbH8CUa/pZ6bmCDWJak0CrrQ+8dtO51sshNMSuqW5l68HhUkei90DyrLVSsGJ6ekjtqaCMOKaDfRuhhEt588mlMLNn3Gt+tM7oVW4qLx9C1XMciu1oXhDYO1mh80xI/1tv6w4yO5GTnzFSg3sTjaBhM21AL60LdzSedEupu+ETYsZQTkeaQwyKLQi5Jo4fub1GYbVwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 06:44:24PM +0000, Shakeel Butt wrote: > On Thu, Nov 30, 2023 at 07:36:53AM -0800, Dan Schatzberg wrote: > > (Sorry for the resend - forgot to cc the mailing lists) > > > > This patch proposes augmenting the memory.reclaim interface with a > > swappiness= argument that overrides the swappiness value for that instance > > of proactive reclaim. > > > > Userspace proactive reclaimers use the memory.reclaim interface to trigger > > reclaim. The memory.reclaim interface does not allow for any way to effect the > > balance of file vs anon during proactive reclaim. The only approach is to adjust > > the vm.swappiness setting. However, there are a few reasons we look to control > > the balance of file vs anon during proactive reclaim, separately from reactive > > reclaim: > > > > * Swapout should be limited to manage SSD write endurance. In near-OOM > > Is this about swapout to SSD only? > > > situations we are fine with lots of swap-out to avoid OOMs. As these are > > typically rare events, they have relatively little impact on write endurance. > > However, proactive reclaim runs continuously and so its impact on SSD write > > endurance is more significant. Therefore it is desireable to control swap-out > > for proactive reclaim separately from reactive reclaim > > This is understandable but swapout to zswap should be fine, right? > (Sorry I am not following the discussion on zswap patches from Nhat. Is > the answer there?) Memory compression alone would be fine, yes. However, we don't use zswap in all cgroups. Lower priority things are forced directly to disk. Some workloads compress poorly and also go directly to disk for better memory efficiency. On such cgroups, it's important for proactive reclaim to manage swap rates to avoid burning out the flash. Note that zswap also does SSD writes during writeback. I know this doesn't apply to Google because of the ghost files, but we have SSD swapfiles behind zswap. And this part will become more relevant with Nhat's enhanced writeback patches.