From: Liang Chen <liangchen.linux@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
linyunsheng@huawei.com
Cc: netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com,
liangchen.linux@gmail.com
Subject: [PATCH net-next v6 3/4] skbuff: Add a function to check if a page belongs to page_pool
Date: Thu, 30 Nov 2023 19:56:10 +0800 [thread overview]
Message-ID: <20231130115611.6632-4-liangchen.linux@gmail.com> (raw)
In-Reply-To: <20231130115611.6632-1-liangchen.linux@gmail.com>
Wrap code for checking if a page is a page_pool page into a
function for better readability and ease of reuse.
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
---
net/core/skbuff.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b157efea5dea..31e57c29c556 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -890,6 +890,11 @@ static void skb_clone_fraglist(struct sk_buff *skb)
skb_get(list);
}
+static bool skb_frag_is_pp_page(struct page *page)
+{
+ return (page->pp_magic & ~0x3UL) == PP_SIGNATURE;
+}
+
#if IS_ENABLED(CONFIG_PAGE_POOL)
bool napi_pp_put_page(struct page *page, bool napi_safe)
{
@@ -905,7 +910,7 @@ bool napi_pp_put_page(struct page *page, bool napi_safe)
* and page_is_pfmemalloc() is checked in __page_pool_put_page()
* to avoid recycling the pfmemalloc page.
*/
- if (unlikely((page->pp_magic & ~0x3UL) != PP_SIGNATURE))
+ if (unlikely(!skb_frag_is_pp_page(page)))
return false;
pp = page->pp;
--
2.31.1
next prev parent reply other threads:[~2023-11-30 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 11:56 [PATCH net-next v6 0/4] skbuff: Optimize SKB coalescing for page pool Liang Chen
2023-11-30 11:56 ` [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref_count Liang Chen
2023-12-01 9:59 ` Ilias Apalodimas
2023-12-01 10:10 ` Ilias Apalodimas
2023-12-02 2:19 ` Jakub Kicinski
2023-12-04 2:39 ` Liang Chen
2023-11-30 11:56 ` [PATCH net-next v6 2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment Liang Chen
2023-11-30 11:56 ` Liang Chen [this message]
2023-12-01 10:07 ` [PATCH net-next v6 3/4] skbuff: Add a function to check if a page belongs to page_pool Ilias Apalodimas
2023-12-01 10:22 ` Ilias Apalodimas
2023-12-04 2:40 ` Liang Chen
2023-12-05 11:02 ` Ilias Apalodimas
2023-11-30 11:56 ` [PATCH net-next v6 4/4] skbuff: Optimization of SKB coalescing for page pool Liang Chen
2023-12-01 10:34 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130115611.6632-4-liangchen.linux@gmail.com \
--to=liangchen.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox