From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F47C4167B for ; Thu, 30 Nov 2023 03:21:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A78A58D002F; Wed, 29 Nov 2023 22:21:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A296E8D0001; Wed, 29 Nov 2023 22:21:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1B98D002F; Wed, 29 Nov 2023 22:21:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B4AA8D0001 for ; Wed, 29 Nov 2023 22:21:58 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 52F814072C for ; Thu, 30 Nov 2023 03:21:58 +0000 (UTC) X-FDA: 81513171516.29.26F37B4 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf26.hostedemail.com (Postfix) with ESMTP id 5223614000A for ; Thu, 30 Nov 2023 03:21:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fUgDpF8g; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701314516; a=rsa-sha256; cv=none; b=JOeAQ4uIxjIZjAc8Yq3o1zRCfmF5MT93FnhReMTFpjAuONm3tJKM6sjCe4TeUAvViLSk1g kYE5HUPaGqzpgukdANvkRrGhkCQU/tUx+5XF3QecvRM7XOyRyb9LDyXRjvO18REW/JwQXY a8BIdcX33PEglUWkhTHfvSnUOA3i8lE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fUgDpF8g; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701314516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Czmn18gjTSfWVrvUGKkcFDp26hQvPKQD/bldcWkParM=; b=mUT4xZOb9hdnplwqUyg6W9zuG+2QP3fYAVCIeGWb97AXqHhhogFMrulmZnwhdFTGs/8Oni wLnAdGbZwu530qOnXSEwT1bzuigTy/Sf5gstrAwn+Kgw+rdGVJYNQ/S21XOBjhjxy4+FWL kOYmCf/klDRog7A4flkVPGh0zD5o7Ig= Date: Wed, 29 Nov 2023 22:21:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701314514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Czmn18gjTSfWVrvUGKkcFDp26hQvPKQD/bldcWkParM=; b=fUgDpF8gwjCohOrHWhracPL13JiJvWhq2tX5EVWyxGYN+FO8FaI/C6yOY97/y4c9Ud67QF aEUgxHzMtYe2uFDpNfPAzTG64JlQSDyrRri6UkXTfMdA2KOq3VZKcYgZt15rJTH+lMDYXO PymIfltyDoAY22RtOQMx8rzpIOLoaZE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Qi Zheng Cc: Michal Hocko , Roman Gushchin , Muchun Song , Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton , Dave Chinner Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: <20231130032149.ynap4ai47dj62fy3@moria.home.lan> References: <20231123212411.s6r5ekvkklvhwfra@moria.home.lan> <4caadff7-1df0-45cc-9d43-e616f9e4ddb3@bytedance.com> <20231125003009.tbaxuquny43uwei3@moria.home.lan> <76A1EE85-B62C-49B3-889C-80F9A2A88040@linux.dev> <20231128035345.5c7yc7jnautjpfoc@moria.home.lan> <20231129231147.7msiocerq7phxnyu@moria.home.lan> <04f63966-af72-43ef-a65c-ff927064a3e4@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f63966-af72-43ef-a65c-ff927064a3e4@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5223614000A X-Stat-Signature: ji6b3nfpx5m1yoj8p5y4qwsfmi7f6s4n X-HE-Tag: 1701314516-203991 X-HE-Meta: U2FsdGVkX19prg+b0auJ1C7S25TSvbl1558ParaY4ayT8SOBr75gJmct8n6jxu1D5QPePcPEWNa/0bRZuIeERjAThXMJPy9VM6QUVJTmGgls4H2JJLblhh5V5tK5QffK1Axjk4P1cTWGPlQeY0ywIo1+E74ppoqBlA/DmbHDS7zgtm4+n0xLSoPr+DNvv3WTUECH+WTNABbNVlNtaHt8Qdycxv73n7eTiNI84eQjy0bZtPwPUnrxbUuMSC5l6cVvAABks+fxcdnhHyIYWNeYon3Z06s6ulDKmu44Yu5vm/fONWpfQIsY9xuCRPBaLMyRSzwRkFIuOrT7lyCAEQUIFiXiDsoqFE7Eaoyf6B53OoNUEzclnjxjj7MfD43uTy0fTl2NihJQxhbkWLa/H71RY5kRZPe03zCXlhZglI5ue7eWaMGD7+KbQL0BR6xgSJJ/tatS0IqtYE9r63Wtcr9IjZ9U9+fSWq2fYRW1dt8QuLmjM4gYFKIABc3VJ3CvaDLszXp3cCcaGzIljkT0pTZ6M/vyQiofGoqIoEDhsuJwlKMVm3WJkttU5EwH/LrBY8c++OvpjSb9c2amMIC65xpbpEk0aa2t7aAB8uf/TiODTGkLSsqtcdNNpHmLmavhWEBURu9lCnXE/MDQXoq0iiwV0DgQ0vvijx9jlnfsq6LzIthkMfRzlaGBXKQAmclKgA/PXFtSRL/kOtRx8b66maJbMKGOEVCxU7aA0umUGte2ppwFCFszMu5N1xv31fJUjfyV10cQiZ9l5N58E19HiAclf8oI7b5tr4+623rM9ggGUes+jEORNo5PkwpUIdos5sLCbt0ACVC0W3vpv8hOxpq/ejwxX2qWUTAht0S1sO7szhhMv2P8R6owH5YDTOglIZEgILTDJh0s+XUOKCUcugP8eVJX91oPqrVGr3RJmp4taIWNW+G3rLY4EK6kEukE1H3Rj7/CU6gjQz81IPKc2Oh kx5bqrEu NzLw1fos7wB9m+8iACJMCl3bIYKAP/5/8+VENn3oL7rJ9Do/9vVgYR1dxHdTifP9+jnqHCIPtyI/uNXBNHFWJCXEpjVCzIRbKasKWBCJi6xSFWdC5uiNIHRd5oEbwS3w4BnLGFENckZqkwhhYU2Cqg14t98xJD/ypY5pc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 11:09:42AM +0800, Qi Zheng wrote: > > > On 2023/11/30 07:11, Kent Overstreet wrote: > > On Wed, Nov 29, 2023 at 10:14:54AM +0100, Michal Hocko wrote: > > > On Tue 28-11-23 16:34:35, Roman Gushchin wrote: > > > > On Tue, Nov 28, 2023 at 02:23:36PM +0800, Qi Zheng wrote: > > > [...] > > > > > Now I think adding this method might not be a good idea. If we allow > > > > > shrinkers to report thier own private information, OOM logs may become > > > > > cluttered. Most people only care about some general information when > > > > > troubleshooting OOM problem, but not the private information of a > > > > > shrinker. > > > > > > > > I agree with that. > > > > > > > > It seems that the feature is mostly useful for kernel developers and it's easily > > > > achievable by attaching a bpf program to the oom handler. If it requires a bit > > > > of work on the bpf side, we can do that instead, but probably not. And this > > > > solution can potentially provide way more information in a more flexible way. > > > > > > > > So I'm not convinced it's a good idea to make the generic oom handling code > > > > more complicated and fragile for everybody, as well as making oom reports differ > > > > more between kernel versions and configurations. > > > > > > Completely agreed! From my many years of experience of oom reports > > > analysing from production systems I would conclude the following categories > > > - clear runaways (and/or memory leaks) > > > - userspace consumers - either shmem or anonymous memory > > > predominantly consumes the memory, swap is either depleted > > > or not configured. > > > OOM report is usually useful to pinpoint those as we > > > have required counters available > > > - kernel memory consumers - if we are lucky they are > > > using slab allocator and unreclaimable slab is a huge > > > part of the memory consumption. If this is a page > > > allocator user the oom repport only helps to deduce > > > the fact by looking at how much user + slab + page > > > table etc. form. But identifying the root cause is > > > close to impossible without something like page_owner > > > or a crash dump. > > > - misbehaving memory reclaim > > > - minority of issues and the oom report is usually > > > insufficient to drill down to the root cause. If the > > > problem is reproducible then collecting vmstat data > > > can give a much better clue. > > > - high number of slab reclaimable objects or free swap > > > are good indicators. Shrinkers data could be > > > potentially helpful in the slab case but I really have > > > hard time to remember any such situation. > > > On non-production systems the situation is quite different. I can see > > > how it could be very beneficial to add a very specific debugging data > > > for subsystem/shrinker which is developed and could cause the OOM. For > > > that purpose the proposed scheme is rather inflexible AFAICS. > > > > Considering that you're an MM guy, and that shrinkers are pretty much > > universally used by _filesystem_ people - I'm not sure your experience > > is the most relevant here? > > > > The general attitude I've been seeing in this thread has been one of > > dismissiveness towards filesystem people. Roman too; back when he was > > Oh, please don't say that, it seems like you are the only one causing > the fight. We deeply respect the opinions of file system developers, so > I invited Dave to this thread from the beginning. And you didn’t CC > linux-fsdevel@vger.kernel.org yourself. > > > working on his shrinker debug feature I reached out to him, explained > > that I was working on my own, and asked about collaborating - got > > crickets in response... > > > > Hmm.. > > > > Besides that, I haven't seen anything what-so-ever out of you guys to > > make our lives easier, regarding OOM debugging, nor do you guys even > > seem interested in the needs and perspectives of the filesytem people. > > Roman, your feature didn't help one bit for OOM debuging - didn't even > > come with documentation or hints as to what it's for. > > > > BPF? Please. > > (Disclaimer, no intention to start a fight, here are some objective > views.) > > Why not? In addition to printk, there are many good debugging tools > worth trying, such as BPF related tools, drgn, etc. > > For non-bcachefs developers, who knows what those statistics mean? > > You can use BPF or drgn to traverse in advance to get the address of the > bcachefs shrinker structure, and then during OOM, find the bcachefs > private structure through the shrinker->private_data member, and then > dump the bcachefs private data. Is there any problem with this? No, BPF is not an excuse for improving our OOM/allocation failure reports. BPF/tracing are secondary tools; whenever we're logging information about a problem we should strive to log enough information to debug the issue. We've got junk in there we don't need: as mentioned before, there's no need to be dumping information on _every_ slab, we can pick the ones using the most memory and show those. Similarly for shrinkers, we're not going to be printing all of them - the patchset picks the top 10 by objects and prints those. Could probably be ~4, there's fewer shrinkers than slabs; also if we can get shrinkers to report on memory owned in bytes, that will help too with deciding what information is pertinent. That's not a huge amount of information to be dumping, and to make it easier to debug something that has historically been a major pain point. There's a lot more that could be done to make our OOM reports more readable and useful to non-mm developers. Unfortunately, any time changing the show_mem report the immediate reaction seems to be "but that will break my log parsing/change what I'm used to!"...