From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC899C4167B for ; Thu, 30 Nov 2023 00:03:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2186D6B03D1; Wed, 29 Nov 2023 19:03:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A1176B03DE; Wed, 29 Nov 2023 19:03:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01E946B03E6; Wed, 29 Nov 2023 19:03:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E83846B03D1 for ; Wed, 29 Nov 2023 19:03:03 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C5F70A06C7 for ; Thu, 30 Nov 2023 00:03:03 +0000 (UTC) X-FDA: 81512670246.10.57950AE Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf14.hostedemail.com (Postfix) with ESMTP id D8D48100014 for ; Thu, 30 Nov 2023 00:03:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Vx9A+q4c; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701302582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iqaBGyfV5ntKwlfmxQAMawFx8i861c6WUBXKE0OU9B4=; b=PJPdBXHhDspFfotek2O0exDJDDrnNV+CxfQyHl4rLGFO1cO6oYiT5QOvMMLsZfg50SLkKj kZfLO4KAoWU0V3irCMPxg0LLqq6jDhOkSuLQqyPmiMsNEIOPVsR/wxKn7DEsqnEJfWUIjF mlo3A9JhD0lgStEw9gZ+HK5uI0GAzuM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Vx9A+q4c; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701302582; a=rsa-sha256; cv=none; b=RmJ8WL773WPTuy9fhLbsZP8rQAGfTZAa96JtBwW+B9MXBoajGBp0xLo0KYijP5ShGiv1K+ DEi7au0CuVgtelU3xZ0mzaitieKv4Q7v6csmMP1kbq9iSxcFm7di8+Jcg0TLdHBU4bw3bK sZfk7XqZmzRiNlSZ+/EIRB81u5+ZwnY= Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1fa22332ca1so688398fac.1 for ; Wed, 29 Nov 2023 16:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701302581; x=1701907381; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iqaBGyfV5ntKwlfmxQAMawFx8i861c6WUBXKE0OU9B4=; b=Vx9A+q4cDMussiBtF9fnbRWQo7N1TWZ2RzJaXX3+c5bx1XllzMHv+wV4e6BaXhxPke h+Jz/89kNUV8y0d3n6D4UZj60dNVeQSYL66HDBwlP7swksPp5oIx0cVuwoBBu9oHgnvD KUyNoTJ048p49db5XFJaJ4S1jTjFaH3zeFC7NhPOqXbr4WB/G7sqduM4MI+LJaK+DHMV RfpM6MeF2C65rXfGHI5b6aqGBiNuRHm+OyOGflkr0ZxEn59+K+LGCx2k4WZ+DOJ9EZth aEqNoCzPd7qjGbwCW7z0Uer35FqLZdxqZkKqTKVK84h1w4FX0TU9ZFxALQbOk/zFR9ZZ 1jrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701302581; x=1701907381; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iqaBGyfV5ntKwlfmxQAMawFx8i861c6WUBXKE0OU9B4=; b=RUVrapr28d/Fn7/VhGaAtklFzEwP264IgyMFRFMN2B130aIq4O2mxImdSAe7frfeOq J7ish1bz5XTeudNcXGMsZxH+SrrT7GxaFsOqPqu0mTjnMKRCRXKxt2eQ5p5qVAbW7/WW +I2J9n0j8/LZBAFCYj9P0AXUleTM7YoWYyegLPOstUYg67NoiT/xtSMPRLpsszPjXHjn YilXG2Hv9l0XI0bMzICFFqhjYSH3GliPjmfRkFX1hdU4rEf7NToSnF2hWURH37WWA8L6 0LHu/xQxS8ceghiuzCrb77DmdK377lV/ZYpbDy2gsnaXJOgbgyzjiF+N1b3OY8hT+7wE CNLw== X-Gm-Message-State: AOJu0YzrmCOqWHCn5vQhHgAcMBgz0F0cD1TgAxUasHZzy1MjJLICY+dh YFTyl3HpLH2xF66Xx0H/n5B6RQ== X-Google-Smtp-Source: AGHT+IH9mJrgeBca3QDmdqlZSO64E6UWuuZZMjhMVoz9rZsKA5pWXiF1aXxzzo/4HFbYhkfRvbso7A== X-Received: by 2002:a05:6870:1603:b0:1f9:eb7e:6621 with SMTP id b3-20020a056870160300b001f9eb7e6621mr10166623oae.18.1701302580971; Wed, 29 Nov 2023 16:03:00 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id ry4-20020a056871208400b001efa3446d4esm3609159oab.43.2023.11.29.16.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 16:03:00 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r8UWB-005qQQ-Hz; Wed, 29 Nov 2023 20:02:59 -0400 Date: Wed, 29 Nov 2023 20:02:59 -0400 From: Jason Gunthorpe To: Pasha Tatashin Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Subject: Re: [PATCH 09/16] iommu/iommufd: use page allocation function provided by iommu-pages.h Message-ID: <20231130000259.GS1312390@ziepe.ca> References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128204938.1453583-10-pasha.tatashin@soleen.com> <20231128235254.GE1312390@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D8D48100014 X-Stat-Signature: 46zmg4x9xz4yji8k9fq381oscq6yz5yf X-HE-Tag: 1701302581-690866 X-HE-Meta: U2FsdGVkX18CYWFTHwghESx4OZ2Nc3Jvtm4QVzyXonQmMJ0hoM0aAp+AJyZid2rp3UW+NBmONy0ddNiZWdtcH4HmmHChmz1k7PWBDoaiyOp/z1qjb1NxcOkWN3I/LUoj4GS2hBtnoKQG0CJDegvCsQ3K7HFj/DT85OdO6mG3XGy6aOlzgnXtusxrNWVCtTcDkF6KOxfrV8bnY0TkZ1lXLjaNzlhf7p5MZ444W4xH7QDqp2mgk1HABrRjvWKvBeZGTS7EFqMBwdLnDR6Jbagf1YVLTedo4bPaMPgh6SaeQFrsEMKfr0tpj8jrFIsPUxiJ0JbpOXF31jSBfC9UV8m/lgG9ArnLiyYG9zs3Z4ojqhmEhrN4OkRIo1O+ktKzP7ge72WZt0dVSYcOwx72XeEAPebUg74sHca4HFy0DgOT9rX0TAlKOOz7ibJUAq7TLgrUo0n1cQMaHJzvKUY6CXOLd7bHx+4gLGtoMKk7Pe28Nx/cbTp1chb2tA+R3uCf499hTdL6Y084Ds7EVQ7OSM9zrfO2gaYbE3TUneTlp6xTBFqetJk/PmRxgeAGA5ARHtB7isuO8h+Ny1Kik3uVQajv1h1VHL4sAsvSrU/zvs+VyTNh67lrSmVikI62AqblFO3oi9lYLUCB/uUDb+tY9gwa1aA7QsWqAnMeWMcRI3da8LZ6G6AeSAbY+m08mm+NkBKzIiPDmJ4g3Bt1OnqriwULjBeeMFPbZziMPBs8pEPq6NOtVgUYyHeywvBLlL6sj74kzz05z6LwmfBw1uhRrYQmKXRS0jO/tf9zQchuBRWWC07JolJSk58vAZFkYTjc/v6Jv1lPyA3KBb4fdC10gj0OMIVQgMX30qV59OIR5ctwEEsMqKxhrZ7iQtOp2z4LZ/fl1+xheg3aRnrRY+O3AEBjmFbSaeX4jlDoPJXzio+pfbt7KFCHx7kcxrCtkMhktHpCPicMWd22pE56FHkf+Po OE4Bf4k3 3W21z/iIWXwfwCILuIQAgV673eQbw7NW7XNZNQWN+l4g1A4o9r5C6PT0vmp6Y4AjslPa3h1V/qXD8ZhLZiQBHhEzxr5IYvNti3Ut7i88pywitFfpamB5tjRf4xBaf3m5YV4FoMXStDpSpsDPSm4g1L5KkzC1g+z1TLH1elxFowcg9cGXmtfWwvbR5CZUlRu4lYic/gUW2RLmNIZKQ4rx/7/+LLWqKpVcI6lMXZzhVZTYHgCluzHD27pIL5yAcjGQYTjKAJwCZHi+71WZcf7v1MQA+8ROLsHNQn2XEey0qERTtaBo06Tjocew3np1O6mWOuG/ugrvCWxZlJ63oVMXRgQWBS1g4vUp8f5hV7zmT3F6rBRA5E61FZ3EBC1jGT7T8L4LLSgam6j4wB6JJG6Q3XYuUGGhyk2th4G68Kxh6I3tKWP0ITlnd13q/82TxPvtkfb9kSauMqPCXuwyBrJqtPheJFnVpIX7ehbqCwa9lnQErNyYUwUt0AhG2/sXZ5+9zVCG8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 04:59:43PM -0500, Pasha Tatashin wrote: > On Tue, Nov 28, 2023 at 6:52 PM Jason Gunthorpe wrote: > > > > On Tue, Nov 28, 2023 at 08:49:31PM +0000, Pasha Tatashin wrote: > > > Convert iommu/iommufd/* files to use the new page allocation functions > > > provided in iommu-pages.h. > > > > > > Signed-off-by: Pasha Tatashin > > > --- > > > drivers/iommu/iommufd/iova_bitmap.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > This is a short term allocation, it should not be counted, that is why > > it is already not using GFP_KERNEL_ACCOUNT. > > I made this change for completeness. I changed all calls to > get_free_page/alloc_page etc under driver/iommu to use the > iommu_alloc_* variants, this also helps future developers in this area > to use the right allocation functions. > The accounting is implemented using cheap per-cpu counters, so should > not affect the performance, I think it is OK to keep them here. Except it is a mis use of an API that should only be used for page table memory :( Jason