From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2584EC07CB1 for ; Wed, 29 Nov 2023 15:17:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96C9D6B039F; Wed, 29 Nov 2023 10:17:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4DC6B03BB; Wed, 29 Nov 2023 10:17:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796C16B03BF; Wed, 29 Nov 2023 10:17:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63DB56B039F for ; Wed, 29 Nov 2023 10:17:30 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2D1AFC0532 for ; Wed, 29 Nov 2023 15:17:30 +0000 (UTC) X-FDA: 81511345860.19.37A0864 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 1656D4001D for ; Wed, 29 Nov 2023 15:17:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=WPF2xZ3y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701271048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ki5eAeZpOcI54YbTPSCFwp5UJ2eI9c3pK5uL2lEEtZM=; b=eM2RKi0XAobOXetPQt1JhtIwn8hgkdrncA58kMb0yG2F2XYzhqV8Z+2RvzcxLKP7t+EqZI 7OYWmb2+CZZ9z7W/5zi9hmnubhioeN6DCsqv5hqsVJj5EfaJ4Dnz421/rNMZV30a+v7RRj 8Zd+8l0rTQwRVSR0Tr5lLw5ieiZ57OM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=WPF2xZ3y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701271048; a=rsa-sha256; cv=none; b=tPXe6fZTIN6K3dinq9ixfHoz8A9DKO0rz8HA/d1e+YLY6IW5MZCTQyhEp938Ga3aqbKCvy IsdGsao+V6WTx/RT5VL8M67MzF6RLiH6aDObgil3AZkkfCz3qMfxs6hUXl7kN4c1NsipiB KLRXW1WdSVrSvIhHTKVu6vkEAROCDM8= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-41cd4cc515fso37925651cf.1 for ; Wed, 29 Nov 2023 07:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1701271047; x=1701875847; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ki5eAeZpOcI54YbTPSCFwp5UJ2eI9c3pK5uL2lEEtZM=; b=WPF2xZ3ya+n+q/r6Dkl+jAGJOITKIrzFo2vYt38cy7QgRObUTsbnPQQMM+ghK1REUz muCuV1Ks3+xmBWUPZi66R1LFC6HDvefohSGjmvtY1zLjDBFHtCOhg4H5wMsWjMkh5WCL CCYjAlEODEmkJGIKy6EoFMjsjDT/usuOnCKru+4c0luieLKbeHLN9E3+VBLLof8s/jqD Hv2HUSPTK0FEf9708zCMEWlG8HPi0aeHWni6+u3FgIc7X+mH5qXHBUoSoMY0CYl1aWI6 6sgKBpavirS9EljeNYzfiU/DlHXP0aGwBGstZrSYx1rr12RMMPhB5TyxeSHaQXxK8B0t Dohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701271047; x=1701875847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ki5eAeZpOcI54YbTPSCFwp5UJ2eI9c3pK5uL2lEEtZM=; b=czlRaWGPGwFjAE2bPZGewp+9661nqJIucC+aJ98+QEtVNJObud2X/iKnYlz1P3+reX Yk6FcjbNbMQBwDjoffhqSsAAEEEk+fPMa0zUGAWdPsWOSjrQ6h1BBhDBAER8xtskLldU KMbqMQgaQk3+hQxnmMVCyNsaHABvMlGqeXTjXv5k9LdmHBgF3wXRGfG0idN+Mi6ma+aH iIpDCabostGbtVeC9z2wvoH2VbZxWj08x68EqWAc+c9Uz3ai8+FFZzKu9AiIv3mgd/5W Q/oN+ZoptX7eWrqZ6Lj9KEXCTWH2nROQ6Jgi26ytqEpF4vkZGXwO366pTSameUmCGs6Z RY+g== X-Gm-Message-State: AOJu0YzDF6f+EmHD0Z9uC98DkDeNu6ciL1I2rL7WehmHVESPhNYUuDZJ 6I+SPhOqVc9inSp8Jv9EoXfJo0Jj2iDa2HGJnhA= X-Google-Smtp-Source: AGHT+IEZIE1AM5E8zn+REarKZMAnlku7irhSBH7MhlpFKWn2MeAvwTjAn78X+XkDrH28XBpWMoOlEQ== X-Received: by 2002:ac8:7d12:0:b0:423:792f:d5ca with SMTP id g18-20020ac87d12000000b00423792fd5camr24998108qtb.63.1701271046994; Wed, 29 Nov 2023 07:17:26 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id ay30-20020a05622a229e00b00423a0d10d4csm4386593qtb.62.2023.11.29.07.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 07:17:26 -0800 (PST) Date: Wed, 29 Nov 2023 10:17:21 -0500 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH v7 3/6] zswap: make shrinking memcg-aware Message-ID: <20231129151721.GC135852@cmpxchg.org> References: <20231127234600.2971029-1-nphamcs@gmail.com> <20231127234600.2971029-4-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127234600.2971029-4-nphamcs@gmail.com> X-Rspamd-Queue-Id: 1656D4001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: shpchesgpz44ztq5ai57nxejcgek4eyd X-HE-Tag: 1701271047-129880 X-HE-Meta: U2FsdGVkX1/LAJOczWxZzr8iLn3fnI4Ld8v2M/K+LBzVDsi6Z+jhL+Cx5Y5f0aSvtTb9qAbBzCj6mNjSzFZK+NfMkhTgBzMC5IJvNpxIwfjCTCOT+AxKgLzNhUMaI6tl7xpqNtq/oYoEAZNdwXED/kXVsjcoRDStRkYJiHO0rLrMpAY1GYXJ2MmvWuuFvSElDl6rk3xr+VjOjn1LJguTtsXE2Cgs8pJ4UUf6vTQ+G8swG/cO5HSP5oVJqGf2L7pw7oS69q4O5RMYvr8SX2WF+wgkTKG6EFKfrIrA2NhkrrsFa5UwNEXo3rrmHpCTKAQbk79AoZImvYalhYp5oFgoJEAq9k6jn4DlQS3R9u3IW8j2Br8qMQJSF8yTdROqH8K6H5N02lCQAyahkTIsJB9+Q9fMTaDQG1uPvdIFX5F4bKzKlPpJkYNxp3k41iF5t0e7A/0tUDFj3pQYHZcLkY5jf0WbCp1/LqLcmCL6Yk137b95r7zis5fI+WQKaSInNvQSnbCWLlx64Y9o3aaq+3rkIPYyKMAJJ8OB+nOPDOL+p5i0+kI8yU5sByWIHlEq7qsSdUGEx1d+adjyBKdC3fGU+44I63k9PUEOrbMuq3Q+EPoD1ajlHNZf2/ZtqncMo3xhklpi+5JI/WTs6mb72/vCNXuB8L1tHA4+ZOXbnSRdWsnqdyc5qzYy4lEmclfrAe2QakhNVDIwunE7LC3x1P5aWUIfHRszEuLbzAEtzqTb6/KWyefRApFrdw9HLwVRohqjIXppQMDdQF4i8Y/VWmAM89n5Yv1oZ9zGNGEnlwFgDeAwBGCH2MV/t71wUnetDQKndyRciDWyu4Z3LEZ+GiQPHxW7E9+kLtHdmyQ22rIW5LTBmnepxo+GlrmHUDWhkKPMATZ6ufoPChKpFsl46K4mEKswBCS8jYegUQ0hrrre16UKQ+fqAdMYTZlWNa0bK7kxbeVLF9DndIPAIxtBnZf gUT2aY7D oo9cDTYk1Fldi5XkbvIKlnOmd1GWFZ0DtvFZgnpxP3gtW1Y5LelHtC4tKUpOqMlCLN35ijShTciT9U6Ae8WrY6TDS0R+L6EzJ5AkMie6XuaEGWc7T8HtXaNqo9eFAk/E7sjkmZSiXZdvipUNbY/n9wrWoQOW6+5riTCdQLsBeBbAiJURgg9i6ZhcDKzns2nQxXuNr2sFEtUnab/qrW5uCaVWxVtqagXLRrlEkotNAojK9bPmIL2F0kNjoAoiLXP8/IAAxwLv1nGrqVQ8vA2SLyYmbiBJ15yRHjBigdNldzV3bphK9BZn5a4n6A5KGTAlZcmvkNo7iHc2/NCKRoATBnLgZovpFnzMlNbDA560enUXjHV1DMITxNEnsd2E+T6M0hBhgvMG1gNtJADfGUF1kN1rLXVTodqHYyCH+hO+2u1c5ndr2LyBK5yw7YV+7TcCrv972pzILpig8TGIYrnwA1KBL9nqoZIDr32tR+Xyrykta8pGOVyLZGktigA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 03:45:57PM -0800, Nhat Pham wrote: > static void shrink_worker(struct work_struct *w) > { > struct zswap_pool *pool = container_of(w, typeof(*pool), > shrink_work); > + struct mem_cgroup *memcg; > int ret, failures = 0; > > + /* global reclaim will select cgroup in a round-robin fashion. */ > do { > - ret = zswap_reclaim_entry(pool); > - if (ret) { > - zswap_reject_reclaim_fail++; > - if (ret != -EAGAIN) > - break; > + spin_lock(&zswap_pools_lock); > + memcg = pool->next_shrink = > + mem_cgroup_iter_online(NULL, pool->next_shrink, NULL, true); > + > + /* full round trip */ > + if (!memcg) { > + spin_unlock(&zswap_pools_lock); > if (++failures == MAX_RECLAIM_RETRIES) > break; > + > + goto resched; > } > + > + /* > + * Acquire an extra reference to the iterated memcg in case the > + * original reference is dropped by the zswap offlining callback. > + */ > + css_get(&memcg->css); struct mem_cgroup isn't defined when !CONFIG_MEMCG. This needs a mem_cgroup_get() wrapper and a dummy function for no-memcg builds. With that fixed, though, everything else looks good to me: Acked-by: Johannes Weiner