From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D913C4167B for ; Wed, 29 Nov 2023 15:05:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4E116B03B2; Wed, 29 Nov 2023 10:05:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D7736B03B4; Wed, 29 Nov 2023 10:05:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 877406B03B5; Wed, 29 Nov 2023 10:05:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 74C016B03B2 for ; Wed, 29 Nov 2023 10:05:29 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B3F51603A7 for ; Wed, 29 Nov 2023 15:05:29 +0000 (UTC) X-FDA: 81511315578.13.587522E Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf26.hostedemail.com (Postfix) with ESMTP id D7000140294 for ; Wed, 29 Nov 2023 15:03:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=lGzUO8nW; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701270186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C2wsVpYCu/TCERAyV7xfQRsKsQF4XxordQuNYbkUm7A=; b=lSnt5uPl312ff9uZKVi5kPCVYCQekigqrZpAfoykqWJsnNiuoqiX7gQ3UgkcSHT11LLTf/ lwVeZbIE+9nDGzij34Zi81nCtfD27nk9dWk2MqC6jINyRJGop6i3Hs1W12OaP6Er1wiM7K X+4ha2pHy6mRzf6DmKob5mouRtVFDew= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701270186; a=rsa-sha256; cv=none; b=Ay86MAR+la882pN6pEMAs9DoU+vo7aKVvuo5ubZR4WISMRYkZ6qzO3yyr9x3tupDhb2zzK mY+1MNwwWrxlc3u/h923GHUkBbNaHwWdMvN4KcgBjJhr+XYz9W0Ji2H5X44TNBjnZoB7RY sc97MItDBqa7tfPh9TGFaJnJBquolUw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=lGzUO8nW; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4239f5c1ec2so27101741cf.0 for ; Wed, 29 Nov 2023 07:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1701270182; x=1701874982; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C2wsVpYCu/TCERAyV7xfQRsKsQF4XxordQuNYbkUm7A=; b=lGzUO8nWGoMXXC30AVzIh8SGUSwr7vwco6wydtaON/rK4PRhWIrJ+m7LAQlDSp2T/6 Sq6GLeqHcG/xuzU7dKylItpJLgv0UltRKML2j2pBzmgeMK9B/TTsu1JTDPz19tPknyNN J7+4PykyzXpRrBsGMIrqMY9yt6/SzMSDvH8nNg+ZTGwNMnbd56XVR/u7yTbpSMyxd6vF kF7j2Yjp2+ZReX/YZ63XnS9Yz3LvWpvmmfZBFtmiAcjNJbKvYzLD5DXlGFr8TEfwhOkh sZJDkwl45RbdjBsGzXUZ8EqmCTSnKcCM/ZoHrjjHRuvqrwtC5oPtjjvjkCbO16BGYdsl FevA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701270182; x=1701874982; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C2wsVpYCu/TCERAyV7xfQRsKsQF4XxordQuNYbkUm7A=; b=d8myDEptlkxnHjsVWMxqgEVvn7MOKi4saRRqHfjvs2tAZA8PqFm+Yx//rscsPOVNr+ 7ZqI4XU9vI3kzBgLcv7ByCgiRc7cWCZ3b13J0U0Mn5tTR47H27icvyP86JzEvtZtxh22 q6apxVDlrRbBew9tx3J0W26+1rCcF1JgK9Zdn4GZIduXx6zC+zG7fzahgbCgfC9FYu7S J+ggYkAQWKryzqvq98otd/nuvkZyrk5SrWy7MumfMNrBzGm9d4eqMdjDDYJN6OM0+q0x c4A2o7FhdUMSx/S1xIbkKBI2zZixZBvpMT3kfm+WLw5ITFAjdnLFSHqtJVkdxuwlIQ0Z HkEA== X-Gm-Message-State: AOJu0YwlQkNHUEiq/kdf+ibNKvOhM0Ob3miTAqAqiHgG+dGRtsymDyiv Kd57t5edmsgiTHzkSLGzxT55ag== X-Google-Smtp-Source: AGHT+IFhbxa568oWRmeUGcBeIbWIWKZfp+eJgBPEkoaJAKk9/smfQhel6cgM7NgfceIz+TM9Gd82+g== X-Received: by 2002:a05:622a:a14:b0:423:f0aa:a82c with SMTP id bv20-20020a05622a0a1400b00423f0aaa82cmr1468250qtb.32.1701270182230; Wed, 29 Nov 2023 07:03:02 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id fx10-20020a05622a4aca00b00423de58d3d8sm1366432qtb.40.2023.11.29.07.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 07:03:01 -0800 (PST) Date: Wed, 29 Nov 2023 10:02:59 -0500 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH v7 1/6] list_lru: allows explicit memcg and NUMA node selection Message-ID: <20231129150259.GA135852@cmpxchg.org> References: <20231127234600.2971029-1-nphamcs@gmail.com> <20231127234600.2971029-2-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127234600.2971029-2-nphamcs@gmail.com> X-Rspamd-Queue-Id: D7000140294 X-Rspam-User: X-Stat-Signature: r8t8nqxjk89xdbz3dukge7iha1drof6y X-Rspamd-Server: rspam03 X-HE-Tag: 1701270183-850786 X-HE-Meta: U2FsdGVkX18IP987hDmDIbe8G3RG8Kjhx1LRCtidm/I/AiJev7r6TrL5obNsk6jyv4dpwbD/4CTu9sCBglEphll2eaBYifNU+dnX+ZBsqrHKknJmGe4n5Uct0MSdABV3puPAdm+JLLiEZIfw1DCi/i0O0qW1ZMfyEZ4DkL76yEbNv4PCivMf3mIBOyk0khmC4FIK5WXMTw2I+L8QQGYb6G4qXiHSjtYCN+dPEKs5PphOJWidkyJARNyvuONmkmppCekGoUfesXLxUfpeAb39Ws2oUNSkBtLKD0TCi+rwd4VQ8UpckzpgMQ5Wh3sBjelb19I91uPUhmZjZcDIArtq+Nd/rDF33cHV+jAKmQniUmdE7wWhgHG1BC3MtSc4YVh3ajRFwPUvw89JrJxvOzzHcn21q06wFoJ8urItOLusNNj+fyjcXqLUWcMKdoxJZmDroi9fxwitfX+ArumcVj6kPyab8PppSzHqcWADfra1aY/lwPa2ZHIEMy0v/+NqfugHrafUA3+sLZo8NPnQStdzf8dCdN26dAaHG4xAHZ291Ivmxh8FUTi0bO0LVapDtKBZsrhgnl4V1aOn2f8+QMEKmIGZ8i0NOo96PNPfQ/E6dAWYMy0+dpGZ/BC7z2NP5EBzAji9tSdUXDbmckt0XcBhtZhcTbXnf48RT7F+d8kovb5w43+nzAblJgo4oxVV6qvCNJFU+1NstpWjs0lunFikumMVQ8NU3hTbOGLBswIPIgAYlxy1x8iZo6Zt/xcYMbmOegISkmMjmyTy3ujnS+iXgtBysmNHyqEk6DZ+ZX1GIJX4UWQ0Lt9dhE8wjq2dqxVdWcfT9ynmvoSvjf8gPKxYra4UUI+W8h1jJuI0tRlEo3krXvNvbdHUE/8U5HV4HXd2t4suesy52vrntOnWo08mc1RQDA2BzOFYCKAeC2MasQESHz6Y+Ei3DKQiCrW4PVlJzwHcjDLsc/tREW64QGH sbSXRCRw yPsWWU8OFq3Epi7sl1ULohAqHbXCXAczG8jVdHCSxIxMqbNi2AGWL6ZNQ4D5QzyeGrwNyQIHFH90yNxmrOPzSfawuhiKqqh4NzUu9JW9AwmacwH7CaVMyoei/XfQzHkJN8PmdZznEBzqvcvjXsSFu/niYGBVoGW7Feh4Z076QnRftLdKydcexGOTWk4C41f0b0UkNFfGjNFAoOQTRWT4J4WSb8YCatHAKV0h97cuRMfCp7gubpOKLXThrfWTJC+sjhdhEbHdA5XYEqMMJGWdksPvoWrpLzFx/RFtQU+er7wCZWcGs/7J2cY1sNkzXOSn8bMK/ZuR1g3JrEEXEfWppkh9feyEddLsuNTMXK0hKBmEX753LewBjnHqA+2bRxgqC8CHq3gAJFR3MiUO/ak2mD/LEOX7JI2+4Tb1Y/r/BBC3sDduSlB71/t4FfZV3YDszGW5ydFGAApeTvnLDFCnkvSFTM07sIuDYHBS3iw1xq9MfLqQR7/WC28h6ssZKua8aDb2WhdLch3+lMcIHuWEE9PsX+/seCVQ7lBJDg5RKLYXqbr+BjggbysXouJcIe5U1+6Oexs3ENJQw9U8p7xgNZ5+cHV9au52rzDQ1Azf2ck4K0qmeDfCuoWaw9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 03:45:55PM -0800, Nhat Pham wrote: > The interface of list_lru is based on the assumption that the list node > and the data it represents belong to the same allocated on the correct > node/memcg. While this assumption is valid for existing slab objects LRU > such as dentries and inodes, it is undocumented, and rather inflexible > for certain potential list_lru users (such as the upcoming zswap > shrinker and the THP shrinker). It has caused us a lot of issues during > our development. > > This patch changes list_lru interface so that the caller must explicitly > specify numa node and memcg when adding and removing objects. The old > list_lru_add() and list_lru_del() are renamed to list_lru_add_obj() and > list_lru_del_obj(), respectively. > > It also extends the list_lru API with a new function, list_lru_putback, > which undoes a previous list_lru_isolate call. Unlike list_lru_add, it > does not increment the LRU node count (as list_lru_isolate does not > decrement the node count). list_lru_putback also allows for explicit > memcg and NUMA node selection. > > Suggested-by: Johannes Weiner > Signed-off-by: Nhat Pham Acked-by: Johannes Weiner