From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7B5C4167B for ; Wed, 29 Nov 2023 22:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 259C58D0023; Wed, 29 Nov 2023 17:53:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 209A28D0001; Wed, 29 Nov 2023 17:53:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F9398D0023; Wed, 29 Nov 2023 17:53:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 033928D0001 for ; Wed, 29 Nov 2023 17:53:08 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B2C2F406CD for ; Wed, 29 Nov 2023 22:53:07 +0000 (UTC) X-FDA: 81512494014.05.4F1C0DA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 899014000B for ; Wed, 29 Nov 2023 22:53:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KN4ybSOG; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701298386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ERHBoCaXl+MAeDtZ7FNZNqbbU40kUWvK64al91+Rosg=; b=7F9rTp/W/FoPVptFZCnNDMeiyTAwFdgZNaBM3utfvYMqtNKAgBoMmERZIGnPLT9/PvEJw4 F0WGJmnwRsMupm+b6Yb9Qwc9kvLAYfLVZ06O8JdhMU+st369mU+qlGc6A4uxTSfCbCs9Rh frv0eik+cIVNlj3iqt8J+DW5+VNfj/A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701298386; a=rsa-sha256; cv=none; b=4Y9/XnNM3FosdjPcmAZ5TGKsY01duFyUtb78A9AP3spNbpyNqCGdkzDpXg4A63MnSOBWmk 1BYrAtKU6Ml+OCXvuCWUIsrJC1jSaJcO52K/40X4/v68gT1w6ZhObz2297mJ9k+853QLpP mAPDmTTa7LJrDVO0WsDUwMWU7yeAsTQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KN4ybSOG; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 287B0CE2086; Wed, 29 Nov 2023 22:53:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33066C433C8; Wed, 29 Nov 2023 22:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701298381; bh=TAUJJVD5ScDXco0WQyxMdI6UmM00XiUUIKcfRNMRJco=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KN4ybSOGnHznXdrV40ZOvzdsIvP8Y/tZPYhLbs9HkEmQSEbPctPkvVp+LmLO0fuFy FMKQr5SEoIFn3gduc2KFObPVQnA1ih1OybU456wq8yEB0whRPOXd1pY8LxU/0yZkgj bzsrXB+YfZtLYZQlHHa5BfCzVsTmXp86eKb7kFt4= Date: Wed, 29 Nov 2023 14:53:00 -0800 From: Andrew Morton To: Yosry Ahmed Cc: kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Nhat Pham Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' Message-Id: <20231129145300.9a178d9bb8518f8bec92b350@linux-foundation.org> In-Reply-To: References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 899014000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: f1a3y3bptiya8rd6bdr8nzeqiwj7omiq X-HE-Tag: 1701298385-433833 X-HE-Meta: U2FsdGVkX1/r5P+q80aHlrTtWkxVyKaq9zQugOG/2RTz9qkicbVO7b0KpPJ9EEJuDl6eXm8FCvvutSDcYDAJVO2Y2Fn+fics/xtxbRw0U6dqDcZta9qx7cEbY/VqRJMC3jPjEpDWsfUCI+PhdKT6PNZu2HhQZFy7xvD3vB95lMRsLailKFBhA+XKmrj+Os7BjcbRjX4V6TLH3QgcBCwXK9KZSijSMF4QFnmkf4PT37z6pPDCtIQMRT/eCI22ZllAoGJ1y1fxEiAkmaZoTYCh8QDY2UkRuBu35GjcH1EuZJqwpx2YW+kJa2D173m14VK5J/INYj/HSNh5zI4Ztb3WucRKap07nLPWcjZ1DfXYgs38Xo62lgdOfydVigXgfmGwKg7HbnsHe1J+RPBGwGDRKoLGmIQioC+6pSJ+2hg0EJptMnO+pHzIU406ujphwolXcYQdZPKCsLT07JBd5qK/HIVQr1SlBU7KnibZkPxIPApHdl7+ay0u8KKa7cO7J57oOis1qeTYiDMfjXSD8zXt1Ej4PmxBT/aGQLwmQyJ4fCWe4ATERJt/qvWCyW0FDQM0v8Nb6Hcg6iSELy34S4UQ9Dx6G/tHqQhhvmUZ/mYahQElqG7VifpTghpT+tZKwbVqykll9oTUOjVY9T1dkuFPJQWfBEp64Zr20Shgc9g9X4d7qVozK9B4Eq4/CswvktnkFYbcWq9Re69ZXBNGsDf2cyitDn9ZxRVRvGGLsEZ903r9wCK1DS3nC/7y5fso/8cWoPVPyVbB0OPkUlCqtGCYGGdXW8D8P51HLM0QnRh9lT+KbkoUXG38gc4XHctOWBzeqGr8NieQ85NcE03qwuzWo4VkeGtFxBloSa04AbZCTcIAKvu9x6yZSe6k08iGvjF8P2pR8w2WEory0BeMvtX6S6DgOMsNZCS4V2esakvRbYB/IL9KCarvBvA01a/4j8u+S+UyWBxTtsPPFboVOXb /SDn7zv2 7bmYciHdu6GzvGC00AgX5kp3uPhItxd3LrtE0yx+g8EdRBwRU5J4qw/4fjx7WD+vRzsf0i/uz+p9yHXJCnO9mdfIbAh9/JPDRH3EeAt8Anru0HiRYGT+bXXpjOLzBzRgVFVDewy0RapV1wVvrlLbeAIW2Bh8mb+yqw0Lbz0FdjOisz5Ya5f53t/ShP+lL4sMEfMbMcaH9u0VDt2ux014tA1eRIHvBYTNLlXzWfumfkSdSml1La1QK75vhrAJH0bRi0qEtHc6tgqUdQNBSvzCgPbl9q+ooLnecXQpiNg56x+2bNqc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Nov 2023 14:31:12 -0800 Yosry Ahmed wrote: > > mm-memcg-change-flush_next_time-to-flush_last_time.patch > > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch > > mm-memcg-make-stats-flushing-threshold-per-memcg.patch > > mm-workingset-move-the-stats-flush-into-workingset_test_recent.patch > > mm-memcg-restore-subtree-stats-flushing.patch > > > > in the hope that a new version of the first series ("workload-specific > > and memory pressure-driven zswap writeback") can be dropped in place of > > the old version. > > > > I see. So Nhat needs to *not* rebase his patches on top of the current > mm-unstable, right? Sure. Normally basing on current -linus works out. For best accuracy the base could be the preceding patch in mm-unstable which in this case is "zram: use kmap_local_page()", but that level of fiddling is rarely needed. Alternatively, if the changes are small then sending me a shower of small fixups against latest mm-unstable works. I'll figure out how to arrange things so everything lands nicely.