Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup'

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 29 Nov 2023 14:31:12 -0800 Yosry Ahmed <yosryahmed@google.com> wrote:

> > mm-memcg-change-flush_next_time-to-flush_last_time.patch
> > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch
> > mm-memcg-make-stats-flushing-threshold-per-memcg.patch
> > mm-workingset-move-the-stats-flush-into-workingset_test_recent.patch
> > mm-memcg-restore-subtree-stats-flushing.patch
> >
> > in the hope that a new version of the first series ("workload-specific
> > and memory pressure-driven zswap writeback") can be dropped in place of
> > the old version.
> >
> 
> I see. So Nhat needs to *not* rebase his patches on top of the current
> mm-unstable, right?

Sure.  Normally basing on current -linus works out.

For best accuracy the base could be the preceding patch in mm-unstable
which in this case is "zram: use kmap_local_page()", but that level of
fiddling is rarely needed.

Alternatively, if the changes are small then sending me a shower of
small fixups against latest mm-unstable works.  I'll figure out how to
arrange things so everything lands nicely.