From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4FAC4167B for ; Wed, 29 Nov 2023 22:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB358D001D; Wed, 29 Nov 2023 17:29:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AA528D0001; Wed, 29 Nov 2023 17:29:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79A848D001D; Wed, 29 Nov 2023 17:29:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BFA28D0001 for ; Wed, 29 Nov 2023 17:29:43 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 37CCA120684 for ; Wed, 29 Nov 2023 22:29:43 +0000 (UTC) X-FDA: 81512435046.30.641B101 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id DEAA9A0003 for ; Wed, 29 Nov 2023 22:29:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fRar90Wn; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701296981; a=rsa-sha256; cv=none; b=c+kLQO7qrqhG9XpRP0j9pdyuKMsO0RS5sJ5bZxsMgwwU+tVKkGAzhZEfs+e6xl/9cO8jPc xk9xvbbWchWuuJL78ZjNSzFu1qLBNyHGZUilt2MA0n4HSM61RyEW/qMv4Ae8PoEFvLuMnG LjJk50vEfDHW98cmvHEj//YiJqeblV0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fRar90Wn; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701296981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5JCniHL879jUVT85KimeC9C8mUcPoBmO/0SedIATvGw=; b=5/O5zcF8kUikqfjnOwNYE9YLZmIhwcTWkBZoTzJCZqUQjTdVwfUCQWhI2kj54sOuEiDtpU OcanAsa4SRgiBrDHRlWOKSOzhcCk2/WK/HSDhJvJYX1aUJbH1DU+CSWwS5icnQAymXnFyU /SeCMRXuYFmjJzQk222TfgLo4paMYLU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8A06ECE2081; Wed, 29 Nov 2023 22:29:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96634C433C7; Wed, 29 Nov 2023 22:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701296975; bh=z9NRJgq2yaBZ8TkODMHF6Q/HOHeioPQsFlj6A/kPJow=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fRar90WnjDqWWJMwz2UoA5/cOISFkx3wPdqyt/RIpnYoC33FT+G31zAVV3BbtpEqI 1AON6xVDsn6r4iTYtIBbgERuzZhwzvbkRkAQ2+86S8HOdwD6Nrl1P3xW4ip9xJBVOT 2aEdm7hl5CQRQZiaUREB2KCn13lsG9bYI+0eHZ2E= Date: Wed, 29 Nov 2023 14:29:35 -0800 From: Andrew Morton To: Yosry Ahmed Cc: kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Nhat Pham Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' Message-Id: <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> In-Reply-To: References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DEAA9A0003 X-Stat-Signature: z7bcuebf3asp4a9om5n8txcbmgrjhqo6 X-HE-Tag: 1701296980-747062 X-HE-Meta: U2FsdGVkX18I+8PPuhiY6hcAn82z0bgc8NW255bFYy/ZD6gjQuwFeic+kLQCdTpg2egGlPCGNo/sRdAwS66NGZnKAF68xWiANaYsPFo+sHoflz4pbvMMHCJQiVmnZh7omKL3ISAWsD6qbK7Z3taB/Ylb5ToEJWRoEPsTow/rtq5eNaDpXWsatWS1Y8+Rk3XOtYG1LA6YorruRhFvLzVowVI0e9BWWJhNODUo5D2j43pGstUDqWbljmXgrqv1aDlrgebpWii9Bit+C7sTkuWEP/txyWbyXePpQMN1SzRvp8QvEW0dJjLstNtwpUYroIVWkE0AnkVbMPpxBYwd9sASx/7Xt/yFw8jCbAmRnQxqTa68xuEGGt3nBQyNqpSuSXBmmFzTXuQSFAjexAyzlAw2RZOY17BeYFDnGO/UpvYF0lV+KZQRQkhfRWqduqwZgqrCmWElyLVHgINIKulOw6MXZwU3U8cvoucetNVeNq0SChKjd3OeKDkh+WKMwJZm1cnIcz+v4/0UC+2DlWwJ284DAz0rONfFsCvHD3ogDTYI5UlEZBr4eWt+asnHsXwZ74XEUAGtzq7JaywsXTi8YKKmY07V8mBV7BBB1ePYtVSyXjx5pmepOvHi5mS702i31nYqV1AILGTAnRZEDHjOLRNxmqqzdUaRrPyVWj6g2xov9vL5hJtb8+Mm7AgGbBDPhlb9Mfbg4eaxREesNgDZywpu7a8wG4Jtq1l/wC2VFa1UABCnsq+f2PKWsmOckfRCdYCQGNbOtemIZputodBV/5vnPNIMqGbE5yQe99XGosKm1WR7TAo9FRN2NiYRHyCS7ph2ySEsvzC4Z/OZH+KMNQUYIvuZYniiBMmeyjsiH/t1ZR5giCIXsAKb7F/MgKx9/ND0c3JANCk4XdDThHqXyoin64ps2vzIMDhdFaZJk7vSkYcy6nWupj0r8YSJ7ZlsFIAsZOE+ghHnGppvjwyRDyt 7m5uswKW ntnG2tH4/mzd/WYfq3fI0wKM5KGh50TxJXOFQZMTgLUkzl/ugVORItqhUF6P9Zs2Qe69NtPDqNuXntjNM8qJqE0pjLx+bDNM/7QiI8tz2M0r8xwJ/V4mOgJ9tvHSsko5qYBF1RM1vkP4Dku9AhQD+vUstz9j+gChny2D4MFHUZ1fdRfkWCgK0ZGmZ0fPiIeKL4fs/HklrJ0CQ7ssMadQ2kxRDa1aTIeiHKe+WzKvFtv4o0ZjL37cwexOKfve+3/AgAxhQ6rOiJ9sqYpmnCCuS0yMYK+slsUoaXwcOItnh5v5vPjHiwGoDeWoFrRSHWd86dIZ3U3293jaVdgdkpWgDh9o6ps/8L5z1rscMiy9vdjcaYXNYxHMXAasuZg8eWoQirmU/rnYqsYUVYS6JqDc4r/tGZcruqBMVGq5dB/ZKMEVV6cY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Nov 2023 14:18:15 -0800 Yosry Ahmed wrote: > On Wed, Nov 29, 2023 at 1:53 PM Andrew Morton wrote: > > > > On Wed, 29 Nov 2023 13:43:13 -0800 Andrew Morton wrote: > > > > > On Wed, 29 Nov 2023 23:42:11 +0800 kernel test robot wrote: > > > > > > > >> mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' > > > > css_get(&memcg->css); > > > > ^~ > > > > > > OK, thanks, patchset needs work for CONFIG_MEMCG=n. I'll drop this version. > > > > Well that's annoying - the "mm: memcg: subtree stats flushing and > > thresholds" series had lots of dependencies on this series. > > FWIW, the "mm: memcg: subtree stats flushing and thresholds" series > has no actual dependency on the zswap series. The conflicts come from > patch 2, which moves some code in mm/memcontrol.c, which happens to be > touched by the zswap series. The first 2 patches of the stats series > are just refactoring with no functional changes, so if those two can > remain in mm-unstable, independent of the remaining of the series or > the zswap series, then either Nhat or I could easily rebased our > patches on top of them, and you can easily move the series in & out of > mm-unstable without conflicts. > > Another thing is, the only difference between v3 & v4 of the "mm: > memcg: subtree stats flushing and thresholds" series is the rebase on > top of the zswap series. So if you want, you can take both series out, > and add in v3 of the stats series instead of v4. If you need to remove > the stast series again in the future, you can leave the first two > patches to avoid conflicts with the zswap series. > Ok, thanks. I prefer not to make what is in mm.git too different from what was sent. I've left everything in place: list_lru-allows-explicit-memcg-and-numa-node-selection.patch memcontrol-add-a-new-function-to-traverse-online-only-memcg-hierarchy.patch zswap-make-shrinking-memcg-aware.patch zswap-make-shrinking-memcg-aware-fix.patch mm-memcg-add-per-memcg-zswap-writeback-stat.patch selftests-cgroup-update-per-memcg-zswap-writeback-selftest.patch zswap-shrinks-zswap-pool-based-on-memory-pressure.patch # ... # mm-memcg-change-flush_next_time-to-flush_last_time.patch mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch mm-memcg-make-stats-flushing-threshold-per-memcg.patch mm-workingset-move-the-stats-flush-into-workingset_test_recent.patch mm-memcg-restore-subtree-stats-flushing.patch in the hope that a new version of the first series ("workload-specific and memory pressure-driven zswap writeback") can be dropped in place of the old version.