From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A83BC4167B for ; Wed, 29 Nov 2023 21:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B4326B03E5; Wed, 29 Nov 2023 16:34:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 664836B03E6; Wed, 29 Nov 2023 16:34:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5548C6B03E7; Wed, 29 Nov 2023 16:34:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 472E86B03E5 for ; Wed, 29 Nov 2023 16:34:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 252C616064B for ; Wed, 29 Nov 2023 21:34:40 +0000 (UTC) X-FDA: 81512296320.30.4797932 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id C7424120008 for ; Wed, 29 Nov 2023 21:34:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LX9VsoLx; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701293678; a=rsa-sha256; cv=none; b=O94UoEwA04tWf6HGKXdtaKhMDjQGY8v473dYlYTxCuplyKpNJ+c02Pw5RQAGG47EcfjbZ+ Yqd5AsA1iU+cSt8u2KD62v9IGT2aIQpF+fYJ0MZSy3MDzomlCBjzODEUgKhtx24u/hClYX 6ZJAMuYn+03f2K7LBOv4C4SYjGNS9tg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LX9VsoLx; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701293678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UFk0ekxQJ+RI04VbmjkqR1J+xyJVgXSSeGZB2ekAytc=; b=3dOOWDelLkmasplb4mUXdjOOWrlqDwnsTxYF3gQhtXlhdaMZYxJV/LA40Lz0VtUNKStcYn Dd1Vgmcc1IYgprJZ1KMIF72BeAmcv1T19r0M2zbv50TSPdzEvT1jrnXkIFYyqZcB7Au/9h bArm3VCwyzuLkggWsjp7BAphix4uKsU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4AED2CE1FE5; Wed, 29 Nov 2023 21:34:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 660C2C433C8; Wed, 29 Nov 2023 21:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701293672; bh=kL0I4MRvgCEdIteyNipWsQFBfblx1ugzGlG1DkHTDmw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LX9VsoLxBIdgK1BYev8DQfent849BcS/GMmf8Z3RlNkoMdZHGxEHrUVrFmy6eNvF7 2FA4ZJBgXh8HQqQwyc2c8/u0loEgSrMuWgk5QKbel7Utosdp0lQ7RLtLkN7USzpsNS FLYT4kV+pyfNsQ+WI3nXedP3WhZUNrEdB9FTdsPk= Date: Wed, 29 Nov 2023 13:34:31 -0800 From: Andrew Morton To: kernel test robot Cc: Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Nhat Pham Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_memcg'; ISO C99 and later do not support implicit function declarations Message-Id: <20231129133431.73512e280e870efaa17f9f4d@linux-foundation.org> In-Reply-To: <202311292305.43bnw55s-lkp@intel.com> References: <202311292305.43bnw55s-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C7424120008 X-Stat-Signature: t6y75xihhypczryi9msafsy4to597hik X-Rspam-User: X-HE-Tag: 1701293677-921097 X-HE-Meta: U2FsdGVkX1+6uadx6lnR7qAMMYvp2RGAZzmFuTWAzmbAlGnyzJZ7xzERLn2lmeGpWa1pUAcXNrGS2PJUDCcOwepw6f0W2AgvHNxJ7ZNSSCVqOevl0hpJMsjvNx7k/TjS9VOWajI7DQahAk8u/bmtvFh/lXixYqz7l5103hdPIKe0PZ2jKswkx2viDPCs6YtXOvywsEb3DnPLEeFrupePw6y9rRNWg3OD5+X0E8oKDR1DUI7gZ+0pnNCU1iV1kqHyWm8uk+5K+chuZA0cLwr4GRv2xyFH7F9vrytB7/DwZT9OLd8pXW6/Qp6FgfIYm70+wSKohGoZ52AYvlutCN6+Z4IuVy1RLn5P6fHtdRbE1NfZ7NX6EHSsVRa+FWKs1MvjG+M+5DrV/Y3ykaOe8luOoiIS68yaQZredk3LGAOvKEILgd+IdF6ND5XBExntK7GmrzDky7+rMtkaYGqY17MP8MKAnnk68sgnWSdXCbtHtu6+bUMs5Y6ujJhXJJM+0uLtfHg1G3VT1J730GbSkHvfkCV0a8wsWxph0QJutEeh6WSG21LhDB4+b1zbiFZDjtlh3RGGEc7iSvvpEWG6AaSZZoa6AqybDupP1RUeePIKMXN4C5iQNXl+BRUDS6Yw7ivdHjOE//s+2ZxjpIVY0obWUQ+nWCedMkpYRUftwH2lQGTszXXqI2QpXjn8ww2JHpL2Sa8ZZRfeAOGMyzbS3WFotCWumgtfQNR0C4IXMl60FxEw6grH9d+HfUlpsbohQ65I5cV4UMmYlrKnLXi3s4wJYlVvDSnLvnbh/skwGkDGSfWW4ivvXKtdgrvRaA1aSMDxSZ1ZC96oCe7/0Mi9Zx03awcO6HuR+viGUDrdopOfNpFtqW2YyCPaj/z1CrOTSeQJ4tsO7mJvdIJjcGeU3gnnfjc+gU0KTjmadqBqRk/zXCuRO+dJX9PI2+vD+v9soG45FmlUAt7auBcR+8RX1Vu zPVxwpr2 1f+KVCXGRYEijejVE1nc4IiEaPMaTD9m2zsbsyLAw/rWe/7Y3AjCOJkxFEwVM7olxVdxpy2ApPqfZx6RQfO6POkdGrxB3lF2+lIj6G+gzp6466SKs86fCcLRzQeFMA1bbet1tSMqPwI7TSbtqITMmogjOyBD4t0IRTM+ZiUY9xfU3C2ELsNfoi/Lez7IYnPzxX2uSXKwHFjRHA95ZSTQFfiQFS0Rc9Oo52QGPZHUYqiIvUIr5qptynsgXtwlpgK+AmU7SLK+lHFs8q5GXQKsqr5fyr2g+SirzV8OJf/u4TDgYXnO81YJHzJsgt6B3CU6YehPluDKY2lJpMZgoBMJanzZJ/Q+g4mhFNWAYz0m8uNDs2YviO5gH09PwINgVitOK/ZcrZbyQzBeWbuf5OCTBS+35yzikKTYIIdwpLeM3YvW79FGRYqQYS/DP4YoyIorrgwUMDcxfPnlDXeeZVPIKxCAf6f/C3sVfiLHrlhdKJLStXMI4MPGt5rBZ1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Nov 2023 23:42:15 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: cb1d236cb1038fa1bbae9913803f1c655b86d931 > commit: 70dd375afcfe1839321ea8a65749404a99f0e773 [179/192] zswap: make shrinking memcg-aware > config: s390-randconfig-r071-20231129 (https://download.01.org/0day-ci/archive/20231129/202311292305.43bnw55s-lkp@intel.com/config) > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231129/202311292305.43bnw55s-lkp@intel.com/reproduce) > > ... > > >> mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_memcg'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL; > ^ > mm/zswap.c:298:24: note: did you mean 'obj_cgroup_put'? > include/linux/memcontrol.h:1352:20: note: 'obj_cgroup_put' declared here Well I'm going to assume it's this: --- a/mm/zswap.c~zswap-make-shrinking-memcg-aware-fix +++ a/mm/zswap.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include _ Can't test because my gcc plugins have gone stupid yet again. cc1: error: cannot load plugin ./scripts/gcc-plugins/stackleak_plugin.so: ./scripts/gcc-plugins/stackleak_plugin.so: undefined symbol: _ZNK6frange6acceptERK14vrange_visitor cc1: error: cannot load plugin ./scripts/gcc-plugins/randomize_layout_plugin.so: ./scripts/gcc-plugins/randomize_layout_plugin.so: undefined symbol: _ZNK6frange6acceptERK14vrange_visitor help.