linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
	oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Nhat Pham <nphamcs@gmail.com>
Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_memcg'; ISO C99 and later do not support implicit function declarations
Date: Wed, 29 Nov 2023 13:34:31 -0800	[thread overview]
Message-ID: <20231129133431.73512e280e870efaa17f9f4d@linux-foundation.org> (raw)
In-Reply-To: <202311292305.43bnw55s-lkp@intel.com>

On Wed, 29 Nov 2023 23:42:15 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head:   cb1d236cb1038fa1bbae9913803f1c655b86d931
> commit: 70dd375afcfe1839321ea8a65749404a99f0e773 [179/192] zswap: make shrinking memcg-aware
> config: s390-randconfig-r071-20231129 (https://download.01.org/0day-ci/archive/20231129/202311292305.43bnw55s-lkp@intel.com/config)
> compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231129/202311292305.43bnw55s-lkp@intel.com/reproduce)
> 
> ...
>
> >> mm/zswap.c:298:24: error: call to undeclared function 'obj_cgroup_memcg'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>            return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
>                                  ^
>    mm/zswap.c:298:24: note: did you mean 'obj_cgroup_put'?
>    include/linux/memcontrol.h:1352:20: note: 'obj_cgroup_put' declared here

Well I'm going to assume it's this:

--- a/mm/zswap.c~zswap-make-shrinking-memcg-aware-fix
+++ a/mm/zswap.c
@@ -29,6 +29,7 @@
 #include <linux/zpool.h>
 #include <crypto/acompress.h>
 #include <linux/zswap.h>
+#include <linux/memcontrol.h>
 #include <linux/mm_types.h>
 #include <linux/page-flags.h>
 #include <linux/swapops.h>
_

Can't test because my gcc plugins have gone stupid yet again.

cc1: error: cannot load plugin ./scripts/gcc-plugins/stackleak_plugin.so: ./scripts/gcc-plugins/stackleak_plugin.so: undefined symbol: _ZNK6frange6acceptERK14vrange_visitor
cc1: error: cannot load plugin ./scripts/gcc-plugins/randomize_layout_plugin.so: ./scripts/gcc-plugins/randomize_layout_plugin.so: undefined symbol: _ZNK6frange6acceptERK14vrange_visitor

help.


  reply	other threads:[~2023-11-29 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 15:42 kernel test robot
2023-11-29 21:34 ` Andrew Morton [this message]
2023-11-30  1:53   ` Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129133431.73512e280e870efaa17f9f4d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cerasuolodomenico@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=nphamcs@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox