From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B26DC07CB1 for ; Wed, 29 Nov 2023 17:33:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B2286B03DB; Wed, 29 Nov 2023 12:33:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8622C6B03DE; Wed, 29 Nov 2023 12:33:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 734D06B03E0; Wed, 29 Nov 2023 12:33:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 60F336B03DB for ; Wed, 29 Nov 2023 12:33:46 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 35887C058E for ; Wed, 29 Nov 2023 17:33:46 +0000 (UTC) X-FDA: 81511689252.26.CEC12AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 6D9BE40012 for ; Wed, 29 Nov 2023 17:33:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=USgwQzTa; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701279224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=De1+etvyMj4qbGKndNSJbMRzBLfz1+C2FxgVhXNAEvo=; b=2z4w9AgISqGhV/Kfey5NZv0y2/Twk+DACi4C9TrYdnsKkPa0EfeN4mlGLeNDQF2wypjY5x LxHXXiee22E/D+TPtsuzMTp/YOQZkonThzMDas35X2RdzYAODYHWoRYuwz1ihcrVtMHcor a8IOMPJ1Q5D0HQDVPJ+1OShUeDaDKG4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701279224; a=rsa-sha256; cv=none; b=jyMMmT6if/rXwBhSQ9cKNzLkSN6/oHP3exkgeP1OJ76euB91aGYl9fmgdzihzLADiJi/8t GFAztk94GRYlsxFImpTGF/r0uyYWa7KsfVT5/GJNdQM9bs00w1Ws9gbRXo+gBU7piXXZD6 mc3y8C5UCAH8nkj0YFTvubawMndA7bU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=USgwQzTa; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6787F61CBA; Wed, 29 Nov 2023 17:33:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86921C433CD; Wed, 29 Nov 2023 17:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701279223; bh=zQQtQnUHucJiwN/RgIyJnqMuBd9OdTTF4L4XnghdVhM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USgwQzTaJOoS5e7xNqNJZYaQJgsm4DYEqgxPQkGiNGMQ9bYiU3rSdOdAKhOorK1Hd sAF10PwyYmAceKrI9fZfeEGjxvuXj5AeqWrKzr3UgzpHW5OEj9eoWAUJDn5MUd/7YU H8TJCT5AxiHc68DVNQc+hjedUEZDe8Tczed+byys= Date: Wed, 29 Nov 2023 09:33:41 -0800 From: Andrew Morton To: Dmitry Rokosov Cc: Michal Hocko , , , , , , , , , , , , Subject: Re: [PATCH v3 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-Id: <20231129093341.02605a16142fc3e04384c52e@linux-foundation.org> In-Reply-To: <20231129152057.x7fhbcvwtsmkbdpb@CAB-WSD-L081021> References: <20231123193937.11628-1-ddrokosov@salutedevices.com> <20231123193937.11628-3-ddrokosov@salutedevices.com> <20231127113644.btg2xrcpjhq4cdgu@CAB-WSD-L081021> <20231127161637.5eqxk7xjhhyr5tj4@CAB-WSD-L081021> <20231129152057.x7fhbcvwtsmkbdpb@CAB-WSD-L081021> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6D9BE40012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oreny33ia78zdayasxm9xd3jebrazmq6 X-HE-Tag: 1701279224-759383 X-HE-Meta: U2FsdGVkX19NgqZfBt4kCN686sY2y3DYHPN8suTUcYdPMn37utUMtqm/Mx3NowfM9uZjGoYNnPhcLWZBfArfEj0sxCFQJqZlv5CImRGigZYaJ7HhTIGWwD4ZVKcxDYpLfVEGJx2AaOsMoR77Vc4eIAEolmZM2s2fXjBjO9+FYM0eNMRfjnvRDORe4XEfbmQlLF4W1WTGKbA8bh1DcXPo/v0OtqLIjutT/aLScDgt7oqF41G9ovxsL4lIzCcXdQhucZgb5TSrCf/NjVjrKuDd3fhkuLkUIo2xXSt5kBRqz9wQAeRrCmLPzhjLkuiiH06tmxk4BqVwgoxIXz3LeRQNE+WZuOYDbJEDswc9mkXlchi7qEKVLbzx+dSVW8gh1nFmkdaq8Qilp4F5x+PNlA+WMW4zJttgEhJaelNY2rhPV/EbMUHo3ieJOoBcjoTWFZ+AQKk1gOBKMjpNiAdqgKKpbeC5RpoAJ8MuzYE4UkVKgsl5tPRtOi6HuIFu7IqjaC6IHavoYiD7+Z2aqLzSRaWQUVFgnROiBMJdkDbRqUwu4jDRsY16Qc27AubeuqtPVcqZYHbK38NrIm0vArHzS/1fERqkQSNWlNYZcieofbVRV7QmCQegUx5oY82shew7TArif5fmaCNv0j6R0aBgGgpPel8HpX+DTIcoEjBIqlht1+aqwZiusN3gNOTbniVkqSP5DI7zEPl1LkXIJLdKx9gRZ5dOmZug/llkF7qHM4OTYBXjkVYErlt7+xChwHQVI7hYoHqdM/KILWskJZqUi4ZDf8hfJu3ykmXM6a6DcfiKeC0yk5r/++Fs4368eVGyI/5Bq6Yysjpvss0QrxhtcRPeaX6F4aVrdILfCEM8esoSUQKN3jC27jQ3457V9wNU5MGPaRpVR2g2HMBMhsoATH2fUxBP/vKdQY27SAHZNNxQlcvztOsgAuaaIpcfzrdG2pYIgG+rwNkis4p5/ANbC5w /fRTP0N/ 31s2THmj8Xn0mZziIyGacd5+b3ElRm1pRMM0xLzrAEQNlNtxhR5W+0/xzqpRLeEjzJ92ccmMg+IyETystjnkwht9Wi0j3uMKIbZKrjBj8JDsmjtOIkG80GfdLd0IXXSD3WazcMw4qXV1FUABPi0jqQ1bxGP0tue96iKxymBtrl06sLbU3Sj4D9/qXs9E8US8IxTpYAMdY0i5TINYOe0vw3MBFDRaYV2KEBrPMLOe2C9eDPsASbLqQ1+QuT40NTPqutX7A5B6f/MlULytN17n6A2kJrL/4tvKy7knTBO446LVDWhFXXy/F+cF8abrL3ONjPOfVylckLh4YJe5M5tnzvWFhBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Nov 2023 18:20:57 +0300 Dmitry Rokosov wrote: > Okay, I will try to prepare a new patch version with memcg printing from > lruvec and slab tracepoints. > > Then Andrew should drop the previous patchsets, I suppose. Please advise > on the correct workflow steps here. This series is present in mm.git's mm-unstable branch. Note "unstable". So dropping the v3 series and merging v4 is totally not a problem. It's why this branch exists - it's daily rebasing, in high flux. When a patchset is considered stabilized and ready, I'll move it into the mm-stable branch, which is (supposed to be) the non-rebasing tree for next merge window. If you have small fixes then I prefer little fixup patches against what is presently in mm-unstable. If you send replacement patches then no problem, I'll check to see whether I should turn them into little fixup deltas. I prefer little fixups so that people can see what has changed, so I can see which review/test issues were addressed and so that people don't feel a need to re-review the whole patchset. If generation of little fixups is impractical, I'll drop the old series entirely and I'll merge the new one. Each case is a judgement call, please send whatever you think makes most sense given the above.