From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D34C4167B for ; Wed, 29 Nov 2023 00:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E176E8D0019; Tue, 28 Nov 2023 19:54:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7378D0001; Tue, 28 Nov 2023 19:54:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C677C8D0019; Tue, 28 Nov 2023 19:54:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B2ED18D0001 for ; Tue, 28 Nov 2023 19:54:55 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8E87FA0445 for ; Wed, 29 Nov 2023 00:54:55 +0000 (UTC) X-FDA: 81509172150.27.E726C48 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf09.hostedemail.com (Postfix) with ESMTP id AC10614000C for ; Wed, 29 Nov 2023 00:54:52 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=fEko6jIz; spf=pass (imf09.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.47 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701219292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KD7A1Mi78WcdpTbacYeqydWRhhJC6MIZ9wADFHK3ceE=; b=iz41sZ+XkorEyIx1ebOV3I4FMRI4AP865OzB05PiLj3hlWYSjQmZKUVoCFUQQTFGFlSMEL hBas9jT2YMIZW0TjsECBYyE+7b5sVdzql2FU7nge1m1DMHPCIWTPkx70cBMfICKtzDT2Zg 62lt3vX0XhAh4P+242DFTzYE3Nd/tGk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701219292; a=rsa-sha256; cv=none; b=FNSvE4jgpKdCu5NVJOGArb6zeOldEtlIyzsrmP02Y3Gxcxe/aguoINI3MDBGNVnlIof1sQ okAP2QpKfg2EWK4mKnTrMrIMfdk1JK6i19yNCjigV1iHrVI6gMlpUYvKtxb7IvnhUvEJRr kNdllIcapL8xas3OdtAinC2/QFQTVaw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=fEko6jIz; spf=pass (imf09.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.47 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-1fa289a3b6aso2221006fac.3 for ; Tue, 28 Nov 2023 16:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701219292; x=1701824092; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KD7A1Mi78WcdpTbacYeqydWRhhJC6MIZ9wADFHK3ceE=; b=fEko6jIzOafibB8POvy3El/HmaF3XGQb7rAgASvn7nVFCQ/q5+2aC/Nz7bHSTeVeDK tI/s26QprVlyBP6bYbMu7ibPOkcmcn/0XVmIsb32Obu5WtYy4liySxzZRg6nrSZPF3FV ip2PR/bp22oF+N1jNjmRNpiFRuiTK3hZHUnN5gTR9u3y8JRN8DbR33YkruJQ6svr3CHN Fu3/Axwo9Pvd4DSrdOMELwTDE3AtyV2zqpGfdPJKWe++2u+z+tRgloLc7z6zlPy5KzBb uOI6flbopChWV0CwyG1aO5yIFjdjxWGJvNs3foT60BZ4PYJCU3Z7MLag8jPP1+ojo97f DiLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701219292; x=1701824092; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KD7A1Mi78WcdpTbacYeqydWRhhJC6MIZ9wADFHK3ceE=; b=RI1Y2rWFsMpL7/VmaK5GdZObQXfKMVw0WBYQ0n+3/TCPsXczjJvqQIh17At1KmLNdL e91J8AJaHZfULHJcgW6v3wodYU2sEWlt2YknCdTDo2QFWraAqTg74/ddoE0PhrAqSOXZ e86EKUfLlC3uDertoCTis7WRhtS0Rl3dI5nwePjTb86SYHLm2uFrvbsg8oUF2gT9Kxg2 O4NxxbrP48YskN59xkE8RjxE3Ujj+BN7IQFaSzA1QdlZDwOXbIA6HAAqxMwOMWo8Q/Qj QyXBZgsUk53UZjawhQB0Xd3FVhaE8aRDEKUztyiNTCEflbIBX2XYm7/Ba7G8lg7DMOM2 jOGQ== X-Gm-Message-State: AOJu0YztxDrS06Hq6qmqCTBTtEvjTZwYBIhOz5HR0ynL3ph+V2GbEV5t CGaV0j6ZujtYaEYC+koinhGJWg== X-Google-Smtp-Source: AGHT+IGKiwEuykqxh29J1y1VqvKSA4pC1uEUHtE7SoQBvdHo0iXpRqPiFg8DX/ZmKtSwphh/2Jx77g== X-Received: by 2002:a05:6870:c690:b0:1fa:2f8:c734 with SMTP id cv16-20020a056870c69000b001fa02f8c734mr16951479oab.5.1701219291679; Tue, 28 Nov 2023 16:54:51 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id b1-20020a056830344100b006d81e704023sm945291otu.2.2023.11.28.16.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 16:54:51 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r88qo-005kIY-2m; Tue, 28 Nov 2023 20:54:50 -0400 Date: Tue, 28 Nov 2023 20:54:50 -0400 From: Jason Gunthorpe To: Yosry Ahmed Cc: Pasha Tatashin , akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Subject: Re: [PATCH 00/16] IOMMU memory observability Message-ID: <20231129005450.GH1312390@ziepe.ca> References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128235214.GD1312390@ziepe.ca> <20231129002826.GG1312390@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 1ycpmxk3wfyxfx7ofinpuwzwdxf6k93x X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AC10614000C X-Rspam-User: X-HE-Tag: 1701219292-671886 X-HE-Meta: U2FsdGVkX1+eAZ2WRxT7r3q85mEw+M2mUl5gr3DB6rli1eo1grss0ZD06NLt2MCzUEUfxU5tWOa78u9fEfeHCKcLrl890tpVurkNd0hdd+pIVc3FVkOLXm3ttyRm356bmXM5b6UBw3dJxotP8bwVmKFocu9DecLgTDxJ2VXVLZfvH+zBNgAlxqKeLlw6DXXl8qOaPCf9Gjk48a2qCDbs06FAonn/kCYg/yCZ56ycGDHaSpmsD3p5eJpeIWiYt7Y84sjo7AN3agBaO/TisV7WLVP55l8CkHTCaq05htnf5KD3yzZPjuOENShfs59iLKkW27ltR7p0p7lOqd5nBUBg7NVQ19HYZE1w0oltPbAB5UpG2Y1F7fA9yMBX12WFWcIJHXGPFdhmgbdfUT16QgZWBK2CvVajv+xi520fNtDxCfYbh4T7kb1dGiv3HPHBE8FNkdexLKvc77WFM/SUEYxUztKYnAQZhIBMyq5CKGeTwmT4S6Zz4qZEx9Pq9/SVyFZnwNdFpUwth/9/GDcslz4dxVcjxntDdDrYvQRV8cc8dtpG/GlaoQN2JzESFyv5dYnf1r0YQj0b5mgVA6Yl+NaneRllKA0JrfBNZlvGPN5euWGl8nK0DguQVuBIh1hj6PI7i+VTGDxnyYYFUJxhmzNeCEYZGVPwCd937ZhYrY0TO7P0elcsBdPkPXnsiy+GeotW/1BEc1OrPXBg8/6Vk5w3O/DlcrPGYhjjDAu9b4JrUX4a2Q2DC4pD/C6bpY+zjnP+V2/LhSSo2GTcoqr7Cwhp0lYphfLIpjm6F2pIt73JgIZSa5cyrQCb8XKTRJAm+F6aMo18DSTWE/br6pj6d9zrS5XiYrIXIK6wCIMY/CStS8vkC3XSO1llhqFk+IOCgC0ELS178joI1EWSTx+6SiZ65vdePfeP9fRaOttitvOM3bmuGvLRAFqO9gXS9spDOfN5odykqlrV3plrNV5jsGM V5n3MLjy ugHS1YI8z1kKhoF7tREPkexbHFhND6c7WPFqRCxNHkFGz9yawvzRI7EHiee5YuUh9IZXmfBQETRRpfyEPtV+jC/1bPeIQ2kTcbksGYz3iMTi8Z8x1UDlxwlgCvoU0iiOJb8ucd8K9QaBQ8qBseqVa23Ubk+JCFXFQS3s9/lpsASBbt5LhNxMFEqqVkAGwhYN/gxNozBts23QfqzpkSjEi+3aR9nYaN3ntqlF5nMR7qECJNgjazw0qMYQOKszaq6qIIEBbh3oT/6bpbXg3VpK/uK3TTgYeRhXHojyii5xtsbvSieaA/dZiCjEm3WeQCX6yyUhxniirkgSUqpWFioKgjnqEHHxQScJe5oP+kXOILJrZI0Mz2BFgNolFJTqaYxdu8WftiG3VS/k90Fmw8y9rkMKMeAJx3/VqiI386yH3pwUPy2JpdW9fEDBeFN87sZm+R5hi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 04:30:27PM -0800, Yosry Ahmed wrote: > On Tue, Nov 28, 2023 at 4:28 PM Jason Gunthorpe wrote: > > > > On Tue, Nov 28, 2023 at 04:25:03PM -0800, Yosry Ahmed wrote: > > > > > > > Right, but as I mention above, if userspace starts depending on this > > > > > equation, we won't be able to add any more classes of "secondary" page > > > > > tables to SecPageTables. I'd like to avoid that if possible. We can do > > > > > the subtraction in the kernel. > > > > > > > > What Sean had suggested was that SecPageTables was always intended to > > > > account all the non-primary mmu memory used by page tables. If this is > > > > the case we shouldn't be trying to break it apart into finer > > > > counters. These are big picture counters, not detailed allocation by > > > > owner counters. > > > > > > Right, I agree with that, but if SecPageTables includes page tables > > > from multiple sources, and it is observed to be suspiciously high, the > > > logical next step is to try to find the culprit, right? > > > > You can make that case already, if it is high wouldn't you want to > > find the exact VMM process that was making it high? > > > > It is a sign of fire, not a detailed debug tool. > > Fair enough. We can always add separate counters later if needed, > potentially under KVM stats to get more fine-grained details as you > mentioned. > > I am only worried about users subtracting the iommu-only counter to > get a KVM counter. We should at least document that SecPageTables may > be expanded to include other sources later to avoid that. Well, we just broke it already, anyone thinking it was only kvm counters is going to be sad now :) As I understand it was already described to be more general that kvm so probably nothing to do really Jason