From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B86C4167B for ; Wed, 29 Nov 2023 00:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEF936B00D0; Tue, 28 Nov 2023 19:28:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7A116B00D5; Tue, 28 Nov 2023 19:28:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF1526B00E8; Tue, 28 Nov 2023 19:28:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B7ABF6B00D0 for ; Tue, 28 Nov 2023 19:28:30 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 943BCA040C for ; Wed, 29 Nov 2023 00:28:30 +0000 (UTC) X-FDA: 81509105580.17.F8784CE Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf08.hostedemail.com (Postfix) with ESMTP id AC76C16000B for ; Wed, 29 Nov 2023 00:28:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iTFMVqAY; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.161.53 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701217708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OMYRcf/Kii/rrCclUYaD6+8KP9DIOITQj8zQjAaRv7g=; b=yy2Kxg5pZPCdpKLIZdBOSS35um8rPMzyArIWa28XLrGzup7NgfYsCFCd87aIZRNZswxT3w qwGWE9mTQq4m+Hqr4/CuUJcqgDomPcnc83Lc+V0vC51YL5rHMTGqHH2dCJ1hmsgbV5YQVP E/HUgL5G7oB9/JgVIPL8sr0erqR14Hk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iTFMVqAY; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.161.53 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701217708; a=rsa-sha256; cv=none; b=LONlR/yspFHLeP2HwOnnoc1tXJGBqb+K3fS1p1F8/IOZum3o3KpGi9qr4F5uaxPQE6lB+R AuTK41v1uCEX64eG4DEfg2KDzKv+DwCyOUqVf2BRz0t2dick0g339KXCm8QWZWvf6iHaaN uQoBUGHvCiLKfSFdFT7mpYQyOWo2r7E= Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-58d54fd8c5aso1901825eaf.2 for ; Tue, 28 Nov 2023 16:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701217708; x=1701822508; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OMYRcf/Kii/rrCclUYaD6+8KP9DIOITQj8zQjAaRv7g=; b=iTFMVqAYnOFKmq/d7LtjwODo3ViuQIpH4ZHNyDbDVGxK8j8R/RXNX/gO90i4lNoGxx Myst9NRZ053XSqS1YAclS8qt6/hDOGmJsMtdaiAH85yMGSbdN4slCzAwqSxYp6ALiTSm KxbghO1LvbQ1R2zcGV2OmxCC4tcWg05k0wLhjurU1gnnxUltvjXtSHFQMQk0ayGm6MJQ SIznwydL7XxQzB0pfqg56/MBd1vS1eh5MfIlxFoP/f/ry2rxQ6eadgS+5SGIfefyg3aD iQkVSydMdLK9KdEswNxY+tVdluShyWebKhDB5DeYjGQneDXa1VQwMpGmNSWuV7GRSdrI 7SNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701217708; x=1701822508; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OMYRcf/Kii/rrCclUYaD6+8KP9DIOITQj8zQjAaRv7g=; b=lGwa690fs6MCnyVyMw+MfXlKf4LV3CRYo87TZLDe8VUvDXySCzH4mIrl0Dmi5ufU2x BuPnbsP0zKUfGcuBl36S0KMwEcbycp3ESt6eDGfgOVECTo7igcCoNLPfcwgPKBcKLGeg +hbYZCBpxA5Nw8VmrJw8q9DdwV/QIhIcfq7SMBqD48CdgawzGz7pkfJh7DWu9m/G4zau gUPX/dEihvYoYjg3fpB0DiifU8OxszB3RZrvkN2guS2fXJDzxQTDigf9x/o639SHrNbL C/lHe/oQ+TgFFig/bvxTZmRAspYbuTHtJe+oQMyhLUgzQhPRSpDnzcISzp3DUumNTShG omWw== X-Gm-Message-State: AOJu0YyO/P9F1EHGNFEaTOTD0bF6cx6m2Ld4n85uiimtIdiyGgeANxsn DZzOldgfa8MVLd2qYsCdsACN8A== X-Google-Smtp-Source: AGHT+IHxOFYr1Wu9Fd6OY7DYtdTti5/c4rkTAyn2SfjWCS9pDJNiXdB/2NGtfvjIa+mQCcwPiiU58Q== X-Received: by 2002:a05:6820:1504:b0:58d:97fb:cce9 with SMTP id ay4-20020a056820150400b0058d97fbcce9mr7193926oob.0.1701217707699; Tue, 28 Nov 2023 16:28:27 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id l5-20020a4ac605000000b00581e090fd1fsm682626ooq.8.2023.11.28.16.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 16:28:27 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r88RG-005k2k-DG; Tue, 28 Nov 2023 20:28:26 -0400 Date: Tue, 28 Nov 2023 20:28:26 -0400 From: Jason Gunthorpe To: Yosry Ahmed Cc: Pasha Tatashin , akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Subject: Re: [PATCH 00/16] IOMMU memory observability Message-ID: <20231129002826.GG1312390@ziepe.ca> References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128235214.GD1312390@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AC76C16000B X-Stat-Signature: b3zgmfmfbybnnrat7db4ai5tau8hc6yj X-HE-Tag: 1701217708-806017 X-HE-Meta: U2FsdGVkX1+6+rgJ14td4rcebYHOnym5OtuQeOF7OwrgRniH9cIQ7IBgmtxQbmkRy8WkmMnwp3xYotOgHImY9m8WTu8cigNuGWEYxSFUbZ9bQ1xn3+y6iAbMoOCjoRbDZjZCKICaGqcPAWG9JykLG6djHogCPLhlb5G4ZETICfs9tDvkCTTFDAG5VEbz65nEXG2c1uWX6/gnQE5JsKk7Ntby/wkkXNCn1jXlMpDUl+Ktn3W87IISeP0PsqGgGJOO39PZDAgqFJMjAhK6DJBG/dietDr0b6iZ11RK+1tCIaZ51IWsKb46ANw/ahwyGNBG2NWPEJ6dNLnXvvyUNFMuMPxxlMA/HJ1B6aiF/QZM6QRB00I9uw62IFUGRbXTpDEEQzmvHOfBT7JDUMkp4bIqE2Yy25m7k4f+ounUU8YVtgxcKgl34RsB6NVO1IIXzP2UqiFAwngIKAN9xf+73K8FnlrS+fR4SYVwuMD5ipmM9tPYVNpsW+3hLcQGDEZwNKfTHzEkljnvZii/lfVBo4RpjBvjln6Poq9RtbRFiKNSxMlM2usjtjNPw7MxYd7se1CCzqlGwauFcGHJgV6Hs1ZHUVauyGQDOWRsSHYwfYBIxSachYyfnGFvZ4YhZea+/lvEDK5Maq4VAp7Wgv0Q9dxvoLEUam6ShSziyXmh9xIZw2we+HCHAIq6+kpsCItJQM/PA7+PGzeVYwrzgcY/Hj5Vl7gJGh1maPizuFa5jTH9JxRTjJ4tFK65V5hEH2aNYlM8bH/UEwjTaDV+jKIc+vftz6LpN0e9P3+QZ1EGq7vbWW4kS4mQ+dkYjK9KioAgk5bI8crtC/sdb6zXLrzPKmnUrzndZbFjMu3YI1uczfbwuj/RBswZ3gsu+/r/g2GKIgFAMwy/RuJ/+ZG9Wz1u1W1JTkuvDijWAxoKUkEZc79AQqjrTFUqlrqH2sI8Quosvf6V2ENtWlfiQJ2slz8telr a9USgjph 5HsuQ0PXP+/+4P4XaYy8PaX4Iq+hApIpX8XxSaEagPhbamhtE8sFjdFFgcC6N4jWnpnpPOpp01ChMamlf7K6n5zw17dTgKhMCdFkY+mAKT4OVF1KYbx/YsRIPzn8JL82SQXmTGprQmsO7tGL+5vdIpgiZFtLGsKC3zwtrhWZVECxiy6DX4Q84VAHCdqGnXiT6NVwjKK+TOKBHHOTRMQJmg5b3s1xJXkvgpw1JDPDSuWHYG09KFzD7Ku307Gl+4IDZt9Vnd/YYE/yiIgvN2kFd+pSUrxPX0eFKvc1MYysuuZ/5ckjxfuvpCPujk5/fiKQo18wYjKM7Vjggyi0AbfGbuYP6BKjAanRKKcWRu0P7KoV9ASMf8CJ7A42tgW7JyYdUjcBQmRR1bDI4dnU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 04:25:03PM -0800, Yosry Ahmed wrote: > > > Right, but as I mention above, if userspace starts depending on this > > > equation, we won't be able to add any more classes of "secondary" page > > > tables to SecPageTables. I'd like to avoid that if possible. We can do > > > the subtraction in the kernel. > > > > What Sean had suggested was that SecPageTables was always intended to > > account all the non-primary mmu memory used by page tables. If this is > > the case we shouldn't be trying to break it apart into finer > > counters. These are big picture counters, not detailed allocation by > > owner counters. > > Right, I agree with that, but if SecPageTables includes page tables > from multiple sources, and it is observed to be suspiciously high, the > logical next step is to try to find the culprit, right? You can make that case already, if it is high wouldn't you want to find the exact VMM process that was making it high? It is a sign of fire, not a detailed debug tool. Jason