From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F79DC4167B for ; Tue, 28 Nov 2023 23:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D84B8D0012; Tue, 28 Nov 2023 18:52:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 188C98D0001; Tue, 28 Nov 2023 18:52:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0520B8D0012; Tue, 28 Nov 2023 18:52:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E72318D0001 for ; Tue, 28 Nov 2023 18:52:18 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C123A403F5 for ; Tue, 28 Nov 2023 23:52:18 +0000 (UTC) X-FDA: 81509014356.17.467D47A Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf27.hostedemail.com (Postfix) with ESMTP id EB00640016 for ; Tue, 28 Nov 2023 23:52:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=hQhM9vWL; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.42 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701215537; a=rsa-sha256; cv=none; b=PRZF7VcAjB7enqOE9KDu7Hmy7Y+/i+qh0iGRdiA4m/XbNkh9mi0nDivcVSRRNRD7eoX88B 74CTuXgSeYtoc/9dgT/lEByCqcvUykdB9lPxCuoEFWrNetJf+CtAyg/tbPlTZ5JSsol2D2 spipbSm4uDUDilelsGS/lmm76M3Y+Gc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=hQhM9vWL; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.42 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701215537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KGeDrNEnimmhtGEyy4xADkNVo65XsrpvCKCPlUM9+8M=; b=wHCJ78NUs1nlbzPtiz1Y8T2ijQfPGGZejg9OUFAdI6SITbmb+pB5Zx6yF4PVyJOznUrp5u +OFmkvTtB/glxyyluMseo6Hmb8g8y6d9NwBR++IVPspqzUe08nZhMS2QQHjpIEtyJAql4s XQ7HCAk3xS4glkkLnE24B5ukYDaursM= Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6d7eb7ff384so3991047a34.0 for ; Tue, 28 Nov 2023 15:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701215536; x=1701820336; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KGeDrNEnimmhtGEyy4xADkNVo65XsrpvCKCPlUM9+8M=; b=hQhM9vWLqNS1xZHi644Vm2nICC2+K6iTcn99OhT6EtvQx3JpRfSc1B0PhgcHt6CUnD dHzm4joio7qYut9oRTKv7sNhBbUQD2jpZNmOMdxqwhPFlOchkRqynRf2AUygcRZx0u2Z Hpeg0rIKj08SD7dX5lFgYfRMzpXFX2WrlzcmdzgnucBI2xLkoiO7ECilkHtQYqdQSt6r Q9HGwW39Mvg3cuVwJK9oAYwMn3GFWl9MAsQXsFPgmibdGGyyydcHvlh4QwVSrYPKQ5C8 DgcuaQ1PFbthE3R8gMaYGFX4j/p+UshzVpbuQByinUNTT6lOAjuu5mFtr56uuYr/fBAd 5eew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701215536; x=1701820336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KGeDrNEnimmhtGEyy4xADkNVo65XsrpvCKCPlUM9+8M=; b=D7rFttNdlOwLZbHmdvLCqTUpdGatFvnwZatpOcYYZLE2r+bv1OkrJ+qgz9xhJ80x9E XRlQrbIGibgG2/aUz/WlpUTkankJa/iVvYDrktofUdryLGM2EWILylHUIkWjBUB9BqK9 W8l6lHkvODOkr7fcgcyoa8YkHsfCLk/dJPH3c9exLpqAQDseaarTuijQCmwoENT19lNS abkvxGeK29AOHgLg/Zx+mgfIB66USDm1wUJ3nYVFPETR/QwDpoqg+S/fUtCv1WJyerdO VkSzdT5B8qR72k21H9fPJweiHcnkGC7sBVcXnR57QDPHO8eKEFkschuuGQIT59jj0QSt 1BEQ== X-Gm-Message-State: AOJu0YxeJKeq1L6pa1y3ra2cmc1lt8+AffePgbkJQEemdfH4yCQfxejd JXNnO/5YQdr1PARpg1IkcqrWSg== X-Google-Smtp-Source: AGHT+IH9LmWzJO7y47O3QlJBfbaegvjW4JiiPSyZGlFsMKhzquzPk2K8a5k6oldvIY99Eeb+EHerAg== X-Received: by 2002:a9d:6403:0:b0:6d6:4972:b7ae with SMTP id h3-20020a9d6403000000b006d64972b7aemr18597902otl.13.1701215536183; Tue, 28 Nov 2023 15:52:16 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id v10-20020a056830140a00b006d834fd3399sm504997otp.59.2023.11.28.15.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 15:52:15 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r87sE-005jI0-V5; Tue, 28 Nov 2023 19:52:14 -0400 Date: Tue, 28 Nov 2023 19:52:14 -0400 From: Jason Gunthorpe To: Yosry Ahmed Cc: Pasha Tatashin , akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Subject: Re: [PATCH 00/16] IOMMU memory observability Message-ID: <20231128235214.GD1312390@ziepe.ca> References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EB00640016 X-Stat-Signature: oo5hu8xi7gwyb4k331rc6a1zqms1s9yg X-HE-Tag: 1701215536-421050 X-HE-Meta: U2FsdGVkX19MPN0DTAjM/ZD3LP3d7EeQhbofUpVCBDlInDdA9y+0nd9qCTpGjsVDk6vS6f9oEvmyRBqi79FX+bcudEixCR0YEUbVExRMao8BcVxpmB2DKyRQW6tJGUlM3I/x/3eW3l8r3eck4YKp5WeJCidcOA5NNoihAdN5JwxAiW5qXfrX/PHAgowIPwybAKbgtRAYu29vxDihM76GT4226WIyXz8+7fJEJoF4PklR+0ZvlW6A++Vpp8tWWwrlCUwwQIkDaEQgiuO8FIG/+eWaeryRlV6b6l+srcYd3mzci4B3r1/1LhfvpIYYiqWq0gezYpOXAuxgUmmHMH6MvKCnM9tA1I20HiHesfh5B2NCQ1hz3r9cUTi5mJmc1RbwueIQA2XdT7BjasTuCcx71COR2mNMQB7aC80z6qTrSedJ7n5VZSYevEzkRB1cJvWQJINZ5cImYNu42Ow0NLjSY10q6TkfiX97xrpod3cVU79SW73EElYqyQL1/cOuQPFG0nGcZHmiiN0jPUPdmruDnOzQKMZT9LOXgMmVrI6RpsMWsOyY6vsMf0pR8q0FgmYs4KJRL4X7BbWbBYvEyOCRZ2Hp/aVQOB1pvA+thuWgYYzAsu8tz01PmX9SNSZUGzIC/KA1x/Dz41sLES7Lv+kBjrMfSpm/5DlpDz0/YsBKcBGXsYKAyrtBjy/jzUc0p0fp5UI90STM9cG7PMu5uRd2jBXP2Asq24Um5Wou4SJDXGv2bljObnuqKxqIz29Z5QMRwtmA8ScU77N0WUlMa5agOBOI9UXTN0Do6L+cPc7Uc+Abb7CYCM03HhjCQ6dkBF5ThTxSoqAw6idq6dSAxXVpUD7D6UccoZJh183expYQLSOjHxfM5K1rgFMXHPgtS8hVP7j8+b3jWJ0Ucrm0cANtZVZpDNyGEtUpitShLsr/PNz4fQbM6h1PSdGTlzp/3CKjTdposihcV0cJ5xvfRdy sIxpWSRi TpnHJMFem2FGjP1IblkTiVIg++81jHFSAxdt0hgkBsVqfY8Ad6r/gVOAghguaEiOoyetWWqJQOJjxAw/ZmOiRlmnw8Pki0auRc7BvATK7nDyZnv5BPYbIRLFOMNya4hEuBKb1WXZjbw/bbzCeXAd8rFT8BslhOdR78aws3L1yzSUuqJMor2VwnxNxAZ9c4jRBOtEX3MHvtrLND4e53aIKgciCvRwuBlyEW1JnyUAiLqDcqZfyPmPiBEHYHlNxzmUovypnhGaIXQ07PNWqbNeLTuQXVXdho1/5J20I5qcfDFFTnRtkWfSdXl027W9DKiCvnQ1rcp0g4Zp5jsKNUM2scRwd3X8PLBSNWy79XFJ/CpC12D8gGq/vBoq81Kq3ZRFAxyYkI5lVtJ2nLhc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 03:03:30PM -0800, Yosry Ahmed wrote: > > Yes, another counter for KVM could be added. On the other hand KVM > > only can be computed by subtracting one from another as there are only > > two types of secondary page tables, KVM and IOMMU: > > > > /sys/devices/system/node/node0/meminfo > > Node 0 SecPageTables: 422204 kB > > > > /sys/devices/system/node/nodeN/vmstat > > nr_iommu_pages 105555 > > > > KVM only = SecPageTables - nr_iommu_pages * PAGE_SIZE / 1024 > > > > Right, but as I mention above, if userspace starts depending on this > equation, we won't be able to add any more classes of "secondary" page > tables to SecPageTables. I'd like to avoid that if possible. We can do > the subtraction in the kernel. What Sean had suggested was that SecPageTables was always intended to account all the non-primary mmu memory used by page tables. If this is the case we shouldn't be trying to break it apart into finer counters. These are big picture counters, not detailed allocation by owner counters. Jason