From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100C4C4167B for ; Tue, 28 Nov 2023 07:46:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EBEB6B0291; Tue, 28 Nov 2023 02:46:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89BCE6B0293; Tue, 28 Nov 2023 02:46:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78BDF6B029A; Tue, 28 Nov 2023 02:46:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 68AE86B0291 for ; Tue, 28 Nov 2023 02:46:32 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 406AF1A00E8 for ; Tue, 28 Nov 2023 07:46:32 +0000 (UTC) X-FDA: 81506580624.11.B052C3A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id E30DFA0006 for ; Tue, 28 Nov 2023 07:46:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701157590; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ib2I9g72NLdS84pXQf4AtP1om/D6FHdeARPvZaqEIbc=; b=Zc0OirqhUClnZzhzcrHRYKuy2F/9dW25KybqzJp5+Sl8we936uIjidE/vBGHqiBP9abXSg +inJYPjiUazOh8Wox3DBYNK4ie52p8wIfxpK8LhI2sMFLswbyD5nV4NIhAf2c+3M/X+RwN 22Yzeum4iBOT6zou94V7xF7dgWW5fDY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701157590; a=rsa-sha256; cv=none; b=Tqe6dN/wrWedL5SCiGxqvmPmIFa+Iwe41GbLBnmMe8IRYqLDwDj4nu6efKjZw0inwPJq2U 7i/kXz698bCCwq+oOGaPQdVcrUk/ZJjkqAUOksX+Kg4GLz5Ki4sgh0I0reUVvc4sDSzArr wLNijygicDpMhiPY+RRaFJJr3q0tLTU= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA99D1F37E; Tue, 28 Nov 2023 07:46:27 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id B50CE133B5; Tue, 28 Nov 2023 07:46:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id IF0NK9OaZWVXNAAAn2gu4w (envelope-from ); Tue, 28 Nov 2023 07:46:27 +0000 Date: Tue, 28 Nov 2023 08:46:26 +0100 From: Petr Vorel To: Stefan Roesch Cc: kernel-team@fb.com, linux-mm@kvack.org, david@redhat.com, oliver.sang@intel.com, ltp@lists.linux.it Subject: Re: [LTP] [PATCH v1] mem: disable KSM smart scan for ksm tests Message-ID: <20231128074626.GA298624@pevik> Reply-To: Petr Vorel References: <20231127174517.2369593-1-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127174517.2369593-1-shr@devkernel.io> X-Spamd-Bar: ++++++ X-Rspamd-Queue-Id: E30DFA0006 X-Rspam-User: X-Stat-Signature: o35tbg86t99r85q1cbrxhaxe1jrpcujk X-Rspamd-Server: rspam01 X-HE-Tag: 1701157589-735118 X-HE-Meta: U2FsdGVkX1+wKi6VXSXm1eFimXwCAEwQikWLoLxkiDjS2XKuMhwPHrxHMTFc0J7ovTkNdBqXBx1LuBUL5LAGiAIo6OJS6nvK9VOySJFLHUtuVcznho8KAPKXtX0rVuQtNGimeZfJMEQ7A/OJ8bAbkhCcswPuIWhiJMwhbvHg0nR47jLErOJTV/ou/rn1SAw+EwpKJlr/20aLlWMQ9IMwEkr3hAAGpJ9BJQcBu+iu8Ks/HaUwDaWa2b6DZFvj+wAccX8wvgnXm/ECse6EpUKuADTzluXKXSlY2r+wDMySkC4CSZjgC8EWzf+FVJqbXuoQIDQEuyRt0/+9hTroHrIlLed29kMjTtPG43qY1TpxIOiushsLI8/9fT/KaJqYBkQ9pQukV+tGwWJx/4yuGwuH1tQe39CoRKlioQe7ee4EJYoCz6Vl70vIYBtE8xMCVFNrujIWsj7lmz6Z6A+57XvqgIP+w9idqLrjtfGfVvBUB0hFeCW48ihOnsNQ13qALprmzodIAapeMRpS+p4lgPltaGJYDjx13G08tg69lxC7xrsgZNiSWBCNFlrDrzuTDujMdlV7DRYNi11bP05rsOgf3QyuVR1kuXzsDTFfrU9p6k5DkPIg6geJrckINtdeL/JXGbn97/PvLFyrNzUA4aHMJwhsXvWIbBeyiRp/C7ojA9mbacV081C5FsFaGW8kPH+/PY81NHiF8ZNWg6dDQ6Vll0UEmAv/l9r91LKCeDeDtEVihV7C4AYqMRqMSyfaQZj3UhgpqBo/qHHWvzT6OwGpaQ9HzNX2E9e7DLAbeY7dwMVC7y7avh//vB9uUOhj1002TVRef8m50k3wvGtCSj6NXTUPZaay5+BHQwVOQbKwWTdVCsAziI0TVoHqDFgjV6/F1AG0QnZzwZMFrzOwA7h9G+xI/QGk/t+v/0fo7lyZVo85nw/YHUm7aAWjlWSiiGQGDE8NiEfuwyiK3db55Sk 6s/bLwfQ i3vOMBTofhFhvxu1pxFPPA3Mwqsj84meOct+I7Ln9kiHNulL8NW/Vfn0N8P+DSLPNAzOpr7GHQ1LU2wH4qo7a04An01R1RVZHNAACc3PyIFrjsCmeTDCFBWsITl0F5BifPVQSQ7/64qLG1KZFXurs84F8scrbZiTGBS09iRH2hZPQ68FUq9IkWlvicicEabVhMk7gHlhPWlcyaFR4kzdh0kNPfpFvDHnc9QfktM9KuNpkWbOtMnT2HxV3LM5qwIXVIlfJ4/b32Kq5OtJ4JPPCjgnwWLAC4tYLC4cXUxa8A/9smi/pGAdb+LHKWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Stefan, > This disables the "smart scan" KSM feature to make sure that the volatile > count remains at 0. > Signed-off-by: Stefan Roesch nit: you forgot 'shr@' Signed-off-by: Stefan Roesch > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com > --- > testcases/kernel/mem/lib/mem.c | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c > index fbfeef026..ef274a3ac 100644 > --- a/testcases/kernel/mem/lib/mem.c > +++ b/testcases/kernel/mem/lib/mem.c > @@ -454,6 +454,9 @@ void create_same_memory(int size, int num, int unit) > {'a', size*MB}, {'a', size*MB}, {'d', size*MB}, {'d', size*MB}, > }; > + /* Disable smart scan for correct volatile counts. */ > + SAFE_FILE_PRINTF(PATH_KSM "smart_scan", "0"); NOTE, this fails on the systems without /sys/kernel/mm/ksm/smart_scan: mem.c:458: TBROK: Failed to open FILE '/sys/kernel/mm/ksm/smart_scan' for writing: EACCES (13) NOTE, we normally handle the setup like this in test setup function. But new API has .save_restore which is more robust for tasks like this. It's already used in ksm01.c, you need just to add this line: {"/sys/kernel/mm/ksm/smart_scan", "0", TST_SR_SKIP}, (instead of both SAFE_FILE_PRINTF) See: https://github.com/linux-test-project/ltp/wiki/C-Test-API#127-saving--restoring-procsys-values I wonder if ksm01.c is the only ksm test which needs to disable this. also nit: there is a wrong indent (spaces instead of tabs), please be consistent with the file content. NOTE: while this fixes problem on 6.7.0-rc1-2.g86e46c2-default (openSUSE), it does not fixes other problem on 6.5.10 on Debian (16 errors like these below): mem.c:252: TFAIL: pages_shared is not 2 but 5038. mem.c:252: TFAIL: pages_sharing is not 98302 but 593629. mem.c:252: TFAIL: pages_volatile is not 0 but 391. mem.c:252: TFAIL: pages_unshared is not 0 but 149157. I have no idea if this is a real bug which needs to be fixed or test false positive to be fixed, or whether the problem has already been fixed in newer kernels. > + > ps = sysconf(_SC_PAGE_SIZE); > pages = MB / ps; > @@ -526,6 +529,7 @@ void create_same_memory(int size, int num, int unit) > tst_res(TINFO, "stop KSM."); > SAFE_FILE_PRINTF(PATH_KSM "run", "0"); > + SAFE_FILE_PRINTF(PATH_KSM "smart_scan", "1"); nit: Again, wrong indent. You could have seen it also in the generated patch. Kind regards, Petr > final_group_check(0, 0, 0, 0, 0, 0, size * pages * num); > while (waitpid(-1, &status, 0) > 0) > base-commit: 8c89ef3d451087ed6e18750bd5eedd10e5ab3d2e