From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212CEC07D5A for ; Mon, 27 Nov 2023 21:43:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FBAB6B02CF; Mon, 27 Nov 2023 16:43:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ABD26B02E5; Mon, 27 Nov 2023 16:43:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79AB16B02E9; Mon, 27 Nov 2023 16:43:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C1596B02CF for ; Mon, 27 Nov 2023 16:43:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3570BC0239 for ; Mon, 27 Nov 2023 21:43:05 +0000 (UTC) X-FDA: 81505059930.21.5A56951 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 36B73C0009 for ; Mon, 27 Nov 2023 21:43:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RERa00m1; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701121383; a=rsa-sha256; cv=none; b=TeCwbywJjPkFsW+77Y0RTn4g5o9ZdYXM+8JhEL43X/UOMHYPjmX1aGlL7XV+HhhqVq0wrq M8yC3EiQWynkfuM9Lh0VGUIlaFfHB1/XBDNVjc0KszciEwpAb2+hFKCh0/IbvvJEII5Sdy W1GAzM0YFMShVM5cBmhMU4ELg97wvfQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RERa00m1; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701121383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEpbcQ7rfwN5p4EmqqQY+zarCT+chYj0E60/HtzFT9I=; b=yjRSvwnykjNMicRndV+bb/BBzE6s4Hpvg/Eh4uszuI8HxF5xRmqX+5Bayn3cuae9F2NlI5 tPCkZELr5Ysj/cObveAeI3CJJbcYxO/fHlRMBbFoJ9EpZOnn5NZcCfysEGuJ0dL1RoNVli Q+2Mnf11PDwC7xPqBbPijp6KrKBeBEU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8B570B837DD; Mon, 27 Nov 2023 21:43:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A920C433C7; Mon, 27 Nov 2023 21:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701121380; bh=CoO2w1Aaayjts+dtvAb8Eh6H5/dRtPDx1TPM+uYjYAI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RERa00m1APTZ4nW8M04Rfr5i0iygE8BDQ0e6DmhSMgrHZ7Jw8YuA+xtP69/WxezsS rJMo7RPAVGmSaP6y2uf2uCKw0+eW38cOjgSScmhCD+QpioQ4N661eUERXRrVP0Lsvr wLF7BGf+jgv/d4EqPdkzSwHborOYqRliIGg2SYhE= Date: Mon, 27 Nov 2023 13:42:59 -0800 From: Andrew Morton To: Nhat Pham Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH v6 2/6] memcontrol: allows mem_cgroup_iter() to check for onlineness Message-Id: <20231127134259.67b69ab47f4f88c9751e5222@linux-foundation.org> In-Reply-To: <20231127193703.1980089-3-nphamcs@gmail.com> References: <20231127193703.1980089-1-nphamcs@gmail.com> <20231127193703.1980089-3-nphamcs@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 36B73C0009 X-Stat-Signature: 49hfipud4pd3fimytawkttyr7r1hr8is X-HE-Tag: 1701121382-967390 X-HE-Meta: U2FsdGVkX1+n4JKOWL4+qGoAu7SfD6sXSivo0HJEUwWUWhXdEmp+X97hbOfd9E1x0C3cvNJsMyeYtOPkGGN+QMhBEMiWR6CToN1W50qnHS8HT3DYrYkVSgb3f7Dlp+tXsBhhniXBu/iCpoBslsPqMy895y969PezxwZkQWmsqDfUmZsr92qA3Qjf2OWQWeE9fHu625kcu03/6bkssLCKfhBheEUeopgfGH6IQ4x1Q0I/vH3vIM/Po2LkDXUP33Cq+NLMVVzkvqbD40usnHviPcAxxszGogglsUIKTwop5FxPhkUnxt8CQpRqaGlnRXHuNc1h87liqE0UeEJPoA7Lqg3a0Piyx0zhkbCBTcdETYASQmclmwfNtLpjFaXPJtt3ewcPt8MeC5ggMtBjP3cMdvQAOa2abZKh/oXZwl6L+Kj/t3jBIu9aPphrZh3rmho4b39AAzgS5Uv+JUl4/SIAu5EebAQ1zVZRCFVizfK3aAr4ie/6aAKQADR88Kh3n5Ts3Cc/KnbQQymZBpZRLK23C/J8kw4kAQP65ZwoXbpF6Qao8AZ6brXCtu1rrJr+6ZlxwMVwEAJEwIEl8OWAdHV7IPvvRC7+zoX0gXkZLyRzVkNO1DbA82Jf++IOo5VlzVAT7xadgAY0pezk8UT9TGHxNw+GVxEbDv0Y+vYJjnKJCad8dhzmYW1hlLTFQS6XVSA/7vZsf/uvFBOJDwtiRtm3JKm6tvgakicXOC2B8ypOtmJ60gosO4lOvKqM1vFz7z1p8DbDT+ZNRvBDbl/OTHLz4P9odMOcAWjJFMRjzPQmEZLrzVSSbS7xVBN768abqDC4Dezo2Zly24V/SQVETL072iD8P8SIcPxOvQbLvtxG6vS8qkxu34u0YNKSPwW1Dd0pKdbsTI4D9PptxFYQbBkkWkeehkFcatY+iEtnMWys5CKW/XlUefLMI0mgW1WYuh/B8L9SUqkTN11oyGQfA7V K1HcTPgS umSEm/ZY2SPU217HEXnZY+T3Kk/snrqZ9XzFQ+mCOB8F9MDsHhBsJUls3Uw+F8X8fDCn+YGyPANr2zK4GPOzL724ccYz+9TSz0wt9b2hNgWvm8dSvpfrOuSrQoMK5nTZlZC3eAT8sFq1je/02y2BNW8YsAAl5V6eHmsm9MrLWxCIMflaSqP9gz8TtwRColslXr5gkSQb0FqeHlF8lyw3HGLUXM+MVGJ8FdXWulJUhWBzjLCbYzT7e044/4Ee9PfOpOYJtjn+77wIzDz/MtHoaCYguHbBf3CbphXQyPBUJtzhypc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 27 Nov 2023 11:36:59 -0800 Nhat Pham wrote: > The new zswap writeback scheme requires an online-only memcg hierarchy > traversal. Add a new parameter to mem_cgroup_iter() to check for > onlineness before returning. I get a few build errors, perhaps because of patch timing issues... mm/shrinker_debug.c: In function 'shrinker_debugfs_count_show': mm/shrinker_debug.c:64:17: error: too few arguments to function 'mem_cgroup_iter' 64 | memcg = mem_cgroup_iter(NULL, NULL, NULL); | ^~~~~~~~~~~~~~~ In file included from mm/shrinker_debug.c:7: ./include/linux/memcontrol.h:833:20: note: declared here 833 | struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, | ^~~~~~~~~~~~~~~ mm/shrinker_debug.c:89:27: error: too few arguments to function 'mem_cgroup_iter' 89 | } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); | ^~~~~~~~~~~~~~~ ./include/linux/memcontrol.h:833:20: note: declared here 833 | struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, | ^~~~~~~~~~~~~~~ mm/damon/sysfs-schemes.c: In function 'damon_sysfs_memcg_path_to_id': mm/damon/sysfs-schemes.c:1594:22: error: too few arguments to function 'mem_cgroup_iter' 1594 | for (memcg = mem_cgroup_iter(NULL, NULL, NULL); memcg; | ^~~~~~~~~~~~~~~ In file included from ./include/linux/damon.h:11, from mm/damon/sysfs-common.h:8, from mm/damon/sysfs-schemes.c:10: ./include/linux/memcontrol.h:833:20: note: declared here 833 | struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, | ^~~~~~~~~~~~~~~ mm/damon/sysfs-schemes.c:1595:33: error: too few arguments to function 'mem_cgroup_iter' 1595 | memcg = mem_cgroup_iter(NULL, memcg, NULL)) { | ^~~~~~~~~~~~~~~ ./include/linux/memcontrol.h:833:20: note: declared here 833 | struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, | ^~~~~~~~~~~~~~~ > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -832,7 +832,7 @@ static inline void mem_cgroup_put(struct mem_cgroup *memcg) > > struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, > struct mem_cgroup *, > - struct mem_cgroup_reclaim_cookie *); > + struct mem_cgroup_reclaim_cookie *, bool online); How many callsites do we expect to utilize the new `online' argument? Few, I suspect. How about we fix the above and simplify the patch by adding a new mem_cgroup_iter_online() and make mem_cgroup_iter() a one-line wrapper which calls that and adds the online=false argument? I also saw this, didn't investigate. drivers/android/binder_alloc.c: In function 'binder_update_page_range': drivers/android/binder_alloc.c:237:34: error: too few arguments to function 'list_lru_del' 237 | on_lru = list_lru_del(&binder_alloc_lru, &page->lru);