From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E4AC4167B for ; Mon, 27 Nov 2023 08:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23E736B0322; Mon, 27 Nov 2023 03:27:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EE736B0323; Mon, 27 Nov 2023 03:27:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08EBB6B0324; Mon, 27 Nov 2023 03:27:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB2DB6B0322 for ; Mon, 27 Nov 2023 03:27:37 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C89CE1CAB27 for ; Mon, 27 Nov 2023 08:27:37 +0000 (UTC) X-FDA: 81503055354.14.941D0D5 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf03.hostedemail.com (Postfix) with ESMTP id E09092000C for ; Mon, 27 Nov 2023 08:27:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PcxTFVqk; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701073655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=12pAzWJJAL9CEsKClU9orc2LqYiIa3VtbG+bAji6D0k=; b=QWAQcTGrIMsmrlhu2EkVQqHjv5v1lFktTr2xq3GR91P15kjraxuImmpPZoYdagMs0NApRk /fW1YZLz7AdfBsTAs5Hnka9r1m1MLMtFB5FuHHnuWegHM+Ip2ILz8ekDDMvuSEX6L4Y+NG kDGSoTMFyY1TwyRxh/mUZslwV5IgJf0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701073655; a=rsa-sha256; cv=none; b=grRM7aDYrkbxe3XQ9E3TQ5Iybe5klkvoQ5ud22YqnzmSXriXnI6E2w2vimoAwhOvVG+QcM 7hlZfNkwV3ykRa2tyuLRhMBRReKAZLG+f5qH8XvwEl2jUB2tQEOHWeIbGnR3Rc+uyAbQDF 4ZRykduqXNEuUjYZiYTWEKJxU5y+rkI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PcxTFVqk; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6c431b91b2aso2935401b3a.1 for ; Mon, 27 Nov 2023 00:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701073655; x=1701678455; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=12pAzWJJAL9CEsKClU9orc2LqYiIa3VtbG+bAji6D0k=; b=PcxTFVqkmgCK0H8wz4UUUxtWjPzPaTDa145PTWE+GibMSccDO/24Gc7Tb+aE9ZAuv5 /Noym38ok7HHADfVdhRC9e65OyaGCusQiKQHkvlKUxhU/o0REy4W7oDk+/VRwHW6ECDi QhSK8+ZNoMGoZIR+Vq8RZ2hg6SsQA7uac+eCzH79idGSlst/wKPa3blPYLVKxZJeSd1u JcVbeMXZbFD7IrNNuSe11i+NJGpFmO7Lk+gbflJtDwjst5co7pgRLEQvaCcI+YtZiJMC 53ZaOMJmZoJy0q7YNm1IMpSIS39dxHNEm8Z1FgL1BFWEOWg2uYPQkJc+s7RsvJHLPRNm KKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701073655; x=1701678455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=12pAzWJJAL9CEsKClU9orc2LqYiIa3VtbG+bAji6D0k=; b=oz3Sx1EaQDkWx/43rPtgqr1E8nvGX11biC5pKZ2shpmC7/aOZ1UnG6CSNOT1QdzYm1 F39UkWNxXRcpJKa4IocBj6qkaHZ/N+oFcMrg/qyVQ8uEL6xiWtN9UX3hltNkvVJat71h 7Pzto4ygZfodlRp16N3wyKzUorixVkRC1gTbUmIaCzyA4JHenf5HnO+fYOue4UL5FP9s 2Ie/ZZm82CL6Agdf7myzcQfNsiu4VzcsF7fn11H9MY8BS2uaJ5MfRLJmcZh0nvLGQYO7 SXjXbrsL7FypmU3UbYIhQtR3LbNokm5FaKnFwAs/VSn+sWM/aa22uZEox+2fA2uF03qE GZqA== X-Gm-Message-State: AOJu0YwUpcDSpSo6AbToq6KAaRPpJvJjpqlLvof4RR/JNyyGuV+BBbr3 +1/ZjtFEWqdwXgQJ0HEFxQM= X-Google-Smtp-Source: AGHT+IHnl4BHxZBeCv4Dm3wpOycnDFVQjCWcpTbEYovka2o7m2bvyuyxSJg80qjK9+X/ZTtZ5Qr8+g== X-Received: by 2002:a05:6a00:130f:b0:6cb:a60c:1d with SMTP id j15-20020a056a00130f00b006cba60c001dmr10109127pfu.17.1701073654731; Mon, 27 Nov 2023 00:27:34 -0800 (PST) Received: from barry-desktop.hub ([2407:7000:8942:5500:19a0:3eee:b37f:15f2]) by smtp.gmail.com with ESMTPSA id c16-20020aa78c10000000b006905f6bfc37sm6694946pfd.31.2023.11.27.00.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 00:27:34 -0800 (PST) From: Barry Song <21cnbao@gmail.com> X-Google-Original-From: Barry Song To: ryan.roberts@arm.com Cc: akpm@linux-foundation.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, david@redhat.com, fengwei.yin@intel.com, hughd@google.com, itaru.kitayama@gmail.com, jhubbard@nvidia.com, kirill.shutemov@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mcgrof@kernel.org, rientjes@google.com, shy828301@gmail.com, vbabka@suse.cz, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, yuzhao@google.com, ziy@nvidia.com, Barry Song Subject: Re: [RESEND PATCH v7 01/10] mm: Allow deferred splitting of arbitrary anon large folios Date: Mon, 27 Nov 2023 21:27:11 +1300 Message-Id: <20231127082711.12885-1-v-songbaohua@oppo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231122162950.3854897-2-ryan.roberts@arm.com> References: <20231122162950.3854897-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E09092000C X-Rspam-User: X-Stat-Signature: p1k51a41c1a4x4or1sos1rqosprcpttr X-Rspamd-Server: rspam03 X-HE-Tag: 1701073655-609353 X-HE-Meta: U2FsdGVkX19uX+nl0TWFvYqVp0uNVlKiSWHlJt0yg/J/+09RZkogxA17+88W0A100JU0/enJ1iUfc7ViuteZ4t+Rqn0LK3zo//IifAwUTyY4OGEH7nCPKmll0ZKQsKDw0YddlE1dPJcFxAzF6noLeNGsZu87etyXppDVoJULykT7R4pAZc4dnOGNJtDlxLwgtj09g0aUIjvhk7EewhMY/J1j/FPKYBHsD31kbEoIi1Pu44JfqpRjstV+yr8S4gB3gtKpgnSIv7xtBn/PHL7vbZEbkXMJWjN4BRPV+MDN0uFcSBZkh5sxVx0Ewu6Jc/HnNcG6qkAf7BDeKYTR2+qKN1qoY9JLsJw/emdoJQ8ip5iguLq/4k8YCwXwHgUJV8/2fvU66ZSIzp/3TfO8B29kd/ni9TDwLJj2B+WWWIElvkvgSC29VIckTZISRQNyudG5Qy7eNqysGr9w4419DtfX25p3oqxxdzCEcNAtxVID85HBkVqgUuA6QIzu8rLi2IdYzo6NYiIjKV+Aa8KsaNrtoW73RuoY+VCNrmM094OaIhgOet3blxBWICW8nUCq3Pf/vryB+sOXBuSPz32yGN9HU9Vj0S5bet+OMsm9jSr+b+QPZ4cEXUmwhY0PQ78r4Itme3YIwcAaqfXsQVTd25IWyQGkHTLz+Y7a30gPMxyLfWqsJ6yqObYMaQkJ62jt+pegSWYlN2EMG9CSale7CnNddDmWmaYTjpfsHrrsy29rwpGwmfWZSD/3mB+r3stR02rPYLBvJCd5e/OmL6qmK26T/eO12pzEeyPkADyEOxXg3PoLxYFHLIrw8Qt7JplUk3nN8MZKJzVBqrtOb1gC1UhJNv+A6xDe626xBjpkEeCN0wSlmMI4m/MFWb1jUpaZ6IdmYlgc3+gLT+ZFzzIJYCBMef8uHLWgeIMcf8W2U3vxwgjSNmY1VdK0rYafjoDk1Fh1YoyvdcA9hgqARCxQybY iiDK7t64 Iwpb0HPna0XCIC63m3fSPii6lsUa5oM8cAYdHPbmy1pFlD8kzDdqQDvjnVVGFEBRaOM5gozJR1/uHI4qk8yHz1WPPLbpVt2syqUQL3bRczQpQXPZj0CaTfT4tNFwIfh6xh2NZw74uxj1T8cQLeor+4bNzK1IpIWuALXpD+nrlQK5pMPcDnX6xHhwAJ68I7txw6NSpsGLLlcUTf6BEoNeJqis2uTJbaFLZSNWVxLFXbwevirkO7IKD6O8fGcL7jX/WyXrxHxsig24RvTh9rEICziHoAn4P4q/joMS5Ti2syQfsiSJulC+11TGBsUk/9jYMctnfCgpnHbzo8+azoNobvinnRoSnP5jx1Ff3g4ieDYCDycVZljPaVU2bxq2mynYhuT4u1d+47I70mYvG2AExqGshfUmuwxc9ldJVcKC2yLcOKp53+6V9Hv8uS78u9sYfUCEC2OVYfVO/B0Wkud0J3eUQZu5UjLlJIiauC4vLOax2iniL6ijEMZT/vamqe2HFAmlA6F3fmR4ki7+h+gta+n8OPnRsL0bXVgeAUxLusxSXg4gXf4MvgCpQ793Xe7fgEvXh5s1snHIhFXSF2CnjAkzDHky8TFqPG0t8yM5qD/2MUr/nxqddTKAC7vD9fcQJgbYnMLQS2DuKzZhlCtwRraOqie1gDjxXOK/wXNjkxmqN6vyTUBjch7p7rSQd6wuKH2j56TW7HWdOHqbBHwWVhqq8dRzqKgsFGr/o/L190YKFUz0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > In preparation for the introduction of anonymous small-sized THP, we > would like to be able to split them when they have unmapped subpages, in > order to free those unused pages under memory pressure. So remove the > artificial requirement that the large folio needed to be at least > PMD-sized. > > Reviewed-by: Yu Zhao > Reviewed-by: Yin Fengwei > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: David Hildenbrand > Signed-off-by: Ryan Roberts > --- Reviewed-by: Barry Song > mm/rmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 7a27a2b41802..49e4d86a4f70 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1488,11 +1488,11 @@ void page_remove_rmap(struct page *page, struct vm_area_struct *vma, > __lruvec_stat_mod_folio(folio, idx, -nr); > > /* > - * Queue anon THP for deferred split if at least one > + * Queue anon large folio for deferred split if at least one > * page of the folio is unmapped and at least one page > * is still mapped. > */ > - if (folio_test_pmd_mappable(folio) && folio_test_anon(folio)) > + if (folio_test_large(folio) && folio_test_anon(folio)) > if (!compound || nr < nr_pmdmapped) > deferred_split_folio(folio); > } > -- > 2.25.1 Thanks Barry