From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84FBC4167B for ; Mon, 27 Nov 2023 03:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24E5E6B0309; Sun, 26 Nov 2023 22:41:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FE386B030B; Sun, 26 Nov 2023 22:41:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C72E6B0314; Sun, 26 Nov 2023 22:41:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F200B6B0309 for ; Sun, 26 Nov 2023 22:41:57 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CEF45B5451 for ; Mon, 27 Nov 2023 03:41:57 +0000 (UTC) X-FDA: 81502335474.25.DC79BE9 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf12.hostedemail.com (Postfix) with ESMTP id EFCBF4000F for ; Mon, 27 Nov 2023 03:41:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g0APdjQs; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701056516; a=rsa-sha256; cv=none; b=5KKSE0/xf2gJuQhzqAfN/ZILOrPGxUSEhWUWplHbxIO4l0iy/ZllnvRhK3tI9jtq7Z0uEa XQKSJAAu/X5VOUfOss30NflUAbLVRv4NNrCzI+MlKfWFR8E9XWf2M6fH1f352xvX27K72p Nvn50I+Wj+Pnm96XKkvdy0UYE2Vjb7U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g0APdjQs; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701056516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=658rtDCoA3Do8XbxgxnIPu7n7tXNaahQrbL0g80hn0o=; b=clOIISeH32/q5LwURIUvk+rwQKyecMc+Ds6QsHClYALZc55DQPOw4o9Z24cfFMp8HC2PJH Dz3BRFTc6ixZSzvtnRVAI1Y3d1/W2OKb4qHQH15a5vqhDkB+FTbEogsZHwwPyVr9el6JOV Eld+FFhnXV3gtCHLwPN/66plRkzm58I= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5c1acc1fa98so3355890a12.0 for ; Sun, 26 Nov 2023 19:41:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701056515; x=1701661315; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=658rtDCoA3Do8XbxgxnIPu7n7tXNaahQrbL0g80hn0o=; b=g0APdjQsZrbNDsVQSiDgAIFf9SVXgO5hLfaQdMcv0U47O3XA/rWR4mHE/TzvFuYN0h 55U7zWcHEvjVPjfCLg11N5VhLh9K7fGcoc5ZMOXRfMKf64dqDMHSa0SgQhNRJlaREpr2 BhznMZvgTg9N8KGBTt39egoWOMhspFoh/4G6q5VdLPnExDR1dvZtPMbU2DKn6KpGvHxG MAHCr3FEIGqDs8lhmSo1MyfrzQFk5gXWlSESq1C6G8E17gcxuCwFOYiHsHjAE3/+tTKj 0W8uPexmtSXulXyz3QrltleGfiyf+qPjhfpTqcDPVWLz2RPtahxOD6+MlmfyiFjto0IX Pu6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701056515; x=1701661315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=658rtDCoA3Do8XbxgxnIPu7n7tXNaahQrbL0g80hn0o=; b=rHI0ziLNMBg3KZ1WY0urNLnyARg2nKlPNSGMXXkLGTCxDjF8hgS6YkPx7YToAq02eJ Ae8EhzITg6lHfhYvHQneZSsOtOZmuyucuJKKJT3iGgwVfX0MmAYvnEMd2kGpEbKOCGib HQevZecT8aZiSJb3yPVJv5IdOB3Q9+joi/3uMZO9ZoPlzbL7nAimb+LF5Oy1E4UEVLvB vU1jmmc3X1IPOQQDTGOkU1Z7Rgl0ceQeNbCjAdwkAHPEKDcAF9WEnRuYTOdoUVCw0pUD 904HPdTumOzyaqQjjkX1nvYyPnvmfOscKXPCJGeU3aFrfcSOngbJy0Iopc1TZvxNS0iZ WqRw== X-Gm-Message-State: AOJu0YyYYsVL8H/48UaarN0TOlfYRq5XebkvlGL9K594o4VPEoHtP/ay VCR2CMiC6ddBZmUS1f9o+7s= X-Google-Smtp-Source: AGHT+IGH9WUVSSl8ZYb/w0N9CSAE81DXs9wZCWMAsYD80P/5yxaKL3tsvPGkb6jZRPI830tTmT/OTg== X-Received: by 2002:a17:90b:118:b0:277:68c3:64b9 with SMTP id p24-20020a17090b011800b0027768c364b9mr18749555pjz.5.1701056514711; Sun, 26 Nov 2023 19:41:54 -0800 (PST) Received: from barry-desktop.hub ([2407:7000:8942:5500:a061:a5bd:f09d:c339]) by smtp.gmail.com with ESMTPSA id 25-20020a17090a035900b002775281b9easm7237424pjf.50.2023.11.26.19.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 19:41:54 -0800 (PST) From: Barry Song <21cnbao@gmail.com> X-Google-Original-From: Barry Song To: ryan.roberts@arm.com Cc: akpm@linux-foundation.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, david@redhat.com, fengwei.yin@intel.com, hughd@google.com, itaru.kitayama@gmail.com, jhubbard@nvidia.com, kirill.shutemov@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mcgrof@kernel.org, rientjes@google.com, shy828301@gmail.com, vbabka@suse.cz, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, yuzhao@google.com, ziy@nvidia.com Subject: Re: [RESEND PATCH v7 04/10] mm: thp: Support allocation of anonymous small-sized THP Date: Mon, 27 Nov 2023 16:41:35 +1300 Message-Id: <20231127034135.6754-1-v-songbaohua@oppo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231122162950.3854897-5-ryan.roberts@arm.com> References: <20231122162950.3854897-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EFCBF4000F X-Stat-Signature: jhqu1j8pu34fnksoam3o7jfdgs87up1m X-Rspam-User: X-HE-Tag: 1701056515-907888 X-HE-Meta: U2FsdGVkX1/CiGaDCjW9beisogGIIhJn6sB2c4tOn1FGcGbDGmS3tyLt3xvT/4dLHaIfcRo1b59bPfXZGG75dJ61XttgiRAM7TT58IdqWWUTELAnTSU7VxrC/oQxpvTRZkuBtocgBx9ZgRfo907JWbd1q0Sv9jXY81phHc46PyM1mh4OTMCDrxbu1qV6cRuK6Rih7KYDt8PcVa0z5xtUtv3JBwBugL9l340Ou+FFCGRnmKbgYrkT1M0JfjxMSbI1bCkRp04E9VZPoCVjsNdDZYSYD1ZSG4TIOMfpNhYcj6VsA0Mc/fCo5q969V21BFXxgIsFvj/K1ifK7B0QQD/SbyC9uhn1Wlhji5XXm188azYprqPAy3j8XNNKavBo7P25SQDnT6yIvux116nExEjMC4zPU5erEjwHvyIp/W4UMhkU84xNaYH9W8LADqMNuAVXAqGKk2xF6Mz13qNnIVyXSBT17/HV5VOvyd9vsS/HOAbzfHYm+L9D15RYuFXzkq/KYEWj+0ucaNteIUTVfwggSEAxopdPcNjswv/o96z2JoXvMqSqcvELozEgjZbMmNsNxSY/w6MMjt8IXNvMVbasHG7+XZlnkCr9crvj+xwRHtbPaP94iNsP+0N+x48SOGxh9tpP86DqlVqQumlqZzrP/GjURs7M/vs1V4XCh5viYG8+7Pb46DT2jaQITgz0SM8lY7fSxHkrGtcohBRSWgpiiy4jaQw5aLWn5SxqIFcTmGFHAxrS9ZgxrlGTcdQLTV/bhfcXGJ5VvooibFtKSlY0E/mJ1JRRb1AejcvcP+OdsOUHA8ATSNc7i97hbfRXmrA07zvOYpqYsKA768UZg17GgbxAZocWUkbaPG5YN11uuN2e6Zeb7UH/3P2tQf2xixzfAhYsMUL22TiJbmMF3yAYH5wjPb6DLag2YCvsVblptMcbKPXN4GKUeUuyXyN1Q7/ItZarKfj4DBLIoaNlEZF cpSzSBbF bdo7T/uU/agm/53qWzUSF7/VNR+MqRVzKors4yoo3HA9XwXwToRFOVM8zH/oTEb6mW4Y/TbkIwFPabvksQR+/nyJ6ptvzH7pGqA8J283EOGc2iZERTuH4cCnYE44u7f9ohHRRUrgLgH+/wK6prm2uAA3iQtBdbjkP4yLUMtuOq6dpwr8y6W8GiA9D7GhpNplbNF+6eiZ8bnFYf+16vTfZQDvKEcVOov8BlfCiTzhiDDZePqIFrcZFM4jfldp/pQigz1AEJg5rthqT8IhWb3RdCYxIG+1hs5mp5y66wUZcgyUaG+YzZEvROUzUpbDHKl+8T6PiS7aTOmXXfTbT5WbgxmgudTDAQW+GtEjQumQpU6IbQoHyyYAikN+9keMzKlQMdm5BRd4NbBs6+s9ZTtmDYGymOcEi5V5/2O9Rk5aR8NZ12xfQ8IgmrYdbBkYZWhKAuPl9JHDNR0dJZGQBygz/Fyw5auWtURB/70ItaRRP0+y7KT/LD5n4IoAUUJuJGMLYh0RVFjSYhv+qAycxFoZG5uF5AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000069, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + if ((nr_pages == 1 && vmf_pte_changed(vmf)) || > + (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages))) { > + for (i = 0; i < nr_pages; i++) > + update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i); > goto release; > } Hi Ryan, what has stopped nr_pages == 1 from using !pte_range_none(vmf->pte, 1) directly, then the code can become, + if (!pte_range_none(vmf->pte, nr_pages)) { + for (i = 0; i < nr_pages; i++) + update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i); goto release; } for both 1 and > 1 cases? Thanks Barry