From: Barry Song <21cnbao@gmail.com>
To: ryan.roberts@arm.com
Cc: akpm@linux-foundation.org, anshuman.khandual@arm.com,
catalin.marinas@arm.com, david@redhat.com, fengwei.yin@intel.com,
hughd@google.com, itaru.kitayama@gmail.com, jhubbard@nvidia.com,
kirill.shutemov@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mcgrof@kernel.org, rientjes@google.com, shy828301@gmail.com,
vbabka@suse.cz, wangkefeng.wang@huawei.com, willy@infradead.org,
ying.huang@intel.com, yuzhao@google.com, ziy@nvidia.com
Subject: Re: [RESEND PATCH v7 04/10] mm: thp: Support allocation of anonymous small-sized THP
Date: Mon, 27 Nov 2023 16:41:35 +1300 [thread overview]
Message-ID: <20231127034135.6754-1-v-songbaohua@oppo.com> (raw)
In-Reply-To: <20231122162950.3854897-5-ryan.roberts@arm.com>
> + if ((nr_pages == 1 && vmf_pte_changed(vmf)) ||
> + (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages))) {
> + for (i = 0; i < nr_pages; i++)
> + update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i);
> goto release;
> }
Hi Ryan,
what has stopped nr_pages == 1 from using !pte_range_none(vmf->pte, 1)
directly, then the code can become,
+ if (!pte_range_none(vmf->pte, nr_pages)) {
+ for (i = 0; i < nr_pages; i++)
+ update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i);
goto release;
}
for both 1 and > 1 cases?
Thanks
Barry
next prev parent reply other threads:[~2023-11-27 3:41 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 16:29 [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 01/10] mm: Allow deferred splitting of arbitrary anon large folios Ryan Roberts
2023-11-27 8:27 ` Barry Song
2023-11-22 16:29 ` [RESEND PATCH v7 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() Ryan Roberts
2023-11-24 17:40 ` David Hildenbrand
2023-11-27 10:34 ` Ryan Roberts
2023-11-27 4:36 ` Barry Song
2023-11-27 11:30 ` Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 03/10] mm: thp: Introduce per-size thp sysfs interface Ryan Roberts
2023-11-29 3:42 ` John Hubbard
2023-11-29 8:05 ` David Hildenbrand
2023-11-29 11:05 ` Ryan Roberts
2023-11-29 19:40 ` John Hubbard
2023-11-30 12:14 ` Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 04/10] mm: thp: Support allocation of anonymous small-sized THP Ryan Roberts
2023-11-27 3:41 ` Barry Song [this message]
2023-11-27 11:28 ` Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 05/10] selftests/mm/kugepaged: Restore thp settings at exit Ryan Roberts
2023-11-23 5:54 ` Alistair Popple
2023-11-22 16:29 ` [RESEND PATCH v7 06/10] selftests/mm: Factor out thp settings management Ryan Roberts
2023-11-23 6:07 ` Alistair Popple
2023-11-27 12:22 ` Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 07/10] selftests/mm: Support small-sized THP interface in thp_settings Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 08/10] selftests/mm/khugepaged: Enlighten for small-sized THP Ryan Roberts
2023-11-22 16:29 ` [RESEND PATCH v7 09/10] selftests/mm/cow: Generalize do_run_with_thp() helper Ryan Roberts
2023-11-24 17:48 ` David Hildenbrand
2023-11-27 10:48 ` Ryan Roberts
2023-11-27 13:59 ` David Hildenbrand
2023-11-27 14:11 ` Ryan Roberts
2023-11-27 14:17 ` David Hildenbrand
2023-11-22 16:29 ` [RESEND PATCH v7 10/10] selftests/mm/cow: Add tests for anonymous small-sized THP Ryan Roberts
2023-11-27 14:02 ` Ryan Roberts
2023-11-27 14:50 ` David Hildenbrand
2023-11-27 14:54 ` Ryan Roberts
2023-11-22 16:32 ` [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory David Hildenbrand
2023-11-23 6:28 ` John Hubbard
2023-11-23 15:59 ` Matthew Wilcox
2023-11-23 16:05 ` David Hildenbrand
2023-11-23 16:18 ` Matthew Wilcox
2023-11-23 16:50 ` David Hildenbrand
2023-11-24 1:14 ` John Hubbard
2023-11-24 1:34 ` Zi Yan
2023-11-24 9:02 ` David Hildenbrand
2023-11-24 9:56 ` Ryan Roberts
2023-11-24 15:13 ` Matthew Wilcox
2023-11-24 15:23 ` Ryan Roberts
2023-11-24 15:25 ` David Hildenbrand
2023-11-24 15:53 ` Matthew Wilcox
2023-11-24 17:34 ` David Hildenbrand
2023-11-27 8:20 ` Alistair Popple
2023-11-27 10:31 ` Ryan Roberts
2023-11-28 2:09 ` John Hubbard
2023-11-28 8:48 ` David Hildenbrand
2023-11-28 12:15 ` Ryan Roberts
2023-11-28 14:09 ` David Hildenbrand
2023-11-28 15:34 ` Ryan Roberts
2023-11-28 16:40 ` David Hildenbrand
2023-11-28 18:39 ` John Hubbard
2023-11-29 9:59 ` Ryan Roberts
2023-11-29 19:46 ` John Hubbard
2023-11-28 4:10 ` Matthew Wilcox
2023-11-28 4:05 ` Matthew Wilcox
2023-11-28 8:47 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127034135.6754-1-v-songbaohua@oppo.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hughd@google.com \
--cc=itaru.kitayama@gmail.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rientjes@google.com \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox