From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866A3C46CA3 for ; Sat, 25 Nov 2023 17:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 069736B04EC; Sat, 25 Nov 2023 12:47:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 019626B04F0; Sat, 25 Nov 2023 12:47:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4A3A6B04F3; Sat, 25 Nov 2023 12:47:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D24D16B04EC for ; Sat, 25 Nov 2023 12:47:47 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A634D4021F for ; Sat, 25 Nov 2023 17:47:47 +0000 (UTC) X-FDA: 81497209374.23.07CE432 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf14.hostedemail.com (Postfix) with ESMTP id DC21710000C for ; Sat, 25 Nov 2023 17:47:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V4CRfub9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3QDNiZQgKCGERG9JDDKAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3QDNiZQgKCGERG9JDDKAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700934465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9pQvrE1VjbnX/y6ByGIqcRM35RSO1PuZh7mCElTQgyQ=; b=UhoCyq6JjKnwnnIBYnvODrcOAyXh3XWQKgjcWQsBh2/rjyz3k6SZb/qY5dG3EebmILyICl VenuliHzxUBaiW6vX7iIb5z896aUrDs9mmDhQ1fKGydzpB9z6LWAzYuG+sK4V+o8K3Yy3o f+FOAf/7r+cQZFRL4WZU+HG/FcZ48eU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V4CRfub9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3QDNiZQgKCGERG9JDDKAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3QDNiZQgKCGERG9JDDKAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700934465; a=rsa-sha256; cv=none; b=oeh2cUbJYL1BllwO9hHvEqv/epoaZsh73tCKIH9j3RmRT9ZmjWfFOY5gBSVRv4AI8VZvBZ NnE5b67dg8ZiUsBFRyNKtJLmqsnUEBhRHyQmJwiK4RCb1LSe8Xwf9HiGC5Mtcc+TPwnA26 qC7rQUlwA+BMl/FUev49+ioctFkrtN4= Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-5bddc607b45so3641375a12.0 for ; Sat, 25 Nov 2023 09:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700934464; x=1701539264; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9pQvrE1VjbnX/y6ByGIqcRM35RSO1PuZh7mCElTQgyQ=; b=V4CRfub9aINKnESS1q/rJOwOZPh3yflV/Wtw9yCmV9umT5uzEHf/FHp2eO4e8j75AU 7DRjRcHeDyhOfSXOEq/z7sU5TCMVUeHqITVUFm90MFmx1MCipoZFUf+6X5ocCkVRxHeL PBNTUjnqvAO/4eNVNDAV0iJTAaUZjr22qE193vjk9ij2D8Gkpujmt1rLvSmtjzyYIDwv vR6yQZ43LLWOJEGXPs8lJQ31rFNmRdbt8wz+oUhUxpn2qDM6hHy9DsJZEvhvXcgHMJIr wX3PMfNEx7iixNKkI1ZHMNdvQgwZBDDfr2ayKArBLXABu/DZ8IJxTEbiO9vmmPFel7fk 910w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700934464; x=1701539264; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9pQvrE1VjbnX/y6ByGIqcRM35RSO1PuZh7mCElTQgyQ=; b=fHQdrrw1XPjatwC4tl+rMZkAUywEDMTrRELx91XzkWcKpHKWU9ZkA4+AcidcPk54QY +EnQnxKqPt+6ip+QU9QTxX7U/Q/d3Iq8KwALYJkhZEp2PNhC8hFkSB/DDwWQ2KOxYoPs 216pfxzeYtSv+n4+jRnRl1XfSrqtK6eL5yLEvNNkoowl4VtsvAvtL9XS9EA6u0wIJWWU Wlgn1DTcyTqYfMGILLu9qJN5m+A/0Bqfc+/f7PXyHTuRJPus0fjcfEXqTlwAJRtGbHBi kPnSwygI8FrEtYcswBZ3reXupAktE7rxNlRHXb7pgbJVCHvM+Of4lh6AQ3AL6+/ZuTTc 6o4A== X-Gm-Message-State: AOJu0YxKIJjhP7Q/VKKZXM56wEDuqn7Zt6GqwWNmMTqTHOmhw7qcMVme tfCxFURp9GahJ8XuVk7lmdEOomEG18xx3A== X-Google-Smtp-Source: AGHT+IFflWgX+Gg7h8fTMTF6SpzYKnQOYwGbJCZ4v+j1BmllVH1kpuMX3VxlWRmMPr/i4NyYau2+euR5tvKkyw== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a63:d209:0:b0:5be:1194:9c0b with SMTP id a9-20020a63d209000000b005be11949c0bmr1039251pgg.3.1700934464725; Sat, 25 Nov 2023 09:47:44 -0800 (PST) Date: Sat, 25 Nov 2023 17:47:42 +0000 In-Reply-To: <20231123193937.11628-3-ddrokosov@salutedevices.com> Mime-Version: 1.0 References: <20231123193937.11628-1-ddrokosov@salutedevices.com> <20231123193937.11628-3-ddrokosov@salutedevices.com> Message-ID: <20231125174742.n3ybfum53yd27bo7@google.com> Subject: Re: [PATCH v3 2/2] mm: memcg: introduce new event to trace shrink_memcg From: Shakeel Butt To: Dmitry Rokosov Cc: rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, mhocko@suse.com, akpm@linux-foundation.org, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: DC21710000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4tptym9sacaty87ywxw1zrkijgimfrpi X-HE-Tag: 1700934465-283254 X-HE-Meta: U2FsdGVkX196rQUl3WP6BpgH/rf1+WL7W0s4kgd1QT1FigthpmBMUXLJwNHwMRkErQWwiCyxitUEXwu5D1gnU5SrlMNlSpTiLhGsAWMwVcxGqdvYv43xTlepK07DAWyLCFGtWP9pvXG7pYfN4Ue/MW6ycGzfv8FPrhrmlf6PijoJE6NJ86Ks6myEru2iNZKeaj6p5ev1vFHrVWDtf06d9hv5vV5vLxm1F1bhgVt0TzXLWvWZX6SiRIONMyaVkiMh0ZfHCQ54DL7zJ8UAdQa+ZkYn0OO3TsMm9Nl86h1oTsDhd7yguyFSnjAbPln7bT5NV6pic7jraqPhUJxYJvQFS3DRDrfTzXFSihGd/y9gkhtvIQVwOFqhbSENacTEc7bXXBWtPUeMOJhrFk8WOEhVFEeL4i3f4UVgioSZKZagjSPHvtgH2AmcB9F9hwiB7v2axTUGJt03KFV54L2IkueVQGo1j0nWvxsZMels7sL+cuG2BZfnWdD1DJ2lizGZenwrw91YuM6JCOv/L7vGh7BXd76oBp7EmjtlFX2SnE2oSp99ob8x1qwxBvuydIyRw1qZz0dA9yyzwNw9Z32j8mYi2h9uKs2Edp9kuDOLUY8eS4yRzycZF6evCE5jXgzYPcaFRnjXQFCXkdZMPCo4+6neFrRQl7O+TsiSijuKHEmh2FR6yyz/CFpOj1/grgYLDmkidWzP6io/yxZdbxmUV+b3Qkw3qp0VKq3NU4dPyQ559TUVJTodQO7HRZmjeomfSxznQnn5HpHefkMqLUmiM/sIO+RRKLLdXkocgdmjre5uEBsk6lZi+YWye4Jcv6VHEoi4gLdMhV2rO/dyCqo6U1TwvsgblGctrUEwpwHycXnTJNZFFNetCCTIT1EM/93Oxk8ttHiYktct6e01NmGlxwG3n12FSX/rUkFTglzDeXZvOQ0b6qFPfkYhLyROjR+YAmKNaI5xcKVXp+0AReSj4Mj 94GBTX21 s+FSG7cF3PJZ8UoWZhphasV+InvLDtlwjxjmQh5cw553+LpH5qfz2MW8v7twzc6vdFv7ZZc7FJYIPto0drBhGU4lPcSr5iD3jBVZLs0hwdZ3fGWPpfQDDDRsKykrAT/GoA5QpOJjWIIO31ClMhG8W8tdG+xucHKmmFAxTNjrSuBrrSVrrlSB/H8FHsq4I6TsxMtIvzgbQvzXXY1rV0dJ6/SBerAWpPDTUM8ya/5LZvHRCNdm9DmzSpTWWv+qSRZYIWm/bPrf8BOYaD8mB5sZ9F3vLqGi+KJZC/AXueYMYybYyFNcRi3he3MD4kkHCZmkPf3eElKoL10TaRiJh1MEVhP7Fzl8VcPweM0AjPUialc+eObrg57CMqd/PJigsJWfCfGV1BfLNLGTE3H3rqKxVIAFmG1oL6x+Q9b1eiaerdk4HX/nNn0+p0SJnxTfyqonKwZx1MI+zSnkDwwktigkqtZOJk2ON9wPUfzZsBHiJIbCwzypMTY22GJeMCAO+ZAV+SVNVZc/2UJLecjglURA03a1ghpolkchxKnrX/hHfyCgG8HtPonVkIbV50S4iAVTsOWB1HwpVgiu5XBZqgGerp5EmSduP0Dtj65SzNUL3UDARwPc7Is+86obOy0juvo9F80npz0BTCZQPyi9K21qj2l+QxHOnGhVQRYnguxg0ImtdU8LaVKwf394P9iJ3YDxACxiOVECxzs/BYoYHopfQgCiP6xd0p+sUB/Ko X-Bogosity: Ham, tests=bogofilter, spamicity=0.093266, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 10:39:37PM +0300, Dmitry Rokosov wrote: > The shrink_memcg flow plays a crucial role in memcg reclamation. > Currently, it is not possible to trace this point from non-direct > reclaim paths. However, direct reclaim has its own tracepoint, so there > is no issue there. In certain cases, when debugging memcg pressure, > developers may need to identify all potential requests for memcg > reclamation including kswapd(). The patchset introduces the tracepoints > mm_vmscan_memcg_shrink_{begin|end}() to address this problem. > > Example of output in the kswapd context (non-direct reclaim): > kswapd0-39 [001] ..... 240.356378: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.356396: mm_vmscan_memcg_shrink_end: nr_reclaimed=0 memcg=16 > kswapd0-39 [001] ..... 240.356420: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.356454: mm_vmscan_memcg_shrink_end: nr_reclaimed=1 memcg=16 > kswapd0-39 [001] ..... 240.356479: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.356506: mm_vmscan_memcg_shrink_end: nr_reclaimed=4 memcg=16 > kswapd0-39 [001] ..... 240.356525: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.356593: mm_vmscan_memcg_shrink_end: nr_reclaimed=11 memcg=16 > kswapd0-39 [001] ..... 240.356614: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.356738: mm_vmscan_memcg_shrink_end: nr_reclaimed=25 memcg=16 > kswapd0-39 [001] ..... 240.356790: mm_vmscan_memcg_shrink_begin: order=0 gfp_flags=GFP_KERNEL memcg=16 > kswapd0-39 [001] ..... 240.357125: mm_vmscan_memcg_shrink_end: nr_reclaimed=53 memcg=16 > > Signed-off-by: Dmitry Rokosov Acked-by: Shakeel Butt