From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F21C61D97 for ; Sat, 25 Nov 2023 00:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80A888D00AE; Fri, 24 Nov 2023 19:30:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BA0F8D0096; Fri, 24 Nov 2023 19:30:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A8B98D00AE; Fri, 24 Nov 2023 19:30:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B8B88D0096 for ; Fri, 24 Nov 2023 19:30:21 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2F2BE802EB for ; Sat, 25 Nov 2023 00:30:21 +0000 (UTC) X-FDA: 81494595042.11.9747291 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf26.hostedemail.com (Postfix) with ESMTP id 4A54C14001F for ; Sat, 25 Nov 2023 00:30:18 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=b6ut3I+z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700872218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qRAT6OKmsIpLjyYU8pdtdMLej9q1hTZbmNmWpWlr6NY=; b=TV8YlRWOpVB5qImF/NN+yuC/VxZX7rMZNlRAO9OLh8ds1PMvM1fre76GP/wMKrx9ajK4Pc PsZRWS9iH07e0u54Y7wwcaEGWnFl3fRRTEesZi9VLihmV429lI0M879VHrqdNycnF0awA1 dY/TG10PmSZdfcDrCKzoELWKBhigyEg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=b6ut3I+z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700872218; a=rsa-sha256; cv=none; b=ToEmFUaPwy5ZJPmYnxNmoskNUINiaiWzMVhbp96cMFlcUv0gia5bDS5wIPCmMNRP5fIU9q c2tAVztM4L3+8bj/OPChlC48g+evDlGvm+EriA713teMDr8QZxZ2d7PbEtbQVWqKHwVWUi avPqdi4FofpZ/ujJdi5qO5Mdb0MEaBc= Date: Fri, 24 Nov 2023 19:30:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700872216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRAT6OKmsIpLjyYU8pdtdMLej9q1hTZbmNmWpWlr6NY=; b=b6ut3I+zm74xPveDsBhnywkDDIeNnCrWMxrsbMB8T2Qo7bwS7fzHGTL96owJFfBj9WxBxa VSesApdWqDRXOIeZyqgdvi64fZdbAGEUxHt0choWC9/5xNjk11BYJHbrUBy728HXkqMaZS LWWcUmpPEcgbjQhHCIyUP7WAjmhu2HU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Qi Zheng Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Roman Gushchin , Dave Chinner Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: <20231125003009.tbaxuquny43uwei3@moria.home.lan> References: <20231122232515.177833-1-kent.overstreet@linux.dev> <20231122232515.177833-3-kent.overstreet@linux.dev> <20231123212411.s6r5ekvkklvhwfra@moria.home.lan> <4caadff7-1df0-45cc-9d43-e616f9e4ddb3@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4caadff7-1df0-45cc-9d43-e616f9e4ddb3@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 4A54C14001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xyypue4j69x5r5h7aj1tyrearyii7br7 X-HE-Tag: 1700872218-503214 X-HE-Meta: U2FsdGVkX1+T9Xc2uzrMz2IdQQvgnnC3UTwnJ1NG6Mg8mW3UOlvYKfgW4e6DAGHy0cBzeWJyfzYHKFr/AaIrHL5kN9Vin2B5sUKxq6RoCDrGhHxwEQQwgyR+wluZbQJ9Xov4q3HT6DSQ3mfflYafswKc8TjDdL2jnOo2ER5JYlpkmdIATL3c/yrtM9w4599PKhCRlIp8cNIMGioVl7NFvG8o8Au/zpuKRlS5R26gklEQ2+rpAhXKEpatzLibJr1wZA64BblGuW2hUOWeBhkv29gjEkqdF9kzBot0hVghDfR/i4fdAB156vJhcXR85cCgdFXQ6kUavl6U8tMSOyH8j6sxaIFEHAvvU0Icac+6HInK/5SHdMebnxznJawnvcbwx8qZosmkspp25bXv7ZVr86WXjZok8lQMvNnlWyrDQVi5os0g0kLcWJzcaN/cxc8f9CBLgBfX/uHGq0yZNAJSdrvKLF2kGlkE+OVRS73UdL/5p3Z9EgoSt1EPU/ZLPizNvRVZ4Y/LtBWtcp9BCZomvKlDxDZbV3k5ppnQoa7oGNDcJV5YvqIZJwuu6hKcIf047+2NDJEmfVE7I+q+z02LwCiTIsXTBxPo0Qp3k0983a0F4W8TzI5oZINfVIN9utfNJMkjBBInLHFAHXXH8xVQ8ULgqOt9WT4NMO4bgVUDRBM6wAV/VyDlA4dCNmQaECfrpCEdPKi3jo7pCtWf+koIONsMQKqgGSQKViMowkWspVATeTtKAGMV5U5lWtND31P1Ww+faRCFfCStk2wlMC+Rhuyc1cyLyf/1m+omax/ZCzRlrCNKco22M8CnBz4pAvgMJCaDT8K8mk2s76lBki8bsn04a/dFixC5eSPegwsfeMuyoKyIghXDpdaStXo2BAaus5AdbxlFvowBaOR6meTNOM9u80rsq1kT9YrxbVFBTpSfW+h6KayZq6u5zzVnvQISWhm+ik+YDPSW5tXDRgJ 7HBjgQuz puXt/of7bn/M1vkQfMo9hTTjTR2c1Kaav4s2q9FMAdv3ekQ/tXqxjJaEB2Qw41RhoYVOGjs8kizh2PL0tqSGsX7D/iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 11:08:11AM +0800, Qi Zheng wrote: > Hi Kent, > > On 2023/11/24 05:24, Kent Overstreet wrote: > > On Thu, Nov 23, 2023 at 11:32:59AM +0800, Qi Zheng wrote: > > > > + void (*to_text)(struct seq_buf *, struct shrinker *); > > > > > > The "to_text" looks a little strange, how about naming it > > > "stat_objects"? > > > > The convention I've been using heavily in bcachefs is > > typename_to_text(), or type.to_text(), for debug reports. The > > OK. > > > consistency is nice. > > However, this is inconsistent with the name style of other > shrinker callbacks. Please use the "objects" suffix. As for > bcachefs's own callback function, you can use typename_to_text() > to ensure consistency. That would be inconsistent with introducing a convention to the wider kernel.