From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6E2C61D97 for ; Fri, 24 Nov 2023 14:37:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBFE88D0089; Fri, 24 Nov 2023 09:37:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6FDD8D0084; Fri, 24 Nov 2023 09:37:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A106A8D0089; Fri, 24 Nov 2023 09:37:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FB1C8D0084 for ; Fri, 24 Nov 2023 09:37:24 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5EC71B6A8C for ; Fri, 24 Nov 2023 14:37:24 +0000 (UTC) X-FDA: 81493100808.15.AAC99A5 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf23.hostedemail.com (Postfix) with ESMTP id 426AC140004 for ; Fri, 24 Nov 2023 14:37:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=C4ZWuUa1; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf23.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700836642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ohccp6emLwawWzvtIzIh09L/4m/V7F4sqEbEIpoSnq0=; b=G9vR88tHB+2aNTWrnm+dEQMQ+G7GDnlP474SgrnWsHYa/gkNx/tZcSKtsrGH/U9QGg1nkD Xxa2PjFwg6aCkFVgWENuwBxE+3ZH1NxIsIzqRLLXZuXnIknqdGThzAFN8jZCdQg1wPaEsC YbAXJjK8uXfRYvmbSZ0xbQM9VBgiYU8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=C4ZWuUa1; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf23.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700836642; a=rsa-sha256; cv=none; b=W2ECuzh9tyssI0/4cLsqpHunfEKrQ6lo1u3drpy1cTd87JI42+KZwzBysn7StWHm4iqe3B 9xXXCijRWwdtinsF3WEiKmZEGcHj+m7ZaLa/SkUEFYxlIDZDrky4sAE4NkZvocmsQU5741 A59/1qYI8GPaG16ZHNjcapbFd3CyvAs= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 7046940E0258; Fri, 24 Nov 2023 14:37:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PRqga3sbJpbf; Fri, 24 Nov 2023 14:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1700836637; bh=ohccp6emLwawWzvtIzIh09L/4m/V7F4sqEbEIpoSnq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C4ZWuUa1L7kfp2HdFjJoJ/VJsOFVSUnC0gO9qFwTG3YmBCUPdTYsVqDGWCWhKhwWt bPMfC5FW5UvB9dmwy2CIqzCbKbi5cBjMdkDEa0CeXp+5M+QzDtnelk9TLL/EgQ5NHj McXjzfHSJsgjpj9MqRmHPWcJCCMrAogxjUm0/Jsc72ebMXkCNQAv2djjGq5eNffoAf OMq7FM/q2dgI4mAq6K/W2UfryaZEHOZo9PgaPQCJavHEyqMeOtbKdsxzha219KEvZA X4wIE/IZYEGPevYKN2YBtPnPL5DpnWEEeMQiu/VmvTlcQD+X7yrx99Yo3AdwDF84Ox hyEAoTZMYPGcbo29lPJ7jZX5gfw9buYqXMNsN85LAYacotEiG6IZhHOjIZnf6V/qGJ D4elq+EAdSdHpU94MOeTRjyBVHsxMDXkGH0vd/cN/mdU/okeck6NZxDB9cxZmMQxdS DdAcDBO8v99bXDYNhp74RKKFrlGzQVHoUWww+ITXNOeS5ImW+fkWgECNI4J6p5HHzc tWYWb2LREZVw1alEGmVBJNZW9xdLYefPQ2qHOTWEU8lOdrrttsoCdCD/HPkTNRKylD PudnxC5CBKqZvR0VTaguz2OUBxIbOEGUGX5BFTAzbznuxMmWe5UgIF62+gJycHagac eB1F7hjjZjigIKjjHsZGVU5M= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AD93F40E014B; Fri, 24 Nov 2023 14:36:36 +0000 (UTC) Date: Fri, 24 Nov 2023 15:36:30 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v10 13/50] crypto: ccp: Define the SEV-SNP commands Message-ID: <20231124143630.GKZWC07hjqxkf60ni4@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-14-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231016132819.1002933-14-michael.roth@amd.com> X-Rspamd-Queue-Id: 426AC140004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nyo8sxdn1s5aog4fdmaefkwmtxg5pry5 X-HE-Tag: 1700836641-601054 X-HE-Meta: U2FsdGVkX1953xh6sY07t2LrWHuYqz6pPMV0iUkLofzhG6bc37M/BOqwGXmoJcOuTBzHZ0zVMZZBzyc+OHFRtV1jo1aiUDm+z/yENrUNp5RowLc7IZprEdik8ol3KbRX4zkEdVkRU3YsKO8jWh2WIFtIH1kfxowDxhgJSs/2ofOYHTCm9fz05mPT+MFmToDbBOHxMP9zozwq1jDGJJHxgqIlSqNs3Sa/H9cbHm9WqlKbnaWWy7Auev70sGmbllUAiEhLCD14KfBRA8sqeWODG6fHeBGS+Z9ThE3YBIjj3QlA2vwIDRc6uJxXLP+RrHRRhX5qEvxkoEFVM5fF9Tistk92eRPbv6Vf9V+RnSKbXSxVX+Z0xIzd7NxNAHvCGSI/0lXxvHdf0bn47/jr0uMN9sLR+zbWAJqqhmsV0bRQ0pK/rrIibcj3L2iqDidXXyVOln0UXuS0qxQoJV/91LDplBxBd4CMqfXimOQqX3HHuhYJKjWrcZoEWsg4fLDbEQcG93VfuGlqwHC7ZqBH/0eqy1wwlREnCCgxpkkisKvT4MY731YqOLkqTtBz7Ly2mPtcjCXMGEYje5BZL0+/gABbEpGfV/xyYsTclWGJASPOirNn7JnvTOOWERAro499+9mwl39VICVdriDg0F8sqSGib4AnMQjwbhfpCddfjkkt53sXca+e+lUfPoyyIsHATVuTY4iIGqvMgUJqQIN48MjouCrHz8EdcUnXtfe1+bwP1jy15bc0yswck2ee7MF10GxEuc6J7/PrxA/HpffMu23S2LT6Sv9i/Suy09j68ijIVKJ/invgjNceKvZ2aaAAm32+NhbgeMJNFeHOeLem07zabwgOjrdBshii26Bum/v81nPVaq6LjLU1v1AXscOqzisSSSHG5TbUfUm+dfF5O3uClfk2ZnYH8X8KIKE0ruFLBkyT3J/Vr4KwFSuzLUhBYnCrdLkQvi0b+DNppfvtzAW vuXtxL/n McsFNjNzqTf6SIlolISHIimouNr3K/3Jm1XupGYK13F/M5UnwD8gcF7+LhCr/C46GDBqVmMCeIbvgXKkbZD4GUcPFgNx0DhRAIR5gM7Bst2z4TrPAMqO2drm+QcmrFAa6SUO9/JD4sKIZCYcO5+uFI1L+R/iw8QB1N/OrqfaJ0UuTnk4yplmib4L1z7WSMKbyLmv0rlZvtaiZows= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000360, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 16, 2023 at 08:27:42AM -0500, Michael Roth wrote: > diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h > index 7fd17e82bab4..a7f92e74564d 100644 > --- a/include/linux/psp-sev.h > +++ b/include/linux/psp-sev.h > @@ -78,6 +78,36 @@ enum sev_cmd { > SEV_CMD_DBG_DECRYPT = 0x060, > SEV_CMD_DBG_ENCRYPT = 0x061, > > + /* SNP specific commands */ > + SEV_CMD_SNP_INIT = 0x81, The other commands start with "0x0" - pls do that too here or unify with a pre-patch. > + SEV_CMD_SNP_SHUTDOWN = 0x82, > + SEV_CMD_SNP_PLATFORM_STATUS = 0x83, > + SEV_CMD_SNP_DF_FLUSH = 0x84, > + SEV_CMD_SNP_INIT_EX = 0x85, > + SEV_CMD_SNP_SHUTDOWN_EX = 0x86, > + SEV_CMD_SNP_DECOMMISSION = 0x90, > + SEV_CMD_SNP_ACTIVATE = 0x91, > + SEV_CMD_SNP_GUEST_STATUS = 0x92, > + SEV_CMD_SNP_GCTX_CREATE = 0x93, > + SEV_CMD_SNP_GUEST_REQUEST = 0x94, > + SEV_CMD_SNP_ACTIVATE_EX = 0x95, > + SEV_CMD_SNP_LAUNCH_START = 0xA0, > + SEV_CMD_SNP_LAUNCH_UPDATE = 0xA1, > + SEV_CMD_SNP_LAUNCH_FINISH = 0xA2, > + SEV_CMD_SNP_DBG_DECRYPT = 0xB0, > + SEV_CMD_SNP_DBG_ENCRYPT = 0xB1, > + SEV_CMD_SNP_PAGE_SWAP_OUT = 0xC0, > + SEV_CMD_SNP_PAGE_SWAP_IN = 0xC1, > + SEV_CMD_SNP_PAGE_MOVE = 0xC2, > + SEV_CMD_SNP_PAGE_MD_INIT = 0xC3, > + SEV_CMD_SNP_PAGE_SET_STATE = 0xC6, > + SEV_CMD_SNP_PAGE_RECLAIM = 0xC7, > + SEV_CMD_SNP_PAGE_UNSMASH = 0xC8, > + SEV_CMD_SNP_CONFIG = 0xC9, > + SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0xCA, You don't have to vertically align those to a different column due to this command's name not fitting - just do: SEV_CMD_SNP_CONFIG = 0x0C9, SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0x0CA, SEV_CMD_SNP_COMMIT = 0x0CB, > + SEV_CMD_SNP_COMMIT = 0xCB, > + SEV_CMD_SNP_VLEK_LOAD = 0xCD, > + > SEV_CMD_MAX, > }; ... > +/** > + * struct sev_data_snp_launch_start - SNP_LAUNCH_START command params > + * > + * @gctx_addr: system physical address of guest context page > + * @policy: guest policy > + * @ma_gctx_addr: system physical address of migration agent > + * @imi_en: launch flow is launching an IMI for the purpose of What is an "IMI"? Define it once for the readers pls. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette