From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC2DC61D85 for ; Thu, 23 Nov 2023 08:45:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA9CA6B04E9; Thu, 23 Nov 2023 03:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5A396B04EA; Thu, 23 Nov 2023 03:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21576B04EB; Thu, 23 Nov 2023 03:45:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B36806B04E9 for ; Thu, 23 Nov 2023 03:45:23 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8822C1A0EED for ; Thu, 23 Nov 2023 08:45:23 +0000 (UTC) X-FDA: 81488584926.02.BCC2816 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by imf16.hostedemail.com (Postfix) with ESMTP id 5904A180029 for ; Thu, 23 Nov 2023 08:45:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=salutedevices.com header.s=mail header.b=XY3DeP5s; spf=pass (imf16.hostedemail.com: domain of ddrokosov@salutedevices.com designates 45.89.224.132 as permitted sender) smtp.mailfrom=ddrokosov@salutedevices.com; dmarc=pass (policy=quarantine) header.from=salutedevices.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700729120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k/7vxiY5zeoTfQ1bw6Cwc7xvQr3MSHEmQlGxKNyL2pk=; b=3/VuL10+JK//fj6waeBxSohLV2x/9ofDecmx3/6oVKoC2JwNhSoyCLwyZLqfSz2U4xKXla Z7fxPjsGdqCDH3eCs5MOSPLkLJO/Vxzd8PlPpaybHPl8pdQM3WMeU5VpjsptxQql6mjjVV cPhOhwY1KGAURY/ZpCYT43SLrBHbvhM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700729120; a=rsa-sha256; cv=none; b=qGIF9QCoC1y01A0qIlTPFXCdEQHa9JZGRpo4OB/3oPnteZ+YkVOflfgUAqGqNw9w7JHEAT S2PBAVD4gw5fkPuO+SiIoV7C2lNBTecGW7ESYg+HhzB4Vxmiu0rUlC4oIk95BuwNHEu2zj /+NkjB529zJdmzhjH0a2wCU4N0pL+SE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=salutedevices.com header.s=mail header.b=XY3DeP5s; spf=pass (imf16.hostedemail.com: domain of ddrokosov@salutedevices.com designates 45.89.224.132 as permitted sender) smtp.mailfrom=ddrokosov@salutedevices.com; dmarc=pass (policy=quarantine) header.from=salutedevices.com Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id F1F25120002; Thu, 23 Nov 2023 11:45:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru F1F25120002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1700729115; bh=k/7vxiY5zeoTfQ1bw6Cwc7xvQr3MSHEmQlGxKNyL2pk=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=XY3DeP5sB2Q9aYHR9//a4sv7k57jPA0BYaKk3gVPw1I2i02N8NLP3VjHtRiDO12wa U9rizn6PXynLquIkV7Ub9FDKm4eUFMgQNs0UznUAi+zYtp5BzGDXZweVw5pbvPHmb3 5V0AShrc+q4v7wa95sQuK5jpBsHo9sPr5wo88nMwhOG2P7H0y4ATR0t35dv6InlaMO ftKs5Me4qHBqOfbbOD3cWmKRfGD9eN/4bO2EOKZfElgVIGuE5Sv3NXLf1TLDcX8Oa6 UXK1mKHpZeYys4gGYhlfwYZmZt/R6v23wYJi4PizpKhAGKgW5iV5mHN1NXZCxn6Zon NinIm6kkbsNWg== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 23 Nov 2023 11:45:15 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 23 Nov 2023 11:45:15 +0300 Date: Thu, 23 Nov 2023 11:45:10 +0300 From: Dmitry Rokosov To: Shakeel Butt CC: , , , , , , , , , , , , Subject: Re: [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints Message-ID: <20231123084510.wwnkjyrrbp5vltkg@CAB-WSD-L081021> References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-2-ddrokosov@salutedevices.com> <20231123072126.jpukmc6rqmzckdw2@google.com> <20231123080334.5owfpg7zl4nzeh4t@CAB-WSD-L081021> <20231123081547.7fbxd4ts3qohrioq@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231123081547.7fbxd4ts3qohrioq@google.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181552 [Nov 23 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 3 0.3.3 e5c6a18a9a9bff0226d530c5b790210c0bd117c8, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, 100.64.160.123:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;salutedevices.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/23 06:37:00 #22507858 X-KSMG-AntiVirus-Status: Clean, skipped X-Rspamd-Queue-Id: 5904A180029 X-Rspam-User: X-Stat-Signature: fyaqcznnaraj941r1gbxqgdqr3i6dk9s X-Rspamd-Server: rspam03 X-HE-Tag: 1700729118-845549 X-HE-Meta: U2FsdGVkX1+QAE1xj08wh8/jAkI4sxRxTpMMbbvSFgZ9HDm/bSRqTde/ltz8R0PZ0PSdibCUyms4z2nCG2aHhUdarfy5u+Y1QpksAJtk6OgEiC4ErgvBXyKdyt35G8ZdXHMxMCdqT5i8MSHvypfwhS3pgXSn3Al9yk4tIEgIKCJHMPDT9wo5yzMDkf8XjyN5KKb/aeJiwsKHsuDCAn/ccYnJ/gqthYqhcHnb0RzAmLLzGQ01ccEMrwBYHc5tbCqfVtu9XAU/jLebau5EHH62jKgyLOAdrd3EBkrF79GxfXHmgw7wulkJ5VqYf8vxGgxU/9NGcUyxQDQQzfVpr7QAquBwBPk3rWXPSFHap/wUu8jTZwQdS0l8KJb41ENIuabFe2aqNNaCfLCJIf82KJmnf5AdCFxZwtHLJNb1JNR786Fo1qLyypW7SpnEl/5WHrlTQgrxYswYeRMTZD/P2kCGj9m2PgdvkgwTItE82ujgy8eVNiG41OFfZfsZFLJBivRF9gifGrUbj/9vkAgojzGZAZtcapTkuEco1rb8JXyj0wvSirxP81aZrTIxizxr+kXsRm4q1PivioRpRsvqjhaNVnSCfBU4I93wCkfcR57BL0lP5auQJ7Pbn0vxLR4/vK+3IDrFw2wyDqWlxYr94bw8YMkN+VK62mlBIOtVzTCiGaBU/R0dOmws4FwhSXtODXT0U72AkUR1OO26WasYNVW6Z0rKPkHenoUyqli7IS5eVPwM1T0CNoGgIMoAHu3VY6osn3VyVgDudUK0TLWZ1mH3yk7ONsX91L7ZQ3n7zFsgFBn1oDeHKdU7dzJjeB5XqzjakRRLHLyaUqlq/N6N1a37g+t/hSDDhjbAnnnTOq0zzHtJMz/XRX8H13JM+ks7QzNBYf2su2z1sTPJfn980m9a+D6Vh5rScjMfobDIYtsix0pdwIrjHtimK1PZ7C5z8RUHmTG8bj/M2r7/081k2N8 qnz+vh9u D/iuRsdSF0X6AMwJILNCXbevYOxxZPwO916CUhl/sSG+dzKzDY1YfvWfyEn0zn6ziTaMmrmb4X5fcYC1jOSyb0+p13wQlSO9inttyBWc3hgaC4UupkNDiR8qDt6YEy2uC3Gr1P/Iwer8uF56ygqVJP4IJsab6OyFjLgPxsq978+7tT4mBzjXywqOpPve7pQD0r6QprfU7Ejsj9m1z0hG186W270kPY1FMlIis1exusFQnUyxLeaQDqtko5A4SQv++xBALCHwJQ52rEr778LPTgL2eOlCzAb8Scv0ZdKxJtCpY7DJ6y5wdwpwb6O/E3G1PDhvw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 08:15:47AM +0000, Shakeel Butt wrote: > On Thu, Nov 23, 2023 at 11:03:34AM +0300, Dmitry Rokosov wrote: > [...] > > > > + cgroup_name(memcg->css.cgroup, > > > > + __entry->name, > > > > + sizeof(__entry->name)); > > > > > > Any reason not to use cgroup_ino? cgroup_name may conflict and be > > > ambiguous. > > > > I actually didn't consider it, as the cgroup name serves as a clear tag > > for filtering the appropriate cgroup in the entire trace file. However, > > you are correct that there might be conflicts with cgroup names. > > Therefore, it might be better to display both tags: ino and name. What > > do you think on this? > > > > I can see putting cgroup name can avoid pre or post processing, so > putting both are fine. Though keep in mind that cgroup_name acquires a > lock which may impact the applications running on the system. Are you talking about kernfs_rename_lock? Yes, it's acquired each time... Unfortunatelly, I don't know a way to save cgroup_name one time somehow... -- Thank you, Dmitry