From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE142C61D85 for ; Thu, 23 Nov 2023 08:15:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5284A8D0013; Thu, 23 Nov 2023 03:15:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D74D8D0002; Thu, 23 Nov 2023 03:15:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F828D0013; Thu, 23 Nov 2023 03:15:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29B858D0002 for ; Thu, 23 Nov 2023 03:15:53 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E15C040BF9 for ; Thu, 23 Nov 2023 08:15:52 +0000 (UTC) X-FDA: 81488510544.01.1DC9D06 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf30.hostedemail.com (Postfix) with ESMTP id 314E98001A for ; Thu, 23 Nov 2023 08:15:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fBeVWhnT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3NQpfZQgKCPYqfYiccjZemmejc.amkjglsv-kkitYai.mpe@flex--shakeelb.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3NQpfZQgKCPYqfYiccjZemmejc.amkjglsv-kkitYai.mpe@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700727351; a=rsa-sha256; cv=none; b=EC6zh12+Pgklhr5kR9MjLZDhISXqB3degRd5T7qxn0yzGd9zHemTmgK5Sq+OFGSt3CpXq6 LuNXfi3LQILCjMBZBxw/PP7lBwSF3lA/DzkRSNbW1Fz2Wfbkgjha3Nh2sHpNeaX41Aqxja MVXftVl3yYLQand7KIw1V5wSpv2V8WE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fBeVWhnT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3NQpfZQgKCPYqfYiccjZemmejc.amkjglsv-kkitYai.mpe@flex--shakeelb.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3NQpfZQgKCPYqfYiccjZemmejc.amkjglsv-kkitYai.mpe@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700727351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CrEIDOduhti6InSDnRypg+BVJxqG3xXbxgAmhP0hxmM=; b=szB3jkj5sAhD7nagnkv576n7e3n8BVDEhdJCn106cFf5hM3lj6froYHVrnaLIp5NeT0r1e wPQ+nkZKUi42qlRqqDSXK1bWO21V1zTuINYPt+2g3Usv4rFi2e/PD7rQ1IWw40G6F0m+TH VzN8o8GyElv1zQI92BQ2U5hD9lv6ILc= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6b74afe92dbso708169b3a.1 for ; Thu, 23 Nov 2023 00:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700727350; x=1701332150; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CrEIDOduhti6InSDnRypg+BVJxqG3xXbxgAmhP0hxmM=; b=fBeVWhnTfjHFETjw2+ckh08no2Ol0v8IGaGsGbP4cNk/BdRIh1gEf1Mzl3qrqgBiL6 o0kz3mdSlJ54NYRa5OFelk8DdpbhoKKISBJCN0Y8a2HIVqfzmEIpsD7Il/Meuo5VTIOY KzgSvRpg5rhcq3sBIzyeyxZftm2qvLqHosWc/DZHyF2LYtEO1qMKZ35dzo/DsUqaqams VDgexf/LYjrbCzK+bQU9OIBRBULQRVuDpKVCY42oKEUZ5yyRHqizMaHeTEQ2ARemsNWy HrtXvbzsm4BH+Jdl/OAv6E4KbO6MIJlSE1iSn85HMxSYrYDMLiH6AAdr89WOvIIN28lO r0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700727350; x=1701332150; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CrEIDOduhti6InSDnRypg+BVJxqG3xXbxgAmhP0hxmM=; b=Kz//18CsAjxjW83tf3X9EsZ6LeWzWDC4a1ZrR1S8sG+GtsOGkKgBjWV375C33aPC4F K0UjeCFND4+w3FiRFX30cXXUUneV+7p4lc+Hgmvtq+8SO9nKV7XqDNuSWELV4e2o0qWD +JZBKyrlsTtUnQNeSLEoiEi5QLYOLFQ3JzSQ5Eb4Y3rnZn7vuQD85WrJ6x01F2p9Jm59 +wB1J11ILXorKrVV09m8cJQ2qV5lOfgj7GKqX4LXcT+qROF0y9dFeP9lCD9G/7EydKcv 4OCYgD49FPf7omeejAjRq3Esv6ShbP+Ej/n9D6GE5nfmD1eGhcKuhV0GT4f/s+AvBoPJ V5EQ== X-Gm-Message-State: AOJu0Yy7QyLnLCPRGVs8R6vHc3G3P71qZz+LuVJev+4wZS6E4r5oeSlf Uj97YR0D2HieI6Iq/ZGaNC6zNE21VNfQiA== X-Google-Smtp-Source: AGHT+IH9adT6B0i1q+P6CsoaxvjLgFLnosKLJplk4qIgLHNWoRCdaiFD4O87oq0Kh4mkVoq1iaj+K6sacIpqzQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a05:6a00:1da3:b0:6c4:ec00:2941 with SMTP id z35-20020a056a001da300b006c4ec002941mr1201225pfw.4.1700727349918; Thu, 23 Nov 2023 00:15:49 -0800 (PST) Date: Thu, 23 Nov 2023 08:15:47 +0000 In-Reply-To: <20231123080334.5owfpg7zl4nzeh4t@CAB-WSD-L081021> Mime-Version: 1.0 References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-2-ddrokosov@salutedevices.com> <20231123072126.jpukmc6rqmzckdw2@google.com> <20231123080334.5owfpg7zl4nzeh4t@CAB-WSD-L081021> Message-ID: <20231123081547.7fbxd4ts3qohrioq@google.com> Subject: Re: [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints From: Shakeel Butt To: Dmitry Rokosov Cc: rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 314E98001A X-Stat-Signature: 4j1b6oces1y91pwygbsts89mknjq8uoc X-HE-Tag: 1700727350-316900 X-HE-Meta: U2FsdGVkX1+V96JJDIjC/AFDuzSb8j6/YnDnQQMue3a2lDy+GILkslgW7QlfE5y8NB+aaKiGr93phovr0pD/8HyjL5IYv6ijGGcknpnxjI9bqkwng2070jXFFgO+7NtPym7tVgFCjaKDaawOVZ1CTlSNaZWO8qIFkNKMAenjO7zDGFVQvjfsAvaORn9qov331s5Hiu8V/Fk9nM9YzU5qoP/DRaCviGKPo9GEP7AH8OI9hmobD4O4BGl6TWsippKZ4ndDuORdd7PgQo7aA8JDgJpB/wAxenRc1h+BGnYLm0LQXKIvNeCetB+cZC/ykByY7Zs9u7WiwSDIy1Ez2RYxuoafm0wKX/9XSg+4l/ODi/bM66nlWRhWBJNhAjz80fPkCjIICwDKGgGKy0UgqZFKy4wOng6XZfPhkYddDDnrATd4cMsgrm5c0L8P8yrG8kUvonNKSFiuKlmWFRidOt6ZM6kIM0HDu7wTnZC0QsVP6ThwmgErzrDFd/qZXvesTPMx9UTuztSOuve3y4TlgJmXSKByPhvm9P7I2BM1fSdrMC1F0w+L+rQNBsSfUEWciZWlLXRh1tfWDv8+RAXQL1GrJPx0IwfL9lnxrzZd3bpjlR//k8B00daYJ1CTTGP0K54URlWIP+Rno4nNhHy+nXi0cL0XEPJWK2/xm1WhTI3f5GJx2UsUsQjtSJ5Kw8a9WoazGsY8gelDYfGNveHs0aSqpTXvon5E8++IHzuCAZNFt5FgJ0mxWCyfEKRFRqjzoquFGjhbtIAzoEBjPwfLLhY5+LbZ3UBYU+XNm8diN0Cjk1tP/ybRJzhLy03M9fRBFSLby16DdfrSJsgEx4dGD6ziJOcB6VUjv2sbLtRYiGp2ypME2nQ5QJJ20aGkN2jBEgoeG2btlau69pESH5a6HQb83i7VyXNYD3XOLFubaDogL+cUloKqKK5j/lbxH4qCl6oLy+27qyp8M3NxF1+VDcz UJEhSE4D TvysdQC3RuMFCdvQLfXujCzk8kQxlEl7xGhHlBtIsQq5JNp+lb+zoRZcAxRlaKc6SWDLloCWF9XGKJLiJXVSGLgsme4MEHoyS+c6y5GKDMQJVyWet8xamIYGMEf7bdIAgvlBIL/BkUl8aRfsiUtGxMYm4YmuoZv8UHrcU9HeN7/vD5EBEi2nqhcGaLmNVPBMJCJ411aTSzHl66fh5QEhCtbQzyz+XgUOuzMFSm5/IzxsIUf0JwD4CeVO0xcf1Furu43K0HPK0diqoJ0DEdYM3DGDNM78F7OseuMXZZIFVG8xaQQhKEf0D2sYR8gUf6y9EYTqCRljgl/pe+oYBPvsQZS1SN+u8jGQisCd0GTEVowNk80BDSVJgsl73cczuA6inAMqU3r/TVXWvWPs4+IPCNHOl9bDY2KF5hP5ztzYmW/eQl22T1gTdKHQDGhqsuIrusDk0lXdZFdjczl31yiU040w4btuQkzhIErA0QSxxoZCcBv+yqqKF/bAXSD6BSxIaiN8b8N4nalwsc+NZk3zD0yXQnogCdVDaJSh4kXUcpmWDdCPlAEKhfuYjsje19rRGjATkkSIiSnJElkmEAQX0PZgwsfQVq00mlKo7+PYj/X7L1fTJE6SVMlaQ8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.398433, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 11:03:34AM +0300, Dmitry Rokosov wrote: [...] > > > + cgroup_name(memcg->css.cgroup, > > > + __entry->name, > > > + sizeof(__entry->name)); > > > > Any reason not to use cgroup_ino? cgroup_name may conflict and be > > ambiguous. > > I actually didn't consider it, as the cgroup name serves as a clear tag > for filtering the appropriate cgroup in the entire trace file. However, > you are correct that there might be conflicts with cgroup names. > Therefore, it might be better to display both tags: ino and name. What > do you think on this? > I can see putting cgroup name can avoid pre or post processing, so putting both are fine. Though keep in mind that cgroup_name acquires a lock which may impact the applications running on the system.