From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E616FC61D97 for ; Thu, 23 Nov 2023 08:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65B656B04FC; Thu, 23 Nov 2023 03:03:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 609826B04FD; Thu, 23 Nov 2023 03:03:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AA5C6B04FE; Thu, 23 Nov 2023 03:03:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C25C6B04FC for ; Thu, 23 Nov 2023 03:03:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 097DA140E8F for ; Thu, 23 Nov 2023 08:03:42 +0000 (UTC) X-FDA: 81488479884.26.7E3D58D Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by imf22.hostedemail.com (Postfix) with ESMTP id BDE18C001D for ; Thu, 23 Nov 2023 08:03:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=salutedevices.com header.s=mail header.b=D4HCV6dF; spf=pass (imf22.hostedemail.com: domain of ddrokosov@salutedevices.com designates 37.18.73.165 as permitted sender) smtp.mailfrom=ddrokosov@salutedevices.com; dmarc=pass (policy=quarantine) header.from=salutedevices.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700726618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lKtCLctmBBF1Tsb0SyxySTIx7meumO6usFrm+TS9QSU=; b=T2Lg2MZCbQyfO5tP1NYxAHoU4SzF3dQlFxZzUTqa2yRUKYSO/pG5NgY8qzsR1enRuV9wUs 6p1RzSrZK+HUjIwfbonyMs5amqFsW0zL2zfX3woXB2HmBmK4VGKA3aAAUq/Jid2EXrGkR9 Mt35oNGhwGZlkjTjPT7TobjA0fnYDrI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700726618; a=rsa-sha256; cv=none; b=1p+rF4RREvbaHPtkmkS1NR29FHSZ6i5Tq0HaBX4fuMg2xzYHjZZefKbvHkBdBCZf1p8sZk h20y7gD2HHqt9W3IJOwHl0s9gKPjcm2GJcR7Ws1egz0hKsH4+KxrO8jY7RKwok/JyVi40+ sSILQGFA/4+8gfLdFu/WGC/qeFz3zIg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=salutedevices.com header.s=mail header.b=D4HCV6dF; spf=pass (imf22.hostedemail.com: domain of ddrokosov@salutedevices.com designates 37.18.73.165 as permitted sender) smtp.mailfrom=ddrokosov@salutedevices.com; dmarc=pass (policy=quarantine) header.from=salutedevices.com Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 967F710004A; Thu, 23 Nov 2023 11:03:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 967F710004A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1700726615; bh=lKtCLctmBBF1Tsb0SyxySTIx7meumO6usFrm+TS9QSU=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=D4HCV6dFilbsWayXzzkcs2T3NjL+YalHW9kY4+EXk8KX8O8DVINwNEMKhE1m/Jt98 DFKEZnQ4TuySorJZWAqyH1hva8f0bl7O9vE7Qobb20zuD5INDosOQ8b6FUcIm1TJVa rqCJkqK806c8WyR57ONIIyCGuDreWGDfE5pNIja7xaaOCJh4ILZThAhJZS3Pil9V4Z AA6YMS1B0yvlB78T7At+bPtUp3CwF5FV/0XNuk7eSKgGdrRrhhbRHFOYVRN/rpkXQg JUngGqB34jZ319nISBEcC0l987OrKgiz/G5uG8DyLXmESFsMBxH6r5fiH4briEGsjR s/jlm5GYwRLoA== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 23 Nov 2023 11:03:34 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 23 Nov 2023 11:03:34 +0300 Date: Thu, 23 Nov 2023 11:03:34 +0300 From: Dmitry Rokosov To: Shakeel Butt CC: , , , , , , , , , , , , Subject: Re: [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints Message-ID: <20231123080334.5owfpg7zl4nzeh4t@CAB-WSD-L081021> References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-2-ddrokosov@salutedevices.com> <20231123072126.jpukmc6rqmzckdw2@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231123072126.jpukmc6rqmzckdw2@google.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181550 [Nov 23 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 3 0.3.3 e5c6a18a9a9bff0226d530c5b790210c0bd117c8, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;100.64.160.123:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;salutedevices.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/23 06:37:00 #22507858 X-KSMG-AntiVirus-Status: Clean, skipped X-Rspamd-Queue-Id: BDE18C001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9ci78t9mwqyefnnnmp47juf5z7f6o687 X-HE-Tag: 1700726617-679503 X-HE-Meta: U2FsdGVkX19DbhuTZW3/VWwsVQOVKsnV0euW8U9TWZPNBN8iGnCjGRuCyenAjiuzDCRIfYoVogKB5WlxHiqCXX+W0lPRSt31AERgd9hqCnUb+rD9Vc6fEz3yRN8gCAhsVYlrbOtJX1GtIAr2oxJpNvgm06Q4gfJZ0++BK+U8Br8nLj7/Bcqm1EIkO5bYnDPRgk5WJoqwcyqgoklr+5uPFudk8PSTVbVfnNXgWNqbbFSoZkNxyhjTjeVtJ1DwDI/pkwUk1Cu0D4jhaC+A0CrE0aQKE/aK3aVLlleWYB715TKxAOfXZ+jmdMF1n0BCVY+BU3siESbKcpdwNYj84sz9MdlSxUzgmSk5jvV6UctOCAEIKQdF8ZuxnxLbr7YNFQWEd2v7JBBu0niIK3XPqF8sVlVhqS5bejgjj9zNBqYmjLR9/eySPFw36ruGtkpIBBhZsAcB3yFRdDEK/2zmWb5O+U3zPkjaN+9VWrQgM70njvQMLYVWTxhUTE3zMIAwR8GmNZzZtDA8/4pYeUjg9vKINhCMdvuttkU/08uMKcyTSP5AGX/uMt4DelHZhcksN8e7mlCOTTxi7FUNU3Z92GfT3lmqXtDZLC2YZHFXH88kWbxKlIOqKpptkBLnKB1bR5eIkrZ9FGjy13jykU7N/Xa0At2LGPMLLpZZNQsPN0tNtDC5bZ2QFl1AKCHclLUebEgrugjCXVr6Qa4Ylvod3W+LxZJ6heevZr+ZjyxMxdzyTXNPgp9hB5hUFDvlNOMBEybU2P52sL5bTMZISACLJP6UP7B/7mS34LBrLwEE6KFza6aSo3h5+wUD2a6+tjnCo4Dr1R4o+AHQ1zcgHua4KYDxCJGSkJODvZ+u5dhRHhf8BI6m1dL6vdpWn283CHk1NQ/vsTfPbwi0xatxJjZxGY2s2Nf5gJvjoJ2CXlw0VL35YEJ13Yf7HpP/pYn1UNUba/4CjhdB6wpJdQq7alQyNeO Lerjn2xI GVVBj8TnRU+DhGCq67lS7RFKEe0H9mfAce62tYIU4IwsNRTO3Cxxv3WN+b3Fp+LwwFAofa6gCu4mPOf9HWttNivX4KQ2bk81mFB/rPLTkOaTDzWlDwCJX42O1HSipWSYRv7/lTpdpKRodPJ3x6dg8x5x0xE2W3NEH/Hf2fUVzQPzkpCLcgO4gOfJ8PE9kDYkB0mtuuYzxGmpGI6/hQXC4fqRZ4YQeRPZlFSL1Q2BbxIoHTeEpymr5XcQa24k77vmZbXjqUZX92ZIt1hZSxqzLlcZdNYTSrza95LEZvuIIVooBqxR0oLMVXKLZNVLcJc77GQoKjNrImrPV9XD6dKOKeZOKaOEcupL0jM2yBCoGvlAE54Kq6JzGkCHWLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Shakeel, Thank you for quick review! Please find my thoughts below. On Thu, Nov 23, 2023 at 07:21:26AM +0000, Shakeel Butt wrote: > On Wed, Nov 22, 2023 at 01:01:55PM +0300, Dmitry Rokosov wrote: > > Sometimes it is necessary to understand in which memcg tracepoint event > > occurred. The function cgroup_name() is a useful tool for this purpose. > > To integrate cgroup_name() into the existing memcg tracepoints, this > > patch introduces a new tracepoint template for the begin() and end() > > events, utilizing static __array() to store the cgroup name. > > > > Signed-off-by: Dmitry Rokosov > > --- > > include/trace/events/vmscan.h | 77 +++++++++++++++++++++++++++++------ > > mm/vmscan.c | 10 ++--- > > 2 files changed, 70 insertions(+), 17 deletions(-) > > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > > index d2123dd960d5..9b49cd120ae9 100644 > > --- a/include/trace/events/vmscan.h > > +++ b/include/trace/events/vmscan.h > > @@ -141,19 +141,47 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_direct_reclaim_b > > ); > > > > #ifdef CONFIG_MEMCG > > -DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_reclaim_begin, > > > > - TP_PROTO(int order, gfp_t gfp_flags), > > +DECLARE_EVENT_CLASS(mm_vmscan_memcg_reclaim_begin_template, > > > > - TP_ARGS(order, gfp_flags) > > + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), > > + > > + TP_ARGS(order, gfp_flags, memcg), > > + > > + TP_STRUCT__entry( > > + __field(int, order) > > + __field(unsigned long, gfp_flags) > > + __array(char, name, NAME_MAX + 1) > > + ), > > + > > + TP_fast_assign( > > + __entry->order = order; > > + __entry->gfp_flags = (__force unsigned long)gfp_flags; > > + cgroup_name(memcg->css.cgroup, > > + __entry->name, > > + sizeof(__entry->name)); > > Any reason not to use cgroup_ino? cgroup_name may conflict and be > ambiguous. I actually didn't consider it, as the cgroup name serves as a clear tag for filtering the appropriate cgroup in the entire trace file. However, you are correct that there might be conflicts with cgroup names. Therefore, it might be better to display both tags: ino and name. What do you think on this? -- Thank you, Dmitry