From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7735CC5AD4C for ; Thu, 23 Nov 2023 07:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 132266B065B; Thu, 23 Nov 2023 02:21:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1092A6B065C; Thu, 23 Nov 2023 02:21:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F14636B065D; Thu, 23 Nov 2023 02:21:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E00EE6B065B for ; Thu, 23 Nov 2023 02:21:30 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE8691CC106 for ; Thu, 23 Nov 2023 07:21:30 +0000 (UTC) X-FDA: 81488373540.25.D42A4F2 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf13.hostedemail.com (Postfix) with ESMTP id 0870920020 for ; Thu, 23 Nov 2023 07:21:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KL7YCeHZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3eP1eZQgKCCEPE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3eP1eZQgKCCEPE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r8JBfcJ8qyLmIM0+mXWtuL3nULYBHmRUxetXZ1VMVrE=; b=bOdVsXl0wxSPUrZhaClcnwgyBAHG1wnkW4soWZo58TXEEd6FbhbE8F1aMDXXMYQnFDze8C GEB4h2+9gH2hST9vPXMaeNF7UMgpeIZK0oVopmE5vmfQsrlTJ8U9vBv4oyKWsqu80OFJxr 4BrI4ts3HBFvFgr8clb7wayb8T4zHUw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KL7YCeHZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3eP1eZQgKCCEPE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3eP1eZQgKCCEPE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724089; a=rsa-sha256; cv=none; b=7yXx3dQdTADL6yJiPtkGW/QlUfRsIBsW+IoUjB4RF+Byn/OMSZizspQCOXWre5qWef3a8V jAyCau4cZr8aeLxEOgb4aqp2kx5PDziHmJvp2/i6CkVl2hnKhlczOTvcDEJaAoSv877OdA 9cYvmn1l6phWavck8sBqkAfx0JtpEjE= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5cd1172b815so4295507b3.0 for ; Wed, 22 Nov 2023 23:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700724088; x=1701328888; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=r8JBfcJ8qyLmIM0+mXWtuL3nULYBHmRUxetXZ1VMVrE=; b=KL7YCeHZQR6cnLBfitGgwZVN1F9lOlMFn1s93F3mo0gdZMdvWexwT18UNeIawYszF2 jrljtxpK5wo0zMOeLJvd9iBbg1oKZ1MxGMibqOhmPapGyBNzaDd4/wHl95qfYA5JnO9d 14aeSott7OEma9ww9jKVqcUfEka7Y+yTwFY8EkNfwD4Z3aaHqX6j046u/oa3Vx5xvCwl 458mCw+QyX0gZGGTbUCW04e4lxG3vv6MeLtgvi1jxhwpjmrFXxmWiaVVtzca0x8PIYcJ tVDRqmMgFKedNXloZ6SfMKQmyqI0CvB8XB3BTKopJWCbeoziH890HomLupKEQF5ZjLAV YHNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700724088; x=1701328888; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r8JBfcJ8qyLmIM0+mXWtuL3nULYBHmRUxetXZ1VMVrE=; b=EV4I8vHbgklfyreVUvNbW2Ly7qhMjgxtalf4m7+bLp5oe33NYYFMbW/+O+He3y3vz0 laG2WCnRxXEaX4JOog141wYM8tzjVJwUFMU8ABz2lwE3xelmVBMSoKnKItb95fIcn0Tr 1qH9sB8O+FON9WWpOfaMSoe4jsC6vbWwCjkEGYbG5hI9N/6bbjrBWJTlKHPvilpSqfgD lFKoie8w6JRcvv2jJwLp+CwxQaK6EPwpBdD6pl7BGD5ACZ6/lPVMW4+7Pk8BIW5CSLAG OF9a8F11feg2kMclosQucDKnh+/6SA/+8+QU7+741QfdjNklVmWxEhHv63/+dLpM7aIO 8HBw== X-Gm-Message-State: AOJu0Ywblktuo1UT1fvS1nBeMEJYSo0DsxBSuJOcONrAKQPbcs8oKgOO uj3fhbx5NmUEMs7U7GQ8pFo9cDL1WXe6Vg== X-Google-Smtp-Source: AGHT+IFYdCsJQiQuLcEuCdROYl30YmhIrJJ8nUSo92pShPtyIO5a4M+pfwcgYC77/VUh4eoadKQB9NuNUVtgUQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a05:690c:4091:b0:5cc:a957:2557 with SMTP id gb17-20020a05690c409100b005cca9572557mr62016ywb.0.1700724088168; Wed, 22 Nov 2023 23:21:28 -0800 (PST) Date: Thu, 23 Nov 2023 07:21:26 +0000 In-Reply-To: <20231122100156.6568-2-ddrokosov@salutedevices.com> Mime-Version: 1.0 References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-2-ddrokosov@salutedevices.com> Message-ID: <20231123072126.jpukmc6rqmzckdw2@google.com> Subject: Re: [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints From: Shakeel Butt To: Dmitry Rokosov Cc: rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 0870920020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tfahuq7stxkfdku3ef4f4n9f9uxzfgtr X-HE-Tag: 1700724088-479083 X-HE-Meta: U2FsdGVkX18DBrwW6sTmlkrwFe2IWEeMLEWYq+wK2+BN+ykKjmvc2Qi22cfCc1AAUzJBWaIkQwU3akiHYiEHy2Hips/qhX/WAfPpTJHeKFiPpnXi8bmeoSY9tg4SYrAg2GQMlDOwOMHDl2zIVL0LlaDTFyZv/076ISn8wKUTGjWrgpGW9KSoZeWcWC7lL5baJUp4acvlMNIjyQ5YTUfQSz6Gu776QQmpZyM02Yyf1vq3Rp+AYnlb4tb4lMj1Swea3gTxYOOKekxTrT8HRoz5Pbq4r8rgMywBhZReWuOP5t82kNbUVVl3gE3VDBzKeaxTg6OER3/8mBeO+w9JioALAvKVBltiMEhhBKnsY6LyOpA8A1p7anOMuvk9U2ZCVFOtRtC88IFIcJvUUqWurVR1/HpMDHJjOt7wss2fmYPmnOxqGXHVuwT5V1TXZLITL5Nm8P52dzC1khiFTOVbdxx4a3LIz9O9YtrW/UAa7k5ny3+XIO8K+8hXo5XKoI3QJDAt2b/pOrZr/9DHjQgehVDyfe/PgCKDJSc09lD3qrkvayzPQTZ8bnCtupf06A7qFDuc3Xai4/AMP2QGdb6wpg3fqTKgYr0pbD0CdnepOcHP//hC4P8D9PA5DaHzFYoRt6TOTsKcLQzVQn/c+OPL4UHvimBEYczweYcrjUfSY392vbvNRi3K9Qu3E8ciedUGUu0Y8IBNo94u7dTGNeB+JJc6cgJHfczK40AgVsqAXVQOk5IzzO1Skm1fOZ4ZIidvT7sSWFyTepIWFHmIGPGP/UX3piVSu4AZlVIG0OGsdL4EFjiBU6N/3ikYmLxawx7lhKADmLwaazTISYU7D+VCPDW3ZZdcXi+D0VqDBA7EldMTvTatmQSYyyKAg8gy1EhfSklZO+h3LIcQBxUajDS3/fdZvpeC6BMoxL1r/Yil/gcR/Po1lqWB+H71vbgAkOu+soYKS3S3C6+0VQMn3nfxzL5 nzhbjM8I jX1E6Rj9ZvGBQTD7Yheeo6cJqK2VVsW8h8P3VlO2q9kKDLYHx+ullhE0i9+ejD+ENwXvWeO9khWpVjAeVQWgv1GJbCK/8rMrWNxP+cHVwZ2JUG056Jtt2tjNyP46rUF2h2oHWeBAo2HDKodxLJ+iMozC9SCN8b3oz7oLX7IME41pGvE+w3XdKOzLGRD6zrNE/oi9tDmJ+6w6UeruPXMwCdyy7zzsmQUgW2HiGBlH0xBpQY6Losac9YjoTFvEXtRdBfSIxH0xe9nVJbeL+kX1UUX/rn7/jjvUvoW3a9B1zoVJzsqw3kdUKa73ilBocPbgTH6O+CbipLgY/+AsCJt48wnI31Uefs2+ioMSPBI20xP49XmqQosLUjRxmbrALjb6fT7c80ZOZgYKvLaHJ3kh7kFI+j+ua2INQ3TxhXnlZLtTSrQ9iEcYE3BEED9HgflmqFlWMfdTtpT9uQmPV0DespDnrhq4oBg2P6iUGuCEXO1/2BmVyADryr52gmiCYRhfCFAw9kHICS2vOGEe68L/cMAkMrG9R59RbprpZYZshvlsfFzoB0/xC6eGGUR0xWBfZCzTezdt7a0phzSIBT9ixGbCrbRMfqrr2+zvq1k0wffyVuzPgwpIjyBuBExzYSbMds420dNrfVd/JiUhwXzA/6vXDKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005783, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 01:01:55PM +0300, Dmitry Rokosov wrote: > Sometimes it is necessary to understand in which memcg tracepoint event > occurred. The function cgroup_name() is a useful tool for this purpose. > To integrate cgroup_name() into the existing memcg tracepoints, this > patch introduces a new tracepoint template for the begin() and end() > events, utilizing static __array() to store the cgroup name. > > Signed-off-by: Dmitry Rokosov > --- > include/trace/events/vmscan.h | 77 +++++++++++++++++++++++++++++------ > mm/vmscan.c | 10 ++--- > 2 files changed, 70 insertions(+), 17 deletions(-) > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index d2123dd960d5..9b49cd120ae9 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -141,19 +141,47 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_direct_reclaim_b > ); > > #ifdef CONFIG_MEMCG > -DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_reclaim_begin, > > - TP_PROTO(int order, gfp_t gfp_flags), > +DECLARE_EVENT_CLASS(mm_vmscan_memcg_reclaim_begin_template, > > - TP_ARGS(order, gfp_flags) > + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), > + > + TP_ARGS(order, gfp_flags, memcg), > + > + TP_STRUCT__entry( > + __field(int, order) > + __field(unsigned long, gfp_flags) > + __array(char, name, NAME_MAX + 1) > + ), > + > + TP_fast_assign( > + __entry->order = order; > + __entry->gfp_flags = (__force unsigned long)gfp_flags; > + cgroup_name(memcg->css.cgroup, > + __entry->name, > + sizeof(__entry->name)); Any reason not to use cgroup_ino? cgroup_name may conflict and be ambiguous.