From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA07C5AD4C for ; Thu, 23 Nov 2023 13:12:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0BA16B06A9; Thu, 23 Nov 2023 08:12:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBC116B06A7; Thu, 23 Nov 2023 08:12:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A739C6B06AC; Thu, 23 Nov 2023 08:12:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 86CD06B06A8 for ; Thu, 23 Nov 2023 08:12:25 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5C1D9160F5A for ; Thu, 23 Nov 2023 13:12:25 +0000 (UTC) X-FDA: 81489257850.24.A3ABA76 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id EA8CF100010; Thu, 23 Nov 2023 13:12:21 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nSfg5H2P; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700745143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xzA033fdoqXrxfgQaSHInAmlzEcdawZjWPyJDVH/mDo=; b=GDIcYmirI3By6RTOGLj5C+BAhOoT4o0MlsnRmcq6M/SiIkWWXh+GjjSs12VKWkNWapFoFl FPJKKXvAIeOx40s+MtWVaPZU5Ze4TWp+ZC13YRMKHQq4PNy8n2j3Z7h+aeHo8v54WiDIQ7 V9ojFkCuX4DXzEqWrneG6MLkeqf5v0A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nSfg5H2P; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700745143; a=rsa-sha256; cv=none; b=nk8lKVQ3crqp48c4Bk7wfIy3hEb5Nc5itiImn0OZP4RBN4+FGemjcFGE8NlNpzr2NeX2CQ LxEn/mYokaN8nAzDXELy4FBjt7GZ3IhzMx/c079lCDESPSv3f++bpWh5G9EdmY42qRY+eF Wq6ZrydNrYvSy+oBKSpjXjOh11PlqbI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EF5AECE28FE; Thu, 23 Nov 2023 13:12:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B246C433C7; Thu, 23 Nov 2023 13:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700745135; bh=VBAn7FZcvw1drif9KzTmaabLPVAYO4zX2eeQPqBTwFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nSfg5H2PW95uhmCyWswaCk18HBzNnUr8lrZC9/jswVOaVEk9Necoc/3PSsg/eWI+c nUSNVQiBVNuTkdJG4ZroseK0fKTuKodiCnTfp5VBFncFM3thhaeXbqdq7/1OyUlFkh hvhoTdxdxKP2qiIgsXRrtgQ8aW/glFRtrG5pk0o8niH7Far3mtrppzle/A5KWCQFN1 0J9D7XnhqZQWKtQ8+7lAsz1DeizPazr+k6Se4xCbJkyOxPi+pXbCyvcnpPCySfoTu/ nxY4zeQuXLH9O0FYHNYyhAuFpYV+0VZCYLV3awl8R2o5zjol3Qy1blkTCXoR/k3lKT V10Lsp2N5sNOQ== Date: Thu, 23 Nov 2023 14:11:56 +0100 From: Christian Brauner To: Zhenyu Wang Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void Message-ID: <20231123-randlage-instinkt-e458628d2d7c@brauner> References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: EA8CF100010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: j6s7f94yyq6zcdy5968oe84bne3oare9 X-HE-Tag: 1700745141-70894 X-HE-Meta: U2FsdGVkX19X1AvF3CPtgQji9Y+p/gkXCGs26dWzjBEfwctpAcyYr2uqO86VXtY9z8F/S73rOIQH++92wzueIZIGoEBgmT6YubbmkwcqEqM4UsCXx4q3NXV0JOv73dUukVkqPTLM1RUGVpHEeQnH6xFZ6oqPmF7pp8z4F4ED0gQxSCfbNhJj0aMASzit0bo6+JYE1zANxZDH6+f1C/3wF4S/Y+cb7BE2Wc0Tsrg/iAwLkk4MT7H20q6o/6VM7aheYjxkO3m4BnMaO0NxFHu7VXanzj3Gt4PWBbjsQRy2lpKHBrMJj1H01oPWU5zIIrR80z+k3eRoOcGvxHQrhtDihHCtejwAOne6p/keNgxAnjGhnqsBS8UF+iFyw9k90/dLE/dV1ywvHRqEPGe04Sv18vvr0p6PUZ1GXUvIDv3r8vwyhTzfKQZmQiPeRX2eCBuTP/GIyoXKugV3VZvTW+XVSwPrzBEf0qAwtKg2W0KswN/U/nZ53iHZ7WY+XaCPnQ9dBXwhU4AbQaIROV8EuXn6lb5CQEI/9bmIPaXwFLhtEtzSjcUUAI3EG5LL+iwubezq3x0Z6pd+y6QbYLwnqhIuQk+kWxjpC9W3HZfzoSty3rJab00ytRCAxSSQJzVMqg/Bykz80bqB5J2oNuohm3MhwNJSo5pNrBMvTo1eq5olfR13y5qaLLErCoHW80rulrUlt5bmrbCOmvATGfURT4m+QJsjDvPPFMbTWyLukutlrO8sm81AhPzlbKRWALgRhfQqZgIFhnOxHFdO6F3Rr4XKf+TJ6yo4fqDcxO+5zyN/sGfGYEpclkoSuCKEeunvEKz5H6552x6DV9NK4lqU3FiYjXnIqwFAq9noAYgjDGAvn+/xwRikW17kt+j5pHd+REvSz56q7uNWCU8xZXEAwaHOVuFCw8JX8OTyV264uM+MXxzrvLI89DOchSylklarRhQ2qz7wCG/IlOvAKYaw4kC 0nTpX0qC vX/O2u1eln+GV4O0wNs42XZFCxoW3b5KqtWbEBZL3gdA44FftR5yKiplXAB1ZCBRd/HbQzHSMz+LCGeYv9lbc8maBgLIw7JgorrxKhbnfMIPV+HW8Fz28gSAH/tA+HxilysqUEEJtTS5dZmN2H7j2Z6JICzn/FrBC598MTPXvFEaqySFDhbA4dZUOEgw/6WY/cm8Wq648l8odv8oC4dNWZcUu14Zvr9LFIdGXrY7/eK91DLA8DCwI6cu3vIKgg9ca76TEJVKo8Fq2eRtCcG8wPWnuJeSLtKmGuOPj5thomzWS4CUM0VvJes8G4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + if (!vgpu->msi_trigger) > > + return; > > + eventfd_signal(vgpu->msi_trigger, 1); > > } > > I think it's a little simpler to write as > if (vgpu->msi_trigger) > eventfd_signal(vgpu->msi_trigger, 1); Good point. I folded that suggestion into the patch.