linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Subject: [PATCH 5/7] mm: shrinker: Add shrinker_to_text() to debugfs interface
Date: Wed, 22 Nov 2023 18:25:10 -0500	[thread overview]
Message-ID: <20231122232515.177833-6-kent.overstreet@linux.dev> (raw)
In-Reply-To: <20231122232515.177833-1-kent.overstreet@linux.dev>

Previously, we added shrinker_to_text() and hooked it up to the OOM
report - now, the same report is available via debugfs.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---
 include/linux/shrinker.h |  1 +
 mm/shrinker_debug.c      | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
index 497a7e8e348c..b8e57afabbcc 100644
--- a/include/linux/shrinker.h
+++ b/include/linux/shrinker.h
@@ -143,6 +143,7 @@ __printf(2, 3)
 struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...);
 void shrinker_register(struct shrinker *shrinker);
 void shrinker_free(struct shrinker *shrinker);
+void shrinker_to_text(struct seq_buf *, struct shrinker *);
 void shrinkers_to_text(struct seq_buf *);
 
 static inline bool shrinker_try_get(struct shrinker *shrinker)
diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c
index 12ea5486a3e9..39342aa9f4ca 100644
--- a/mm/shrinker_debug.c
+++ b/mm/shrinker_debug.c
@@ -2,6 +2,7 @@
 #include <linux/idr.h>
 #include <linux/slab.h>
 #include <linux/debugfs.h>
+#include <linux/seq_buf.h>
 #include <linux/seq_file.h>
 #include <linux/shrinker.h>
 #include <linux/memcontrol.h>
@@ -159,6 +160,21 @@ static const struct file_operations shrinker_debugfs_scan_fops = {
 	.write	 = shrinker_debugfs_scan_write,
 };
 
+static int shrinker_debugfs_report_show(struct seq_file *m, void *v)
+{
+	struct shrinker *shrinker = m->private;
+	char *bufp;
+	size_t buflen = seq_get_buf(m, &bufp);
+	struct seq_buf out;
+
+	seq_buf_init(&out, bufp, buflen);
+	shrinker_to_text(&out, shrinker);
+	seq_commit(m, seq_buf_used(&out));
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(shrinker_debugfs_report);
+
 int shrinker_debugfs_add(struct shrinker *shrinker)
 {
 	struct dentry *entry;
@@ -190,6 +206,8 @@ int shrinker_debugfs_add(struct shrinker *shrinker)
 			    &shrinker_debugfs_count_fops);
 	debugfs_create_file("scan", 0220, entry, shrinker,
 			    &shrinker_debugfs_scan_fops);
+	debugfs_create_file("report", 0440, entry, shrinker,
+			    &shrinker_debugfs_report_fops);
 	return 0;
 }
 
-- 
2.42.0



  parent reply	other threads:[~2023-11-22 23:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 23:25 [PATCH 0/7] shrinker debugging improvements Kent Overstreet
2023-11-22 23:25 ` [PATCH 1/7] seq_buf: seq_buf_human_readable_u64() Kent Overstreet
2023-11-22 23:25 ` [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Kent Overstreet
     [not found]   ` <deed9bb1-02b9-4e89-895b-38a84e5a9408@gmail.com>
2023-11-23 21:24     ` Kent Overstreet
2023-11-24  3:08       ` Qi Zheng
2023-11-25  0:30         ` Kent Overstreet
2023-11-28  3:27           ` Muchun Song
2023-11-28  3:53             ` Kent Overstreet
2023-11-28  6:23               ` Qi Zheng
2023-11-29  0:34                 ` Roman Gushchin
2023-11-29  9:14                   ` Michal Hocko
2023-11-29 23:11                     ` Kent Overstreet
2023-11-30  3:09                       ` Qi Zheng
2023-11-30  3:21                         ` Kent Overstreet
2023-11-30  3:42                           ` Qi Zheng
2023-11-30  4:14                             ` Kent Overstreet
2023-11-30 19:01                           ` Roman Gushchin
2023-12-01  0:00                             ` Kent Overstreet
2023-12-01  1:18                             ` Dave Chinner
2023-12-01 20:01                               ` Roman Gushchin
2023-12-01 21:51                                 ` Kent Overstreet
2023-12-06  8:16                                 ` Dave Chinner
2023-12-06 19:13                                   ` Kent Overstreet
2023-12-09  1:44                                     ` Roman Gushchin
2023-12-09  2:04                                       ` Kent Overstreet
2023-11-30  8:14                       ` Michal Hocko
2023-12-01  1:47                         ` Kent Overstreet
2023-12-01 10:04                           ` Michal Hocko
2023-12-01 21:25                             ` Kent Overstreet
2023-12-04 10:33                               ` Michal Hocko
2023-12-04 18:15                                 ` Kent Overstreet
2023-12-05  8:49                                   ` Michal Hocko
2023-12-05 23:21                                     ` Kent Overstreet
2023-11-24 11:46   ` kernel test robot
2023-11-28 10:01   ` Michal Hocko
2023-11-28 17:48     ` Kent Overstreet
2023-11-29 16:02       ` Michal Hocko
2023-11-29 22:36         ` Kent Overstreet
2023-11-22 23:25 ` [PATCH 3/7] mm: shrinker: Add new stats for .to_text() Kent Overstreet
2023-11-22 23:25 ` [PATCH 4/7] mm: Centralize & improve oom reporting in show_mem.c Kent Overstreet
2023-11-28 10:07   ` Michal Hocko
2023-11-28 17:54     ` Kent Overstreet
2023-11-29  8:59       ` Michal Hocko
2023-11-22 23:25 ` Kent Overstreet [this message]
2023-11-22 23:25 ` [PATCH 6/7] bcachefs: shrinker.to_text() methods Kent Overstreet
2023-11-22 23:25 ` [PATCH 7/7] bcachefs: add counters for failed shrinker reclaim Kent Overstreet
2023-11-28  9:59 ` [PATCH 0/7] shrinker debugging improvements Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231122232515.177833-6-kent.overstreet@linux.dev \
    --to=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox