From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DAEC61D99 for ; Wed, 22 Nov 2023 23:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 222726B05FF; Wed, 22 Nov 2023 18:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D2496B0600; Wed, 22 Nov 2023 18:31:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1986B0601; Wed, 22 Nov 2023 18:31:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F0E926B05FF for ; Wed, 22 Nov 2023 18:31:51 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CAF2B1A180A for ; Wed, 22 Nov 2023 23:31:51 +0000 (UTC) X-FDA: 81487190022.29.3DB40F7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 1F52040019 for ; Wed, 22 Nov 2023 23:31:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=GbpA=HD=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=GbpA=HD=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700695909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VSNNdj63p9nsa/828yuJwwnsBA86uGXb5ZC3Qc34u70=; b=LcmYpgAHN1NIltmn6sxmpPBpGHFziwonMeOYBrC7Wo52jRNc6NOZC1pl+BwNTNd925fxZV ezcY+hggs5IR1VknE0q/ZerqISwJjrxDltNJGUF7DEJPeRxFo1SEsv/LSS8j8PJNfGr6q+ dz6AQM2SG1N6huwMEi2XHYR2dpYHeAs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=GbpA=HD=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=GbpA=HD=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700695909; a=rsa-sha256; cv=none; b=6JLvZphGzvW2qXAyQXCDX7su4jPoORPONa9wwkv2dyQf3PVdI6pmWo3sU8ZiuqC6EbGJac cH6X/69fvjp+eDimuRNdziibf8UrnLaQ5mhZbLepnWknPDYvkcC/wfNaUY5ByKesIGLe7P viPljUEJuD13fDj6BwjCItarLXatoIc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 49FC8B82A05; Wed, 22 Nov 2023 23:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 264D8C433C8; Wed, 22 Nov 2023 23:31:44 +0000 (UTC) Date: Wed, 22 Nov 2023 18:32:00 -0500 From: Steven Rostedt To: Ilya Leoshkevich Cc: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v2 01/33] ftrace: Unpoison ftrace_regs in ftrace_ops_list_func() Message-ID: <20231122183200.409e982b@gandalf.local.home> In-Reply-To: <20231121220155.1217090-2-iii@linux.ibm.com> References: <20231121220155.1217090-1-iii@linux.ibm.com> <20231121220155.1217090-2-iii@linux.ibm.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1F52040019 X-Rspam-User: X-Stat-Signature: 5rw7gpjfcrtiizkmjtm6ucy1cf8wkkus X-Rspamd-Server: rspam01 X-HE-Tag: 1700695908-593709 X-HE-Meta: U2FsdGVkX18rlOJqLrcjdxyWIWrX9ad4PHxUweE7MUGs4F2w8CHHGtKxRGz1AzEzQMoVRQQEr/Aco+KTDFLiWINntwHr4G7tDVYo4yl/i68zbVrYum7NcpQ2Zmh7izz+GsAPURA4lq/DX4cv06AoSbEdcbm4rYfhdXZvv0IiVmtU8tyKAWO6HUl0iIAncPjPXwMqgCU/IFKqRNkzMStndAqJFmF8n9mhR7zgpU3hKXph5dTUnQKOdLwcW0THStejf8EquLvjOLvzmRcDQ3j8aOoATBmRXJ0D668bKMP4buHpgj0QKIFLaohFHepqHrw/ek22tCwO//88qIi9mSkkLMOuWMIxKRX+yZizKiyGJFGERAPmbuvnZiB/Q+Lh8KslQKm2fuTzYhM61AxodGhi2aR1RGXJIPBX5qv6QtnjWvlMR7wVtbrdQPOuXyRMgJODZDIjTCLaL01hNJ8hrfcsgx5K2EUjwKOWn20rCfVyP2HYELdmhZv/+oNrprGO1XFv/GoVDvWdQah4RsNg7ujfNAqF4NMFbCL8ddjYu86iFpWVNpAlPxr7ok8pHOaBXfNb86ye/Na1bW53X9XLtrIGOgCYUXNfFXIZ5kunEIDpXXr7eGOXpyH9w5QTepPHsoSKsnXHCJn/SVJ8kBuZhxM2GxECPjxn3PNmSmY0FCuNg/psLdinkgUini7njq3i38LRfUT4mcmh2H4oUgia0R3xby/Qfkw5Ug/Ea3XvEDidPgWWH3gEztPeVwXtqyu1NkckXOg20WYhhKj9+XKXWO2FpZV3a/aKc7l1blVpaTmC+5ejnuL+fHg4bCMp8trwChC9reQ8IQPEfb18CwnkDI4vN1u0ghfZ6SfMqUGYTyOQeYzIDG7XiIN5PVIm1cPDbtf1xgwP64AQsQuyUrkOpf6YoYXf4K8lr4NFNP+WnHV9YleDDBcj7BnT91uyKZWziaxOYRNMVXk/hHfAoFDubC1 Q6fLfnNQ glDwEQ7Rq8d/Mcn+3aDPcr3LwlIMTupADjkz/O77IT/r5d/MJ6wovPmrIfan2WJ6nHO3jFzD++HS0pQNUOjvyxz59Ir9VeXNwFYKf2P4h/ZXi8Wb+qcqTbqXBcts6tEJlXw4V4FCveQG3ccEHu/rsTN5eaYvm1tb9rAjBv7B5M1xdBc9joUjE7yihrcZKUkkYSX5HN9wyet7pA1SkGT8Wi1ywefbG9obWTaNz8fUbpSp6+8UJD338xBo1PqO1ZzorEMXMZbOlZW8eDz1lZuKlMb8P6EgfixdVItrBPdAyGQAzMpNFQ5HT+pFrKYkhxaRcHIsZoDHzakcVNjrij5IgrhSZciRWFX5ndz2cjpxXnInLHOViEeKrIAH63qy1wQIV1iMCVTu9Nb3waC8cJwRxnlARmwibMYBrNeGRG01bGUVlvopdxyJ3YOOb6bwwag6o1wMT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 21 Nov 2023 23:00:55 +0100 Ilya Leoshkevich wrote: > Architectures use assembly code to initialize ftrace_regs and call > ftrace_ops_list_func(). Therefore, from the KMSAN's point of view, > ftrace_regs is poisoned on ftrace_ops_list_func entry(). This causes > KMSAN warnings when running the ftrace testsuite. > > Fix by trusting the architecture-specific assembly code and always > unpoisoning ftrace_regs in ftrace_ops_list_func. You must be very trusting to trust architecture-specific assembly code ;-) Acked-by: Steven Rostedt (Google) -- Steve > > Signed-off-by: Ilya Leoshkevich > --- > kernel/trace/ftrace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 8de8bec5f366..dfb8b26966aa 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -7399,6 +7399,7 @@ __ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip, > void arch_ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip, > struct ftrace_ops *op, struct ftrace_regs *fregs) > { > + kmsan_unpoison_memory(fregs, sizeof(*fregs)); > __ftrace_ops_list_func(ip, parent_ip, NULL, fregs); > } > #else